From f61047511f2ace9af9a02a1d32c88f735f486128 Mon Sep 17 00:00:00 2001 From: Walter Licht Date: Sat, 13 May 2017 02:55:54 +0200 Subject: [PATCH] feat(saucelabs): Removed unnecessary username and acccesskey from capabilities and fixed build in capabilities to be only overwritten under condition --- lib/driverProviders/sauce.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/lib/driverProviders/sauce.ts b/lib/driverProviders/sauce.ts index e70984545..36b8a733c 100644 --- a/lib/driverProviders/sauce.ts +++ b/lib/driverProviders/sauce.ts @@ -60,9 +60,13 @@ export class Sauce extends DriverProvider { agent: this.config_.sauceAgent, proxy: this.config_.webDriverProxy }); - this.config_.capabilities['username'] = this.config_.sauceUser; - this.config_.capabilities['accessKey'] = this.config_.sauceKey; - this.config_.capabilities['build'] = this.config_.sauceBuild; + + // Avoid unexpected behavior if users set build capability as supposed, + // but don't break legacy code using config_.sauceBuild. + if (!this.config_.capabilities['build'] && this.config_.sauceBuild) { + this.config_.capabilities['build'] = this.config_.sauceBuild; + } + let protocol = this.config_.sauceSeleniumUseHttp ? 'http://' : 'https://'; let auth = protocol + this.config_.sauceUser + ':' + this.config_.sauceKey + '@'; this.config_.seleniumAddress = auth +