From ca0208b1c765b94162e4fbe21d7ec13de3d16172 Mon Sep 17 00:00:00 2001 From: Nathan Thompson Date: Thu, 23 Feb 2017 17:51:43 -0700 Subject: [PATCH] fix(firefox): Fix legacy FirefoxDriver support Conditionally instantiate the firefoxService. The legacy FirefoxDriver fails to start if it is passed an executor. --- lib/driverProviders/direct.ts | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/lib/driverProviders/direct.ts b/lib/driverProviders/direct.ts index 71f0d49e9..eb90ab2e1 100644 --- a/lib/driverProviders/direct.ts +++ b/lib/driverProviders/direct.ts @@ -116,7 +116,11 @@ export class Direct extends DriverProvider { // TODO (mgiambalvo): Turn this into an import when the selenium typings are updated. const FirefoxServiceBuilder = require('selenium-webdriver/firefox').ServiceBuilder; - let firefoxService = new FirefoxServiceBuilder(geckoDriverFile).build(); + let firefoxService = null; + if (this.config_.capabilities.marionette) { + firefoxService = new FirefoxServiceBuilder(geckoDriverFile).build(); + } + // TODO(mgiambalvo): Fix typings. driver = require('selenium-webdriver/firefox')