fix(snackbar): remove even if still animating open (#1797)

Author: jelbourn

src/lib/snack-bar/snack-bar-container.ts

@@ -92,8 +92,7 @@ export class MdSnackBarContainer extends BasePortalHost {
 
   /** Mark snack bar as exited from the view. */
   markAsExited(event: AnimationTransitionEvent) {
-    if (event.fromState === 'visible' &&
-        (event.toState === 'void' || event.toState === 'complete')) {
+    if (event.toState === 'void' || event.toState === 'complete') {
       this._ngZone.run(() => {
         this._onExit.next();
         this._onExit.complete();

src/lib/snack-bar/snack-bar.spec.ts

@@ -1,4 +1,12 @@
-import {inject, async, ComponentFixture, TestBed} from '@angular/core/testing';
+import {
+  inject,
+  async,
+  ComponentFixture,
+  TestBed,
+  fakeAsync,
+  flushMicrotasks,
+  tick,
+} from '@angular/core/testing';
 import {NgModule, Component, Directive, ViewChild, ViewContainerRef} from '@angular/core';
 import {MdSnackBar, MdSnackBarModule} from './snack-bar';
 import {OverlayContainer, MdLiveAnnouncer} from '../core';
@@ -236,6 +244,21 @@ describe('MdSnackBar', () => {
       });
     });
   }));
+
+  it('should remove snackbar if another is shown while its still animating open', fakeAsync(() => {
+    snackBar.open('First snackbar');
+    viewContainerFixture.detectChanges();
+
+    snackBar.open('Second snackbar');
+    viewContainerFixture.detectChanges();
+
+    // Flush microtasks to make observables run, but don't tick such that any animations would run.
+    flushMicrotasks();
+    expect(overlayContainerElement.textContent.trim()).toBe('Second snackbar');
+
+    // Let remaining animations run.
+    tick(500);
+  }));
 });
 
 @Directive({selector: 'dir-with-view-container'})

src/lib/snack-bar/snack-bar.ts

@@ -33,8 +33,7 @@ export class MdSnackBar {
   /** A reference to the current snack bar in the view. */
   private _snackBarRef: MdSnackBarRef<any>;
 
-  constructor(private _overlay: Overlay,
-              private _live: MdLiveAnnouncer) {}
+  constructor(private _overlay: Overlay, private _live: MdLiveAnnouncer) {}
 
   /**
    * Creates and dispatches a snack bar with a custom component for the content, removing any