perf(@angular/build): memoize package-level sideEffects checks in compiler plugin

When advancedOptimizations is enabled, the compiler plugin checks each emitted and transformed JavaScript file via hasSideEffects() to determine whether pure annotations should be added during bundling.

Previously, hasSideEffects() invoked build.resolve() across the esbuild Go <-> Node.js IPC boundary for every individual file. In an application with hundreds of files loaded from node_modules (e.g. 226 files from rxjs), this resulted in hundreds of redundant IPC round-trips to evaluate the exact same package-level sideEffects configuration.

To eliminate redundant resolution calls:
- Introduce a dedicated SideEffectsResolver class and createSideEffectsResolver() factory in a separate module.
- Memoize resolved sideEffects booleans at both the package level and the individual file level.
- When an imported file resides in node_modules, extract the package directory and inspect its package.json sideEffects property once.
- If sideEffects is a boolean, memoize it for all files originating from that package.
- If sideEffects is an array of globs, string, or omitted, bypass package-level memoization and resolve via build.resolve() per file, memoizing the resolved file result to prevent duplicate calls.
- Return an async noop when advancedOptimizations is disabled to avoid overhead.
- Provide comprehensive unit tests covering package memoization, non-boolean sideEffects, scoped packages, pnpm virtual stores, and Windows/relative paths.

In benchmarks on an application with 253 JS dependency files across 6 packages, build.resolve IPC calls dropped from 253 to 6 (-97.6%) and cumulative resolve duration dropped by 99.7%.

Author: alan-agius4

packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts

@@ -37,6 +37,7 @@ import { ComponentStylesheetBundler } from './component-stylesheets';
 import { FileReferenceTracker } from './file-reference-tracker';
 import { setupJitPluginCallbacks } from './jit-plugin-callbacks';
 import { rewriteForBazel } from './rewrite-bazel-paths';
+import { createSideEffectsResolver } from './side-effects-resolver';
 import { SourceFileCache } from './source-file-cache';
 
 export interface CompilerPluginOptions {
@@ -116,6 +117,8 @@ export function createCompilerPlugin(
         cacheStore?.createCache('jstransformer'),
       );
 
+      const hasSideEffects = createSideEffectsResolver(build, pluginOptions.advancedOptimizations);
+
       // Setup defines based on the values used by the Angular compiler-cli
       build.initialOptions.define ??= {};
       build.initialOptions.define['ngI18nClosureMode'] ??= 'false';
@@ -647,22 +650,6 @@ export function createCompilerPlugin(
         void javascriptTransformer.close();
         void cacheStore?.close();
       });
-
-      /**
-       * Checks if the file has side-effects when `advancedOptimizations` is enabled.
-       */
-      async function hasSideEffects(path: string): Promise<boolean | undefined> {
-        if (!pluginOptions.advancedOptimizations) {
-          return undefined;
-        }
-
-        const { sideEffects } = await build.resolve(path, {
-          kind: 'import-statement',
-          resolveDir: build.initialOptions.absWorkingDir ?? '',
-        });
-
-        return sideEffects;
-      }
     },
   };
 }

packages/angular/build/src/tools/esbuild/angular/side-effects-resolver.ts

@@ -0,0 +1,173 @@
+/**
+ * @license
+ * Copyright Google LLC All Rights Reserved.
+ *
+ * Use of this source code is governed by an MIT-style license that can be
+ * found in the LICENSE file at https://angular.dev/license
+ */
+
+import type { PluginBuild } from 'esbuild';
+import { readFile } from 'node:fs/promises';
+import * as path from 'node:path';
+
+/**
+ * Extracts the root package directory containing package.json for a file inside node_modules.
+ * Supports standard packages (node_modules/pkg/...) and scoped packages (node_modules/@scope/pkg/...).
+ */
+export function getPackageDirectory(filePath: string): string | undefined {
+  const normalizedPath = filePath.includes('\\') ? filePath.replace(/\\/g, '/') : filePath;
+  let index = normalizedPath.lastIndexOf('/node_modules/');
+  let offset = 14;
+  if (index === -1) {
+    if (normalizedPath.startsWith('node_modules/')) {
+      index = 0;
+      offset = 13;
+    } else {
+      return undefined;
+    }
+  }
+
+  const afterNodeModules = normalizedPath.slice(index + offset);
+  const firstSlash = afterNodeModules.indexOf('/');
+  if (firstSlash === -1) {
+    return undefined;
+  }
+
+  let end = index + offset;
+  if (afterNodeModules.startsWith('@')) {
+    const secondSlash = afterNodeModules.indexOf('/', firstSlash + 1);
+    end += secondSlash === -1 ? afterNodeModules.length : secondSlash;
+  } else {
+    end += firstSlash;
+  }
+
+  return filePath.slice(0, end);
+}
+
+/**
+ * Resolves and memoizes package-level and file-level side-effects for bundling optimizations.
+ */
+export class SideEffectsResolver {
+  readonly #build: PluginBuild;
+  readonly #advancedOptimizations: boolean;
+  readonly #workingDirectory: string;
+
+  /**
+   * Memoizes package-level sideEffects values.
+   * - `true` or `false` when package.json specifies a boolean `sideEffects`.
+   * - `null` when package.json has non-boolean (e.g. array of globs, string), omitted sideEffects, or fails to read.
+   * - `Promise<boolean | null>` while package.json is being read and parsed.
+   */
+  readonly #packageSideEffectsCache = new Map<string, Promise<boolean | null> | boolean | null>();
+
+  /**
+   * Memoizes file-level sideEffects results.
+   * - `true` or `false` once resolved.
+   * - `Promise<boolean>` while esbuild resolution is in-flight.
+   */
+  readonly #fileSideEffectsCache = new Map<string, Promise<boolean> | boolean>();
+
+  constructor(build: PluginBuild, advancedOptimizations: boolean = true) {
+    this.#build = build;
+    this.#advancedOptimizations = advancedOptimizations;
+    this.#workingDirectory = build.initialOptions.absWorkingDir ?? '';
+  }
+
+  /**
+   * Determines if a file has side-effects.
+   * Returns `undefined` when `advancedOptimizations` is disabled.
+   */
+  async resolve(filePath: string): Promise<boolean | undefined> {
+    if (!this.#advancedOptimizations) {
+      return undefined;
+    }
+
+    const cachedFileSideEffects = this.#fileSideEffectsCache.get(filePath);
+    if (cachedFileSideEffects !== undefined) {
+      return cachedFileSideEffects;
+    }
+
+    const packageDir = getPackageDirectory(filePath);
+    if (packageDir !== undefined) {
+      let packageSideEffects = this.#packageSideEffectsCache.get(packageDir);
+      if (packageSideEffects === undefined) {
+        packageSideEffects = this.#resolvePackageSideEffects(packageDir);
+        this.#packageSideEffectsCache.set(packageDir, packageSideEffects);
+      }
+
+      if (packageSideEffects instanceof Promise) {
+        packageSideEffects = await packageSideEffects;
+        this.#packageSideEffectsCache.set(packageDir, packageSideEffects);
+      }
+
+      if (packageSideEffects !== null) {
+        this.#fileSideEffectsCache.set(filePath, packageSideEffects);
+
+        return packageSideEffects;
+      }
+    }
+
+    // Fallback: per-file resolution via esbuild when outside node_modules,
+    // or when the package sideEffects is non-boolean (array of globs, string, omitted).
+    const resolutionPromise = (async () => {
+      try {
+        const { sideEffects } = await this.#build.resolve(filePath, {
+          kind: 'import-statement',
+          resolveDir: this.#workingDirectory,
+        });
+
+        this.#fileSideEffectsCache.set(filePath, sideEffects);
+
+        return sideEffects;
+      } catch (error) {
+        this.#fileSideEffectsCache.delete(filePath);
+        throw error;
+      }
+    })();
+
+    this.#fileSideEffectsCache.set(filePath, resolutionPromise);
+
+    return resolutionPromise;
+  }
+
+  async #resolvePackageSideEffects(packageDir: string): Promise<boolean | null> {
+    try {
+      const packageJsonPath = path.join(packageDir, 'package.json');
+      const packageJsonContent = await readFile(packageJsonPath, 'utf-8');
+      const { sideEffects } = JSON.parse(packageJsonContent) as { sideEffects?: unknown };
+
+      return typeof sideEffects === 'boolean' ? sideEffects : null;
+    } catch {
+      return null;
+    }
+  }
+
+  /**
+   * Clears all memoized package and file-level side-effects caches.
+   */
+  clear(): void {
+    this.#packageSideEffectsCache.clear();
+    this.#fileSideEffectsCache.clear();
+  }
+}
+
+/**
+ * Creates a side-effects resolver function that determines whether a file has side-effects.
+ *
+ * @param build The esbuild PluginBuild instance.
+ * @param advancedOptimizations Whether advanced optimizations are enabled.
+ * @returns An async function accepting a file path and returning whether the file has side-effects,
+ * or `undefined` when `advancedOptimizations` is false.
+ */
+export function createSideEffectsResolver(
+  build: PluginBuild,
+  advancedOptimizations?: boolean,
+): (filePath: string) => Promise<boolean | undefined> {
+  if (!advancedOptimizations) {
+    return async () => undefined;
+  }
+
+  const resolver = new SideEffectsResolver(build, advancedOptimizations);
+
+  return (filePath: string) => resolver.resolve(filePath);
+}