refactor(@schematics/angular): remove third-party typescript copy

alan-agius4 · alan-agius4 · commit c6dd57ac70a8 · 2026-04-28T13:35:53.000+02:00
The typescript package is now smaller and the tsserver file no longer
bundles typescript but imports it directly, which makes the 3rd party
copy redundant.
diff --git a/packages/schematics/angular/BUILD.bazel b/packages/schematics/angular/BUILD.bazel
@@ -107,17 +107,8 @@ ts_project(
         ":node_modules/@angular-devkit/core",
         ":node_modules/@angular-devkit/schematics",
         ":node_modules/jsonc-parser",
+        ":node_modules/typescript",
         "//:node_modules/@types/node",
-        "//packages/schematics/angular/third_party/typescript",
-    ],
-)
-
-jasmine_test(
-    name = "no_typescript_runtime_dep_test",
-    data = [
-        "no_typescript_runtime_dep_spec.js",
-        ":angular",
-        "//:node_modules/@types/jasmine",
     ],
 )
 
@@ -139,10 +130,10 @@ ts_project(
         ":node_modules/@angular-devkit/core",
         ":node_modules/@angular-devkit/schematics",
         ":node_modules/jsonc-parser",
+        ":node_modules/typescript",
         "//:node_modules/@types/jasmine",
         "//:node_modules/@types/node",
         "//:node_modules/prettier",
-        "//packages/schematics/angular/third_party/typescript",
     ],
 )
 
@@ -173,6 +164,5 @@ npm_package(
         ":README.md",
         ":angular",
         ":license",
-        "//packages/schematics/angular/third_party/typescript",
     ],
 )
diff --git a/packages/schematics/angular/app-shell/index.ts b/packages/schematics/angular/app-shell/index.ts
@@ -15,7 +15,7 @@ import {
   schematic,
 } from '@angular-devkit/schematics';
 import { dirname, join } from 'node:path/posix';
-import ts from '../third_party/typescript';
+import ts from 'typescript';
 import {
   findNode,
   findNodes,
diff --git a/packages/schematics/angular/migrations/migrate-karma-to-vitest/karma-config-analyzer.ts b/packages/schematics/angular/migrations/migrate-karma-to-vitest/karma-config-analyzer.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 
 export interface RequireInfo {
   module: string;
diff --git a/packages/schematics/angular/module/index.ts b/packages/schematics/angular/module/index.ts
@@ -22,8 +22,8 @@ import {
   url,
 } from '@angular-devkit/schematics';
 import { join } from 'node:path/posix';
+import ts from 'typescript';
 import { Schema as ComponentOptions } from '../component/schema';
-import * as ts from '../third_party/typescript';
 import { addImportToModule, addRouteDeclarationToModule } from '../utility/ast-utils';
 import { InsertChange } from '../utility/change';
 import {
diff --git a/packages/schematics/angular/no_typescript_runtime_dep_spec.js b/packages/schematics/angular/no_typescript_runtime_dep_spec.js
diff --git a/packages/schematics/angular/package.json b/packages/schematics/angular/package.json
@@ -19,6 +19,7 @@
   "dependencies": {
     "@angular-devkit/core": "workspace:0.0.0-PLACEHOLDER",
     "@angular-devkit/schematics": "workspace:0.0.0-PLACEHOLDER",
-    "jsonc-parser": "3.3.1"
+    "jsonc-parser": "3.3.1",
+    "typescript": "6.0.3"
   }
 }
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/test-file-transformer.ts b/packages/schematics/angular/refactor/jasmine-vitest/test-file-transformer.ts
@@ -13,7 +13,7 @@
  * blank line preservation, and reporting of transformation details.
  */
 
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 import {
   transformDoneCallback,
   transformFocusedAndSkippedTests,
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-lifecycle.ts b/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-lifecycle.ts
@@ -13,7 +13,7 @@
  * operations that use the `done` callback.
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { createPropertyAccess } from '../utils/ast-helpers';
 import { addTodoComment } from '../utils/comment-helpers';
 import { RefactorContext } from '../utils/refactor-context';
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-matcher.ts b/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-matcher.ts
@@ -14,7 +14,7 @@
  * `toHaveBeenCalledOnceWith` and `arrayWithExactContents`.
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import {
   addVitestValueImport,
   createExpectCallExpression,
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-misc.ts b/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-misc.ts
@@ -13,7 +13,7 @@
  * includes logic to identify and add TODO comments for unsupported Jasmine features.
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { addVitestValueImport, createViCallExpression } from '../utils/ast-helpers';
 import { getJasmineMethodName, isJasmineCallExpression } from '../utils/ast-validation';
 import { addTodoComment } from '../utils/comment-helpers';
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy.ts b/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-spy.ts
@@ -13,7 +13,7 @@
  * and the inspection of spy calls (`spy.calls.reset`, `spy.calls.mostRecent`).
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import {
   addVitestValueImport,
   createPropertyAccess,
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-type.ts b/packages/schematics/angular/refactor/jasmine-vitest/transformers/jasmine-type.ts
@@ -13,7 +13,7 @@
  * necessary `vitest` imports are added to the file.
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { addVitestTypeImport } from '../utils/ast-helpers';
 import { RefactorContext } from '../utils/refactor-context';
 
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/ast-helpers.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/ast-helpers.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 
 export function addVitestValueImport(imports: Set<string>, importName: string): void {
   imports.add(importName);
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/ast-validation.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/ast-validation.ts
@@ -11,7 +11,7 @@
  * TypeScript AST nodes, particularly for identifying specific patterns in Jasmine tests.
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 
 /**
  * If a node is a `jasmine.method()` call, returns the method name.
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/comment-helpers.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/comment-helpers.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { TODO_NOTES, TodoCategory, TodoContextMap } from './todo-notes';
 
 // A helper type to find all `TodoCategory` keys that do not require a context.
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/comment-helpers_spec.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/comment-helpers_spec.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { addTodoComment } from './comment-helpers';
 
 describe('addTodoComment', () => {
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/refactor-context.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/refactor-context.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { RefactorReporter } from './refactor-reporter';
 
 /**
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/refactor-reporter.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/refactor-reporter.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { TodoCategory } from './todo-notes';
 
 export class RefactorReporter {
diff --git a/packages/schematics/angular/refactor/jasmine-vitest/utils/refactor-reporter_spec.ts b/packages/schematics/angular/refactor/jasmine-vitest/utils/refactor-reporter_spec.ts
@@ -7,7 +7,7 @@
  */
 
 import { logging } from '@angular-devkit/core';
-import ts from '../../../third_party/typescript';
+import ts from 'typescript';
 import { RefactorReporter } from './refactor-reporter';
 
 describe('RefactorReporter', () => {
diff --git a/packages/schematics/angular/server/index_spec.ts b/packages/schematics/angular/server/index_spec.ts
@@ -8,8 +8,8 @@
 
 import { SchematicTestRunner, UnitTestTree } from '@angular-devkit/schematics/testing';
 import { parse as parseJson } from 'jsonc-parser';
+import { CompilerOptions } from 'typescript';
 import { Schema as ApplicationOptions, Style } from '../application/schema';
-import { CompilerOptions } from '../third_party/typescript';
 import { NodeDependencyType, addPackageJsonDependency } from '../utility/dependencies';
 import { Builders } from '../utility/workspace-models';
 import { Schema as WorkspaceOptions } from '../workspace/schema';
diff --git a/packages/schematics/angular/service-worker/index.ts b/packages/schematics/angular/service-worker/index.ts
@@ -20,7 +20,7 @@ import {
   url,
 } from '@angular-devkit/schematics';
 import { join } from 'node:path/posix';
-import ts from '../third_party/typescript';
+import ts from 'typescript';
 import { addDependency, addRootProvider, writeWorkspace } from '../utility';
 import { addSymbolToNgModuleMetadata, insertImport } from '../utility/ast-utils';
 import { applyToUpdateRecorder } from '../utility/change';
diff --git a/packages/schematics/angular/third_party/typescript/BUILD.bazel b/packages/schematics/angular/third_party/typescript/BUILD.bazel
diff --git a/packages/schematics/angular/third_party/typescript/README.md b/packages/schematics/angular/third_party/typescript/README.md
diff --git a/packages/schematics/angular/third_party/typescript/index.d.ts b/packages/schematics/angular/third_party/typescript/index.d.ts
diff --git a/packages/schematics/angular/utility/add-declaration-to-ng-module.ts b/packages/schematics/angular/utility/add-declaration-to-ng-module.ts
@@ -7,7 +7,7 @@
  */
 
 import { Rule, Tree, strings } from '@angular-devkit/schematics';
-import * as ts from '../third_party/typescript';
+import ts from 'typescript';
 import { addDeclarationToModule, addSymbolToNgModuleMetadata } from './ast-utils';
 import { InsertChange } from './change';
 import { buildRelativePath } from './find-module';
diff --git a/packages/schematics/angular/utility/ast-utils.ts b/packages/schematics/angular/utility/ast-utils.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.dev/license
  */
 
-import * as ts from '../third_party/typescript';
+import ts from 'typescript';
 import { Change, InsertChange, NoopChange } from './change';
 import { getEOL } from './eol';
 
diff --git a/packages/schematics/angular/utility/ast-utils_spec.ts b/packages/schematics/angular/utility/ast-utils_spec.ts
@@ -7,7 +7,7 @@
  */
 
 import { HostTree } from '@angular-devkit/schematics';
-import * as ts from '../third_party/typescript';
+import ts from 'typescript';
 import { Change, InsertChange } from '../utility/change';
 import {
   addDeclarationToModule,
diff --git a/packages/schematics/angular/utility/ng-ast-utils.ts b/packages/schematics/angular/utility/ng-ast-utils.ts
@@ -8,7 +8,7 @@
 
 import { SchematicsException, Tree } from '@angular-devkit/schematics';
 import { dirname, join } from 'node:path/posix';
-import * as ts from '../third_party/typescript';
+import ts from 'typescript';
 import { findNode, getSourceNodes } from '../utility/ast-utils';
 import { findBootstrapApplicationCall } from './standalone/util';
 
diff --git a/packages/schematics/angular/utility/standalone/app_component.ts b/packages/schematics/angular/utility/standalone/app_component.ts
@@ -7,7 +7,7 @@
  */
 
 import { SchematicsException, Tree } from '@angular-devkit/schematics';
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 import { getDecoratorMetadata, getMetadataField } from '../ast-utils';
 import { findBootstrapModuleCall, getAppModulePath } from '../ng-ast-utils';
 import { findBootstrapApplicationCall, getSourceFile } from './util';
diff --git a/packages/schematics/angular/utility/standalone/app_config.ts b/packages/schematics/angular/utility/standalone/app_config.ts
@@ -8,7 +8,7 @@
 
 import { Tree } from '@angular-devkit/schematics';
 import { dirname, join } from 'node:path';
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 import { getSourceFile } from './util';
 
 /** App config that was resolved to its source node. */
diff --git a/packages/schematics/angular/utility/standalone/code_block.ts b/packages/schematics/angular/utility/standalone/code_block.ts
@@ -7,7 +7,7 @@
  */
 
 import { Rule, Tree } from '@angular-devkit/schematics';
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 import { hasTopLevelIdentifier, insertImport } from '../ast-utils';
 import { applyToUpdateRecorder } from '../change';
 
diff --git a/packages/schematics/angular/utility/standalone/rules.ts b/packages/schematics/angular/utility/standalone/rules.ts
@@ -7,7 +7,7 @@
  */
 
 import { Rule, SchematicsException, Tree, chain } from '@angular-devkit/schematics';
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 import { addSymbolToNgModuleMetadata, insertAfterLastOccurrence } from '../ast-utils';
 import { InsertChange } from '../change';
 import { getAppModulePath, isStandaloneApp } from '../ng-ast-utils';
diff --git a/packages/schematics/angular/utility/standalone/util.ts b/packages/schematics/angular/utility/standalone/util.ts
@@ -8,7 +8,7 @@
 
 import { SchematicsException, Tree } from '@angular-devkit/schematics';
 import { join } from 'node:path/posix';
-import ts from '../../third_party/typescript';
+import ts from 'typescript';
 import { Change, applyToUpdateRecorder } from '../change';
 import { targetBuildNotFoundError } from '../project-targets';
 import { getWorkspace } from '../workspace';
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml

Original file line number	Diff line number	Diff line change
`@@ -19,6 +19,7 @@`
`19`	`19`	`"dependencies": {`
`20`	`20`	`"@angular-devkit/core": "workspace:0.0.0-PLACEHOLDER",`
`21`	`21`	`"@angular-devkit/schematics": "workspace:0.0.0-PLACEHOLDER",`
`22`		`- "jsonc-parser": "3.3.1"`
	`22`	`+ "jsonc-parser": "3.3.1",`
	`23`	`+ "typescript": "6.0.3"`
`23`	`24`	`}`
`24`	`25`	`}`