ci: upgrade to Sauce Connect 5 to fix SC4 deprecation

Author: alan-agius4

.github/workflows/ci.yml

@@ -226,25 +226,26 @@ jobs:
         uses: angular/dev-infra/github-actions/bazel/configure-remote@ba726e7bca0b08b125ccc6f93c233749e1213c17
         with:
           google_credential: ${{ secrets.RBE_TRUSTED_BUILDS_USER }}
+      - name: Start Sauce Connect
+        uses: saucelabs/sauce-connect-action@cb88b508c6f9ff4d84490093733315dbd55de022 # v3
+        timeout-minutes: 10
+        with:
+          username: ${{ vars.SAUCE_USERNAME }}
+          accessKey: ${{ secrets.SAUCE_ACCESS_KEY }}
+          region: us-west-1
+          tunnelName: ${{ env.SAUCE_TUNNEL_IDENTIFIER }}
+          proxyLocalhost: allow
+          # By default we disable SSL bumping for all requests. This is because SSL bumping is not needed
+          # for our test setup and in order to perform the SSL bumping, Saucelabs intercepts all HTTP
+          # requests in the tunnel VM and modifies them. This can cause flakiness as it makes all requests
+          # dependent on the SSL bumping middleware.
+          # See: https://wiki.saucelabs.com/display/DOCS/Troubleshooting+Sauce+Connect#TroubleshootingSauceConnect-DisablingSSLBumping
+          tlsPassthroughDomains: all
       - name: Run E2E Browser tests
         env:
           SAUCE_USERNAME: ${{ vars.SAUCE_USERNAME }}
           SAUCE_ACCESS_KEY: ${{ secrets.SAUCE_ACCESS_KEY }}
-          SAUCE_LOG_FILE: /tmp/angular/sauce-connect.log
-          SAUCE_READY_FILE: /tmp/angular/sauce-connect-ready-file.lock
-          SAUCE_PID_FILE: /tmp/angular/sauce-connect-pid-file.lock
-          SAUCE_TUNNEL_IDENTIFIER: 'angular-${{ github.run_number }}'
-          SAUCE_READY_FILE_TIMEOUT: 120
-        run: |
-          ./scripts/saucelabs/start-tunnel.sh &
-          ./scripts/saucelabs/wait-for-tunnel.sh
-          pnpm bazel test --config=saucelabs //tests:e2e.saucelabs
-          ./scripts/saucelabs/stop-tunnel.sh
-      - uses: actions/upload-artifact@b7c566a772e6b6bfb58ed0dc250532a479d7789f # v6.0.0
-        if: ${{ failure() }}
-        with:
-          name: sauce-connect-log
-          path: ${{ env.SAUCE_CONNECT_DIR_IN_HOST }}/sauce-connect.log
+        run: pnpm bazel test --config=saucelabs //tests:e2e.saucelabs
 
   publish-snapshots:
     needs: build

scripts/saucelabs/start-tunnel.sh

@@ -5,69 +5,67 @@
 
 const { SpecReporter, StacktraceOption } = require('jasmine-spec-reporter');
 
-const tunnelIdentifier = process.env['SAUCE_TUNNEL_IDENTIFIER'];
+const tunnelName = process.env['SAUCE_TUNNEL_IDENTIFIER'];
+
+const capabilities = [
+  {
+    browserName: 'chrome',
+    version: '132',
+    platform: 'Windows 11',
+  },
+  {
+    browserName: 'chrome',
+    version: '131',
+    platform: 'Windows 11',
+  },
+  {
+    browserName: 'firefox',
+    version: '134',
+    platform: 'Windows 11',
+  },
+  {
+    browserName: 'firefox',
+    version: '128', // Latest Firefox ESR version as of Jan 2025
+    platform: 'Windows 11',
+  },
+  {
+    browserName: 'safari',
+    platform: 'macOS 13',
+    version: '17',
+  },
+  {
+    browserName: 'safari',
+    platform: 'macOS 12',
+    version: '16',
+  },
+  {
+    browserName: 'MicrosoftEdge',
+    platform: 'Windows 11',
+    version: '132',
+  },
+  {
+    browserName: 'MicrosoftEdge',
+    platform: 'Windows 11',
+    version: '131',
+  },
+];
 
 /**
  * @type { import("protractor").Config }
  */
 exports.config = {
   sauceUser: process.env['SAUCE_USERNAME'],
   sauceKey: process.env['SAUCE_ACCESS_KEY'],
+  sauceRegion: 'us',
 
   allScriptsTimeout: 11000,
   specs: ['./src/**/*.e2e-spec.ts'],
 
   // NOTE: https://saucelabs.com/products/platform-configurator can be used to determine configuration values
-  multiCapabilities: [
-    {
-      browserName: 'chrome',
-      version: '132',
-      platform: 'Windows 11',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'chrome',
-      version: '131',
-      platform: 'Windows 11',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'firefox',
-      version: '134',
-      platform: 'Windows 11',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'firefox',
-      version: '128', // Latest Firefox ESR version as of Jan 2025
-      platform: 'Windows 11',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'safari',
-      platform: 'macOS 13',
-      version: '17',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'safari',
-      platform: 'macOS 12',
-      version: '16',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'MicrosoftEdge',
-      platform: 'Windows 11',
-      version: '132',
-      tunnelIdentifier,
-    },
-    {
-      browserName: 'MicrosoftEdge',
-      platform: 'Windows 11',
-      version: '131',
-      tunnelIdentifier,
-    },
-  ],
+  multiCapabilities: capabilities.map((caps) => ({
+    ...caps,
+    tunnelName,
+  })),
 
   // Only allow one session at a time to prevent over saturation of Saucelabs sessions.
   maxSessions: 1,