Skip to content

Commit 1f962b2

Browse files
committed
fixup! perf(@angular/build): overlap library asset resolution with bundling and typechecking
1 parent 31619b8 commit 1f962b2

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

‎packages/angular/build/src/builders/library/pipeline/build-action.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,10 @@ export async function buildAction(actionContext: BuildActionContext): Promise<Ex
129129
return result;
130130
}
131131

132+
result.addWarnings(bundleOutput.warnings);
132133
if (result.hasErrors) {
133134
return result;
134135
}
135-
result.addWarnings(bundleOutput.warnings);
136136

137137
filesToEmit.push(...bundleOutput.filesToEmit);
138138
buildState.recordBundleOutput(bundleOutput.bundleResults);

‎packages/angular/build/src/builders/library/tests/behavior/build_spec.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,7 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
210210
);
211211
});
212212

213-
it('should log failure on build error without secondary bundler warnings', async () => {
213+
it('should log failure on build error with bundler warnings', async () => {
214214
await harness.writeFile(
215215
'projects/lib/src/public-api.ts',
216216
`
@@ -239,7 +239,7 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
239239
),
240240
}),
241241
);
242-
expect(logs).not.toContain(jasmine.objectContaining({ level: 'warn' }));
242+
expect(logs).toContain(jasmine.objectContaining({ level: 'warn' }));
243243
expect(logs).not.toContain(
244244
jasmine.objectContaining({
245245
message: jasmine.stringMatching(/Output location:/),

0 commit comments

Comments
 (0)