perf(@angular/build): overlap library asset resolution with bundling and typechecking

- Run `buildState.collectAssets(options, modifiedFiles)` inside `Promise.all`
  alongside `bundleEntryPoints` and `diagnosePromise` so filesystem asset
  resolution overlaps with Rolldown bundling and worker-thread typecheck
  diagnostics.
- Delete stale files with `deleteFilesFromDisk` before emitting updated files
  with `emitFilesToDisk` so case-only renames on case-insensitive filesystems
  do not remove newly emitted files.
- Check `result.hasErrors` before adding `bundleOutput.warnings` so secondary
  bundler warnings are not logged when compilation fails.
- Include `options.packageJsonPath` in the disallowed dependency error message
  in `verifyAllowedDependencies`.

Author: alan-agius4

packages/angular/build/src/builders/library/pipeline/build-action.ts

@@ -71,6 +71,7 @@ export async function buildAction(actionContext: BuildActionContext): Promise<Ex
       return result;
     }
 
+    let collectedAssets = actionContext.collectedAssets;
     const filesToEmit: OutputFile[] = [];
 
     if (shouldCompileEntryPoints) {
@@ -102,7 +103,7 @@ export async function buildAction(actionContext: BuildActionContext): Promise<Ex
       const itemsToBundle = collectEntryPointsToBundle(options, buildState);
       let bundleOutput: BundleEntryPointsOutput;
       try {
-        [bundleOutput] = await Promise.all([
+        [bundleOutput, , collectedAssets] = await Promise.all([
           bundleEntryPoints(
             itemsToBundle,
             esmFiles,
@@ -115,6 +116,7 @@ export async function buildAction(actionContext: BuildActionContext): Promise<Ex
             buildState.previousBundleResults,
           ),
           diagnosePromise,
+          collectedAssets ?? buildState.collectAssets(options, modifiedFiles),
         ]);
       } catch (error) {
         assertIsError(error);
@@ -151,19 +153,17 @@ export async function buildAction(actionContext: BuildActionContext): Promise<Ex
       filesToEmit.push(...manifestFiles);
     }
 
-    const collectedAssets =
-      actionContext.collectedAssets ?? (await buildState.collectAssets(options, modifiedFiles));
+    collectedAssets ??= await buildState.collectAssets(options, modifiedFiles);
     filesToEmit.push(...collectedAssets.filesToEmit);
 
-    await emitFilesToDisk(filesToEmit, (file) => path.posix.join(options.outputPath, file.path));
-
     const filesToDelete = buildState.recordEmittedOutputs(collectedAssets, manifestFiles);
-
     if (filesToDelete.size) {
       await deleteFilesFromDisk(
         Array.from(filesToDelete, (file) => path.posix.join(options.outputPath, file)),
       );
     }
+
+    await emitFilesToDisk(filesToEmit, (file) => path.posix.join(options.outputPath, file.path));
   } catch (error) {
     assertIsError(error);
     result.addError(error.message);
@@ -184,7 +184,7 @@ function verifyAllowedDependencies(
   options: NormalizedLibraryOptions,
   result: ExecutionResult,
 ): boolean {
-  const { packageJson, allowedNonPeerDependencies } = options;
+  const { packageJson, packageJsonPath, allowedNonPeerDependencies } = options;
   const dependencies = {
     ...(packageJson.dependencies ?? {}),
     ...(packageJson.optionalDependencies ?? {}),
@@ -195,7 +195,7 @@ function verifyAllowedDependencies(
     if (!allowedNonPeerDependencies.some((regex) => regex.test(dep))) {
       result.addError(
         `Dependency '${dep}' must be explicitly allowed using the 'allowedNonPeerDependencies' option, ` +
-          `or moved to 'peerDependencies' in 'package.json'.`,
+          `or moved to 'peerDependencies' in '${packageJsonPath}'.`,
       );
       isValid = false;
     }

packages/angular/build/src/builders/library/tests/behavior/build_spec.ts

@@ -92,7 +92,7 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
 
       const { result, logs } = await harness.executeOnce();
       expect(result?.success).toBeTrue();
-      expect(logs.some((l) => l.level === 'warn')).toBeFalse();
+      expect(logs).not.toContain(jasmine.objectContaining({ level: 'warn' }));
     });
 
     it('should preserve JSDoc comments in .d.ts and annotation comments in .mjs bundles', async () => {
@@ -210,10 +210,13 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
       );
     });
 
-    it('should log failure on build error', async () => {
+    it('should log failure on build error with bundler warnings', async () => {
       await harness.writeFile(
         'projects/lib/src/public-api.ts',
-        `export const title: number = 'invalid type';`,
+        `
+        export const title: number = 'invalid type';
+        export function runDynamic(code: string) { return eval(code); }
+        `,
       );
 
       harness.useTarget('build', {
@@ -236,6 +239,7 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
           ),
         }),
       );
+      expect(logs).toContain(jasmine.objectContaining({ level: 'warn' }));
       expect(logs).not.toContain(
         jasmine.objectContaining({
           message: jasmine.stringMatching(/Output location:/),

packages/angular/build/src/builders/library/tests/options/allowed-non-peer-dependencies_spec.ts

@@ -29,7 +29,9 @@ describeLibraryBuilder(executeLibraryBuilder, LIBRARY_BUILDER_INFO, (harness) =>
       expect(logs).toContain(
         jasmine.objectContaining({
           level: 'error',
-          message: jasmine.stringMatching(/lodash-es.*allowedNonPeerDependencies/),
+          message: jasmine.stringMatching(
+            /lodash-es.*allowedNonPeerDependencies.*projects\/lib\/package\.json/,
+          ),
         }),
       );
     });