-
Notifications
You must be signed in to change notification settings - Fork 84
Add deeplink-guide.md #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @claraf3, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new documentation guide that provides a comprehensive explanation of deep link handling within the Navigation 3 framework. It covers the essential steps for converting incoming deep link intents into navigation keys and outlines strategies for managing the back stack to ensure a consistent and intuitive user navigation experience, particularly when dealing with different task launch scenarios. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a comprehensive guide for handling deep links. The document is well-structured and covers both basic parsing and advanced back stack management. I've made a few suggestions to improve consistency and fix a broken link in the documentation.
docs/deeplink-guide.md
Outdated
| } | ||
| ``` | ||
|
|
||
| For more details, refer to the [Basic Deep Link Recipe](../app/src/main/java/com/example/nav3recipes/deeplink/basic/BDEEPLINKREADME.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There seems to be a typo in the filename for the deep link recipe. The link points to BDEEPLINKREADME.md, but based on the project structure, it should likely be README.md. This results in a broken link.
| For more details, refer to the [Basic Deep Link Recipe](../app/src/main/java/com/example/nav3recipes/deeplink/basic/BDEEPLINKREADME.md) | |
| For more details, refer to the [Basic Deep Link Recipe](../app/src/main/java/com/example/nav3recipes/deeplink/basic/README.md) |
eb35908 to
7d49599
Compare
Guide that summarizes the content for basic and advanced deep link recipe
7d49599 to
da31909
Compare
|
Merged this into advanced deeplink pr |
Guide that summarizes the content for basic and advanced deep link recipe