iio: imu: inv_icm45600: Initializes inv_icm45600_buffer_postdisable() sleep

rbuisson-invn · jic23 · commit d16d1c255324 · 2025-11-09T16:52:52.000Z
The sleep variable in inv_icm45600_buffer_postdisable() could be used without being assigned in case of error. It must be initialized to 0 by default. Fixes: 06674a7 ("iio: imu: inv_icm45600: add buffer support in iio devices") Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Closes: https://lore.kernel.org/linux-iio/aPi6Xw-ZoUkW76zR@stanley.mountain/ Signed-off-by: Remi Buisson <remi.buisson@tdk.com> Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com> Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
diff --git a/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c b/drivers/iio/imu/inv_icm45600/inv_icm45600_buffer.c
@@ -370,6 +370,7 @@ static int inv_icm45600_buffer_postdisable(struct iio_dev *indio_dev)
 		return -EINVAL;
 	}
 
+	sleep = 0;
 	scoped_guard(mutex, &st->lock)
 		ret = _inv_icm45600_buffer_postdisable(st, sensor, watermark, &sleep);
 

Original file line number	Diff line number	Diff line change
`@@ -370,6 +370,7 @@ static int inv_icm45600_buffer_postdisable(struct iio_dev *indio_dev)`
`370`	`370`	`return -EINVAL;`
`371`	`371`	`}`
`372`	`372`
	`373`	`+ sleep = 0;`
`373`	`374`	`scoped_guard(mutex, &st->lock)`
`374`	`375`	`ret = _inv_icm45600_buffer_postdisable(st, sensor, watermark, &sleep);`
`375`	`376`