Skip to content

Commit c1b5b83

Browse files
author
Alex McCool
authored
removing the ILoggerFactory builder as it doesnt fit the model (#36)
1 parent 30c2ca4 commit c1b5b83

File tree

2 files changed

+39
-47
lines changed

2 files changed

+39
-47
lines changed

src/ElasticLogger.Test/ElasticsearchLoggerFilterTests.cs

Lines changed: 39 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -257,9 +257,26 @@ public async Task Write_Trace_log_with_no_config_positiveTest()
257257
private async Task LevelTesterPositive(string source, LogLevel logLevel)
258258
{
259259
await _fixture.ReadyAsync();
260+
var config = new ConfigurationBuilder()
261+
.Add(new MemoryConfigurationSource
262+
{
263+
InitialData = new Dictionary<string, string>
264+
{
265+
{"Logging:LogLevel:Default", logLevel.ToString() }
266+
}
267+
})
268+
.Build();
269+
270+
//di for the logger
271+
ServiceCollection services = new ServiceCollection();
272+
services.AddLogging(l =>
273+
{
274+
l.AddConfiguration(config.GetSection("Logging"));
275+
l.AddElasticSearch(o => o.ElasticsearchEndpoint = _fixture.Endpoint);
276+
});
277+
var prov = services.BuildServiceProvider();
260278

261-
ILoggerFactory loggerFactory = new LoggerFactory()
262-
.AddElasticSearch(_fixture.Endpoint);
279+
var loggerFactory = prov.GetService<ILoggerFactory>();
263280

264281
var logger = loggerFactory.CreateLogger(source);
265282

@@ -290,8 +307,26 @@ private async Task LevelTesterNegative(string source, LogLevel logLevel)
290307
{
291308
await _fixture.ReadyAsync();
292309

293-
ILoggerFactory loggerFactory = new LoggerFactory()
294-
.AddElasticSearch(_fixture.Endpoint);
310+
var config = new ConfigurationBuilder()
311+
.Add(new MemoryConfigurationSource
312+
{
313+
InitialData = new Dictionary<string, string>
314+
{
315+
{"Logging:LogLevel:Default", logLevel.ToString() }
316+
}
317+
})
318+
.Build();
319+
320+
//di for the logger
321+
ServiceCollection services = new ServiceCollection();
322+
services.AddLogging(l =>
323+
{
324+
l.AddConfiguration(config.GetSection("Logging"));
325+
l.AddElasticSearch(o => o.ElasticsearchEndpoint = _fixture.Endpoint);
326+
});
327+
var prov = services.BuildServiceProvider();
328+
329+
var loggerFactory = prov.GetService<ILoggerFactory>();
295330

296331
var logger = loggerFactory.CreateLogger(source);
297332

src/ElasticSearch.Extensions.Logging/ElasticsearchLoggingFactoryExtensions.cs

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)