fix: enable LocalNet dispensing after 30000 rounds (#226)

* fix: enable LocalNet dispensing after 30000 rounds

Author: neilcampbell

src/algokit_utils/accounts/kmd_account_manager.py

@@ -69,7 +69,18 @@ def get_wallet_account(
         :param sender: Optional sender address to use this signer for (aka a rekeyed account)
         :return: The signing account or None if no matching wallet or account was found
         """
+        return self._find_wallet_account(
+            wallet_name,
+            predicate,
+            sender,
+        )
 
+    def _find_wallet_account(
+        self,
+        wallet_name: str,
+        predicate_or_address: Callable[[dict[str, Any]], bool] | str | None = None,
+        sender: str | None = None,
+    ) -> KmdAccount | None:
         kmd_client = self.kmd()
         wallets = kmd_client.list_wallets()
         wallet = next((w for w in wallets if w["name"] == wallet_name), None)
@@ -78,17 +89,21 @@ def get_wallet_account(
 
         wallet_id = wallet["id"]
         wallet_handle = kmd_client.init_wallet_handle(wallet_id, "")
-        addresses = kmd_client.list_keys(wallet_handle)
 
         matched_address = None
-        if predicate:
-            for address in addresses:
-                account_info = self._client_manager.algod.account_info(address)
-                if predicate(cast(dict[str, Any], account_info)):
-                    matched_address = address
-                    break
+        if isinstance(predicate_or_address, str):
+            matched_address = predicate_or_address
         else:
-            matched_address = next(iter(addresses), None)
+            addresses = kmd_client.list_keys(wallet_handle)
+            if addresses:
+                if callable(predicate_or_address):
+                    for address in addresses:
+                        account_info = self._client_manager.algod.account_info(address)
+                        if predicate_or_address(cast(dict[str, Any], account_info)):
+                            matched_address = address
+                            break
+                else:
+                    matched_address = addresses[0]
 
         if not matched_address:
             return None
@@ -149,11 +164,15 @@ def get_localnet_dispenser_account(self) -> KmdAccount:
         if not self._client_manager.is_localnet():
             raise Exception("Can't get LocalNet dispenser account from non LocalNet network")
 
-        dispenser = self.get_wallet_account(
-            "unencrypted-default-wallet",
-            lambda a: a["status"] != "Offline" and a["amount"] > 1_000_000_000,  # noqa: PLR2004
-        )
-        if not dispenser:
-            raise Exception("Error retrieving LocalNet dispenser account; couldn't find the default account in KMD")
+        genesis_response = cast(dict[str, Any], self._client_manager.algod.genesis())
+        dispenser_addresses = [cast(str, a["addr"]) for a in genesis_response["alloc"] if a.get("comment") == "Wallet1"]
+
+        if dispenser_addresses:
+            dispenser = self._find_wallet_account(
+                "unencrypted-default-wallet",
+                dispenser_addresses[0],
+            )
+            if dispenser:
+                return dispenser
 
-        return dispenser
+        raise Exception("Error retrieving LocalNet dispenser account; couldn't find the default account in KMD")

tests/transactions/test_transaction_composer.py

@@ -13,7 +13,6 @@
     PaymentTxn,
 )
 
-from algokit_utils._legacy_v2.account import get_account
 from algokit_utils.algorand import AlgorandClient
 from algokit_utils.models.account import MultisigMetadata, SigningAccount
 from algokit_utils.models.amount import AlgoAmount
@@ -27,7 +26,6 @@
     SendAtomicTransactionComposerResults,
     TransactionComposer,
 )
-from legacy_v2_tests.conftest import get_unique_name
 
 if TYPE_CHECKING:
     from algokit_utils.models.transaction import Arc2TransactionNote
@@ -59,8 +57,14 @@ def funded_account(algorand: AlgorandClient) -> SigningAccount:
 
 @pytest.fixture
 def funded_secondary_account(algorand: AlgorandClient) -> SigningAccount:
-    secondary_name = get_unique_name()
-    return get_account(algorand.client.algod, secondary_name)
+    private_key, _ = algosdk.account.generate_account()
+    address = str(algosdk.account.address_from_private_key(private_key))
+    dispenser = algorand.account.localnet_dispenser()
+    new_account = SigningAccount(private_key=private_key, address=address)
+    algorand.account.ensure_funded(
+        new_account, dispenser, AlgoAmount.from_algo(100), min_funding_increment=AlgoAmount.from_algo(1)
+    )
+    return new_account
 
 
 def test_add_transaction(algorand: AlgorandClient, funded_account: SigningAccount) -> None: