chore: rm MsgpackDecodingError

Author: joe-p

crates/algokit_transact/src/error.rs

@@ -18,9 +18,6 @@ pub enum AlgoKitTransactError {
     #[snafu(display("Error occurred during msgpack encoding: {source}"))]
     MsgpackEncodingError { source: rmpv::encode::Error },
 
-    #[snafu(display("Error occurred during msgpack decoding: {source}"))]
-    MsgpackDecodingError { source: rmpv::decode::Error },
-
     #[snafu(display("Error occurred during decoding at path {path}: {source}"))]
     DecodingError {
         path: String,
@@ -52,12 +49,6 @@ impl From<rmpv::encode::Error> for AlgoKitTransactError {
     }
 }
 
-impl From<rmpv::decode::Error> for AlgoKitTransactError {
-    fn from(source: rmpv::decode::Error) -> Self {
-        AlgoKitTransactError::MsgpackDecodingError { source }
-    }
-}
-
 impl From<serde_path_to_error::Error<rmp_serde::decode::Error>> for AlgoKitTransactError {
     fn from(err: serde_path_to_error::Error<rmp_serde::decode::Error>) -> Self {
         AlgoKitTransactError::DecodingError {

crates/algokit_transact/src/traits.rs

@@ -39,12 +39,14 @@ pub trait AlgorandMsgpack: Serialize + for<'de> Deserialize<'de> {
         self.serialize(&mut temp_serializer)?;
 
         // Deserialize into a Value and sort recursively
-        let value = rmpv::decode::read_value(&mut temp_buf.as_slice())?;
+        let value = rmpv::decode::read_value(&mut temp_buf.as_slice())
+            .expect("value that was just serialized should deserialize");
         let sorted_value = sort_msgpack_value(value)?;
 
         // Serialize the sorted value
         let mut final_buf = Vec::new();
-        rmpv::encode::write_value(&mut final_buf, &sorted_value)?;
+        rmpv::encode::write_value(&mut final_buf, &sorted_value)
+            .expect("value that was just sorted should serialize");
 
         Ok(final_buf)
     }

crates/algokit_transact_ffi/src/lib.rs

@@ -49,11 +49,6 @@ impl From<algokit_transact::AlgoKitTransactError> for AlgoKitTransactError {
                     message: e.to_string(),
                 }
             }
-            algokit_transact::AlgoKitTransactError::MsgpackDecodingError { .. } => {
-                AlgoKitTransactError::DecodingError {
-                    message: e.to_string(),
-                }
-            }
             algokit_transact::AlgoKitTransactError::MsgpackEncodingError { .. } => {
                 AlgoKitTransactError::EncodingError {
                     message: e.to_string(),