Merge pull request #353 from algenty:20220606_clean_code

debug = off

Author: algenty

README.md

@@ -58,12 +58,15 @@ Special thanks to
 
 
 # Changelog
-## [[1.0.0d (Last build 2022-05-07)]](./built/)
+## [[1.0.0d (Last build 2022-06-06)]](./built/)
 
 ### Known issues
   - Shared cross on grafana 8.x (minor)
   - Flow animation on arrows (minor)
+  - External image from diagrams.net not displayed (minor)
 ### Added
+  - Convert sync method to async : render graph before update states (speed x2) 
+  - clean dirty code
   - Support last version of grafana (8.5.x)
   - New initialization engine for drawio libs
   - New draw.io libs (17.x 2022-04-23)

built/agenty-flowcharting-panel-1.0.0d.220601518-SNAPSHOT.zip renamed to built/agenty-flowcharting-panel-1.0.0d.220606199-SNAPSHOT.zip

@@ -6,7 +6,7 @@ import { GFEvents } from 'flowcharting_base';
 import { GFDrawio } from 'drawio_base';
 
 // Debug
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };
@@ -140,7 +140,7 @@ export class Flowchart {
       }
       this.data.csv = value;
     }
-      this.change();
+    this.change();
   }
   get source() {
     return this.data.type === 'csv' ? this.data.csv : this.data.xml;
@@ -152,7 +152,7 @@ export class Flowchart {
       return;
     }
     this.data.download = value;
-      this.change();
+    this.change();
   }
   get download() {
     return this.data.download;
@@ -371,8 +371,8 @@ export class Flowchart {
   }
 
   init_stateHandler(): this {
-    if(this.stateHandler) {
-      this.stateHandler.free()
+    if (this.stateHandler) {
+      this.stateHandler.free();
     }
     if (this.xgraph) {
       this.stateHandler = new StateHandler(this.$gf, this.xgraph);
@@ -701,16 +701,16 @@ export class Flowchart {
         }
       }
     } else {
-      if(!this.source || this.source.length === 0) {
+      if (!this.source || this.source.length === 0) {
         content = await GFDrawio.getTemplate(this.type);
-        if(this.type === 'xml'){
+        if (this.type === 'xml') {
           this.data.xml = content;
-        };
-        if(this.type === 'csv'){
+        }
+        if (this.type === 'csv') {
           this.data.csv = content;
-        };
+        }
       }
-      if(GFDrawio.isEncoded(content)) {
+      if (GFDrawio.isEncoded(content)) {
         content = GFDrawio.decode(content);
       }
       content = $GF.resolveVars(this.source);
@@ -763,7 +763,6 @@ export class Flowchart {
     return this;
   }
 
-
   minify() {
     this.data.xml = $GF.utils.minify(this.data.xml);
   }

src/flowchart_class.ts

@@ -14,7 +14,7 @@ import { defaults as _defaults, cloneDeep as _cloneDeep } from 'lodash';
 import { GFDrawio } from 'drawio_base';
 
 // Debug
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };

src/flowchart_ctrl.ts

@@ -7,8 +7,10 @@ type Uid = String;
 type ConnectedChild = Map<Uid, CallableFunction>;
 
 // Debug
-const DEBUG=false;
-const _log = (...args: any) => {DEBUG && console.log(...args)}
+const DEBUG = false;
+const _log = (...args: any) => {
+  DEBUG && console.log(...args);
+};
 
 export class GFEvents<Signals> {
   private _declaredSignals: Signals[] = [];
@@ -18,7 +20,10 @@ export class GFEvents<Signals> {
     // Nothing to do
   }
 
-  static create<Signals>(signalName?: Readonly<Signals> | Readonly<Signals[]>, owner?: { uid: string }): GFEvents<Signals> {
+  static create<Signals>(
+    signalName?: Readonly<Signals> | Readonly<Signals[]>,
+    owner?: { uid: string }
+  ): GFEvents<Signals> {
     const event: GFEvents<Signals> = new GFEvents();
     if (signalName) {
       event.declare(signalName);
@@ -97,9 +102,9 @@ export class GFEvents<Signals> {
     }
   }
 
-  emit(signalName: Signals, objToEmit?: unknown, from?: CallableSignalChild ) {
+  emit(signalName: Signals, objToEmit?: unknown, from?: CallableSignalChild) {
     //, from?: { uid: string }
-    _log('📨', `Emit signal [${signalName}]${from ? ' from [' + from.uid + ']': ''}`);
+    _log('📨', `Emit signal [${signalName}]${from ? ' from [' + from.uid + ']' : ''}`);
     const _childFn = this._getCallableFunc(signalName);
     return Promise.all(
       _childFn.map(async (fn) => {

src/flowcharting_base.ts

@@ -9,7 +9,7 @@ import { MetricHandler } from 'metric_handler';
 const safeEval = require('safe-eval');
 
 // Debug
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };

src/globals_class.ts

@@ -9,7 +9,7 @@ import { GFEvents } from 'flowcharting_base';
 import { GFDrawio } from 'drawio_base';
 
 // Debug
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };

src/graph_class.ts

@@ -20,7 +20,7 @@ export interface MapDataCommonProp {
 }
 
 // Debug
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };

src/mapping_class.ts

@@ -18,7 +18,7 @@ import {
 import { GFEvents } from 'flowcharting_base';
 
 // Debug
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };

src/rule_class.ts

@@ -10,7 +10,7 @@ import { GFEvents } from 'flowcharting_base';
 const stateSignalsArray = ['state_initialized', 'state_updated', 'state_freed'] as const;
 type stateSignals = typeof stateSignalsArray[number];
 
-const DEBUG = true;
+const DEBUG = false;
 const _log = (...args: any) => {
   DEBUG && console.log(...args);
 };