security: Enhance security model with dangerous pattern validation #20
+867
−126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
alexei-led
commented
Nov 25, 2025
alexei-led
commented
- Add dangerous option validation for Unix commands (awk, find, sed, xargs, curl, wget, rm, chmod, chown)
- Block awk system() and shell piping, find -exec/-delete, xargs entirely, sed /e commands
- Block curl/wget POST requests to prevent data exfiltration
- Add Docker environment detection and security warnings at startup
- Warn when running in permissive mode or outside Docker
- Enhance docker-compose with read_only, no-new-privileges, cap_drop ALL
- Fix README documentation (previously incorrectly stated shell=True)
- Document Unix command injection prevention in README
- Add dangerous option validation for Unix commands (awk, find, sed, xargs, curl, wget, rm, chmod, chown) - Block awk system() and shell piping, find -exec/-delete, xargs entirely, sed /e commands - Block curl/wget POST requests to prevent data exfiltration - Add Docker environment detection and security warnings at startup - Warn when running in permissive mode or outside Docker - Enhance docker-compose with read_only, no-new-privileges, cap_drop ALL - Fix README documentation (previously incorrectly stated shell=True) - Document Unix command injection prevention in README
- Add test_config.py with Docker detection and security warning tests - Add tests for ValueError handling in cli_executor.py - Add tests for permissive mode and pattern matching in security.py - Add tests for dangerous pattern detection in tools.py - Fix test_validate_pipe_command to use current implementation
- Add _check_sed_execute_flag() using regex to detect dangerous 'e' flag while avoiding false positives on patterns like '/error/' - Extract duplicated chmod/chown system paths to shared _SYSTEM_DIRS constant - Use modern Python 3.9+ type hints (list[str] instead of List[str]) - Remove unnecessary enumerate() calls in parser functions - Convert repetitive dangerous pattern tests to parameterized table-driven tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.