Use weak features

Author: mulimoen

.github/workflows/ci.yml

@@ -47,7 +47,7 @@ jobs:
         uses: actions-rs/toolchain@v1
         with: {toolchain: nightly, profile: minimal, override: true}
       - name: Document workspace
-        run: env RUSTDOCFLAGS="--cfg docsrs" cargo doc --features hdf5-sys/static,hdf5-sys/zlib,blosc,lzf
+        run: env RUSTDOCFLAGS="--cfg docsrs" cargo doc --features static,zlib,blosc,lzf
 
   brew:
     name: brew

hdf5-src/Cargo.toml

@@ -30,7 +30,7 @@ edition.workspace = true
 
 [features]
 hl = []
-zlib = ["libz-sys"]
+zlib = ["dep:libz-sys"]
 deprecated = []
 threadsafe = []
 

hdf5-sys/Cargo.toml

@@ -23,12 +23,12 @@ hdf5-src = { workspace = true, optional = true }
 # Please see README for further explanation of these feature flags
 [features]
 default = []
-mpio = ["mpi-sys"]
-hl = ["hdf5-src/hl"]
-threadsafe = ["hdf5-src/threadsafe"]
-zlib = ["libz-sys", "hdf5-src/zlib"]
-static = ["hdf5-src"]
-deprecated = ["hdf5-src/deprecated"]
+mpio = ["dep:mpi-sys"]
+hl = ["hdf5-src?/hl"]
+threadsafe = ["hdf5-src?/threadsafe"]
+zlib = ["libz-sys", "hdf5-src?/zlib"]
+static = ["dep:hdf5-src"]
+deprecated = ["hdf5-src?/deprecated"]
 
 [build-dependencies]
 libloading = "0.8"

hdf5-sys/build.rs

@@ -168,6 +168,8 @@ pub struct Header {
     pub have_direct: bool,
     pub have_parallel: bool,
     pub have_threadsafe: bool,
+    pub have_zlib: bool,
+    pub have_no_deprecated: bool,
     pub version: Version,
 }
 
@@ -193,6 +195,10 @@ impl Header {
                 hdr.have_parallel = value > 0;
             } else if name == "H5_HAVE_THREADSAFE" {
                 hdr.have_threadsafe = value > 0;
+            } else if name == "H5_HAVE_FILTER_DEFLATE" {
+                hdr.have_zlib = value > 0;
+            } else if name == "H5_NO_DEPRECATED_SYMBOLS" {
+                hdr.have_no_deprecated = value > 0;
             }
         }
 
@@ -581,6 +587,7 @@ impl LibrarySearcher {
             }
             let config = Config { inc_dir: inc_dir.clone(), link_paths, header };
             validate_runtime_version(&config);
+            config.check_against_features_required();
             config
         } else {
             panic!("Unable to determine HDF5 location (set HDF5_DIR to specify it manually).");
@@ -645,6 +652,24 @@ impl Config {
             println!("cargo:have_threadsafe=1");
         }
     }
+
+    fn check_against_features_required(&self) {
+        if feature_enabled("DEPRECATED") {
+            assert!(!self.header.have_no_deprecated, "Required deprecated symbols are not present")
+        }
+        if feature_enabled("THREADSAFE") {
+            assert!(
+                self.header.have_threadsafe,
+                "Required threadsafe but library was not build using the threadsafe option"
+            );
+        }
+        if feature_enabled("ZLIB") {
+            assert!(
+                self.header.have_zlib,
+                "Required zlib filter but library does not have builtin support for this options"
+            );
+        }
+    }
 }
 
 fn main() {

hdf5/Cargo.toml

@@ -15,9 +15,11 @@ edition.workspace = true
 
 [features]
 default = []
-mpio = ["mpi-sys", "hdf5-sys/mpio"]
-lzf = ["lzf-sys", "errno"]
-blosc = ["blosc-sys"]
+mpio = ["dep:mpi-sys", "hdf5-sys/mpio"]
+lzf = ["dep:lzf-sys", "dep:errno"]
+blosc = ["dep:blosc-sys"]
+static = ["hdf5-sys/static"]
+zlib = ["hdf5-sys/zlib"]
 # The features with version numbers such as 1.10.3, 1.12.0 are metafeatures
 # and is only available when the HDF5 library is at least this version.
 # Features have_direct and have_parallel are also metafeatures and dependent