fix(python): add missing thinking events to Event union #753
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Event union type was missing the following event types that are defined as BaseEvent subclasses: - ThinkingStartEvent - ThinkingEndEvent - ThinkingTextMessageStartEvent - ThinkingTextMessageContentEvent - ThinkingTextMessageEndEvent This caused validation errors when using TypeAdapter[Event] to parse events from models that emit thinking events (e.g., Claude with extended thinking). Also adds a test to ensure all BaseEvent subclasses are included in the Event union, preventing similar issues in the future.
jens-gilion
requested review from
NathanTarbert,
ataibarkai,
maxkorp,
mme,
ranst91 and
tylerslaton
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #752
The
Eventunion type was missing the following event types that are defined asBaseEventsubclasses:ThinkingStartEventThinkingEndEventThinkingTextMessageStartEventThinkingTextMessageContentEventThinkingTextMessageEndEventThis caused validation errors when using
TypeAdapter[Event]to parse events from models that emit thinking events (e.g., Claude with extended thinking via pydantic-ai'sAGUIEventStream).Changes
Eventunion inevents.pyBaseEventsubclasses are included in theEventunion, preventing similar issues in the futureTest Plan
python -m unittest tests.test_events.TestEvents.test_all_event_subclasses_in_event_union- passesTypeAdapter[Event]