fix(dark-mode): article-card body stays white#98
Open
dosteinacher wants to merge 1 commit into
Open
Conversation
`.article-card .article-card-body` hardcodes `background: var(--color-white)` in lazy-styles.css, so when the OS prefers dark mode and styles.css flips the outer `.article-card` to #1e1e1e, the inner body stays white. The h3 inside then inherits the now-light `--body-color` (#e8e8e8) — light text on white, unreadable on the listing page. Mirror the outer-card override on `.article-card-body` so the title sits on its intended dark surface, and bump the hover shadow opacity (the default 12% black is invisible on dark) so the hover feedback still reads. Light mode is unchanged — this is added inside the existing `@media (prefers-color-scheme: dark)` block. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.article-card .article-card-bodyhardcodesbackground: var(--color-white)inlazy-styles.css, so when the OS prefers dark mode, the outer.article-cardflips to#1e1e1ebut the inner body stays white. The h3 inside then inherits--body-color(#e8e8e8in dark mode) — light text on white, unreadable..article-carddark-mode override onto.article-card-bodyso the title sits on its intended dark surface.rgb(0 0 0 / 12%)is invisible on a dark background.Light mode is unchanged. Change is fully contained inside the existing
@media (prefers-color-scheme: dark)block instyles/styles.css.Test plan
/, a tag page), toggle macOS / browser dark mode → titles + descriptions readable inside cards🤖 Generated with Claude Code
Preview
Branch preview host:
fix-dark-mode-article-cards--inside-aem--adobe.aem.page