patch: manage argrument positioning of sprintf in translation

see https://www.php.net/manual/en/function.sprintf.php#refsect1-function.sprintf-examples

Author: dimtrovich

src/Input/Parameter.php

@@ -84,7 +84,7 @@ public function desc(bool $withDefault = false): string
             return $this->desc;
         }
 
-        return ltrim(t('%s [default: %s]', [$this->desc, json_encode($this->default)]));
+        return ltrim(t('%1$s [default: %2$s]', [$this->desc, json_encode($this->default)]));
     }
 
     /**

src/Input/Parser.php

@@ -221,7 +221,7 @@ protected function validate(): void
                 [$name, $label] = [$item->long(), 'Option'];
             }
 
-            throw new RuntimeException(t('%s "%s" is required', [$label, $name]));
+            throw new RuntimeException(t('%1$s "%2$s" is required', [$label, $name]));
         }
     }
 

src/Output/ProgressBar.php

@@ -169,7 +169,7 @@ public function current(int $current, string $label = '')
 
         if ($current > $this->total) {
             throw new UnexpectedValueException(
-                t('The current (%d) is greater than the total (%d).', [$current, $this->total])
+                t('The current (%1$d) is greater than the total (%2$d).', [$current, $this->total])
             );
         }
 

tests/ApplicationTest.php

@@ -331,20 +331,20 @@ public function test_on_exception()
     public function test_default_translations()
     {
         $this->assertSame('Show version', t('Show version'));
-        $this->assertSame('Verbosity level [default: 0]', t('%s [default: %s]', ['Verbosity level', 0]));
+        $this->assertSame('Verbosity level [default: 0]', t('%1$s [default: %2$s]', ['Verbosity level', 0]));
         $this->assertSame('Command "rmdir" already added', t('Command "%s" already added', ['rmdir']));
     }
 
     public function test_custom_translations(): void
     {
         Application::addLocale('fr', [
             'Show version' => 'Afficher la version',
-            '%s [default: %s]' => '%s [par défaut: %s]',
+            '%1$s [default: %2$s]' => '%1$s [par défaut: %2$s]',
             'Command "%s" already added' => 'La commande "%s" a déjà été ajoutée'
         ], true);
 
         $this->assertSame('Afficher la version', t('Show version'));
-        $this->assertSame('Niveau de verbosite [par défaut: 0]', t('%s [default: %s]', ['Niveau de verbosite', 0]));
+        $this->assertSame('Niveau de verbosite [par défaut: 0]', t('%1$s [default: %2$s]', ['Niveau de verbosite', 0]));
         $this->assertSame('La commande "rmdir" a déjà été ajoutée', t('Command "%s" already added', ['rmdir']));
 
         // untranslated key
@@ -357,7 +357,7 @@ public function test_app_translated()
         $app->addLocale('fr', [
             'Show version' => 'Afficher la version',
             'Verbosity level' => 'Niveau de verbocité',
-            '%s [default: %s]' => '%s [par défaut: %s]',
+            '%1$s [default: %2$s]' => '%s [par défaut: %s]',
         ], true);
         $app->command('rmdir');
 

tests/Output/ProgressBarTest.php

@@ -78,6 +78,7 @@ public function getIterator(): Traversable
         $this->assertNotNull((new Terminal)->height());
 
         $this->expectException(UnexpectedValueException::class);
+        $this->expectExceptionMessage('The current (2) is greater than the total (1).');
         (new ProgressBar(1))->current(2);
     }
 }