Merge pull request #242 from adafruit/some-enhance

Some enhance

Author: hathach

.github/ISSUE_TEMPLATE/bug_report.yml

@@ -52,11 +52,11 @@ body:
 
   - type: textarea
     attributes:
-      label: Sketch & Compiled output (as attached txt files)
+      label: Sketch & compiled Log (as attached txt files)
       placeholder: |
         e.g examples/MassStorage/msc_ramdisk.
         If it is custom sketch, please provide it as **ATTACHED** files or link to it.
-        Compiled output must be attached as txt files for readability
+        Compiled log must be attached as txt files for readability
     validations:
       required: true
 

src/arduino/midi/Adafruit_USBD_MIDI.cpp

@@ -76,7 +76,7 @@ bool Adafruit_USBD_MIDI::setCableName(uint8_t cable_id, const char *str) {
   }
 
   uint8_t strid = TinyUSBDevice.addStringDescriptor(str);
-  _cable_name_strid[cable_id] = strid;
+  _cable_name_strid[cable_id - 1] = strid;
 
   return strid > 0;
 }
@@ -117,7 +117,7 @@ uint16_t Adafruit_USBD_MIDI::makeItfDesc(uint8_t itfnum, uint8_t *buf,
 
   // Jack
   for (uint8_t i = 1; i <= _n_cables; i++) {
-    uint8_t jack[] = {TUD_MIDI_DESC_JACK_DESC(i, _cable_name_strid[i])};
+    uint8_t jack[] = {TUD_MIDI_DESC_JACK_DESC(i, _cable_name_strid[i - 1])};
     memcpy(buf + len, jack, sizeof(jack));
     len += sizeof(jack);
   }

src/arduino/midi/Adafruit_USBD_MIDI.h

@@ -69,7 +69,7 @@ class Adafruit_USBD_MIDI : public Stream, public Adafruit_USBD_Interface {
 
 private:
   uint8_t _n_cables;
-  uint8_t _cable_name_strid[8];
+  uint8_t _cable_name_strid[16];
 };
 
 #endif /* ADAFRUIT_USBD_MIDI_H_ */

src/arduino/ports/rp2040/tusb_config_rp2040.h

@@ -125,9 +125,9 @@ extern int serial1_printf(const char *__restrict __format, ...);
 
 // Set Line Coding on enumeration/mounted, value for cdc_line_coding_t
 // bit rate = 115200, 1 stop bit, no parity, 8 bit data width
-// This need https://github.com/sekigon-gonnoc/Pico-PIO-USB/pull/58 to be merged
-// first #define CFG_TUH_CDC_LINE_CODING_ON_ENUM   { 115200,
-// CDC_LINE_CONDING_STOP_BITS_1, CDC_LINE_CODING_PARITY_NONE, 8 }
+// This need Pico-PIO-USB at least 0.5.1
+#define CFG_TUH_CDC_LINE_CODING_ON_ENUM                                        \
+  { 115200, CDC_LINE_CONDING_STOP_BITS_1, CDC_LINE_CODING_PARITY_NONE, 8 }
 
 #ifdef __cplusplus
 }