Add quarter circle draw-with-fill method #488
Open
+70
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@ladyada for review. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new fillQuarterCircle function to the Adafruit_GFX library that provides more granular control over filled circle drawing by supporting all four quadrants independently using a 4-bit mask (0x1, 0x2, 0x4, 0x8), unlike the existing fillCircleHelper which only supports left/right halves using a 2-bit mask.
- Added
fillQuarterCirclemethod declaration to Adafruit_GFX.h - Implemented
fillQuarterCirclein Adafruit_GFX.cpp with full documentation
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Adafruit_GFX.h | Added function declaration for fillQuarterCircle with parameters matching the implementation |
| Adafruit_GFX.cpp | Implemented fillQuarterCircle function with Midpoint Circle Algorithm and comprehensive documentation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
@ladyada for review. |
1 similar comment
Contributor
Author
|
@ladyada for review. |
Member
|
hi please do not bump/tag |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method adds the ability to draw filled quarter circles, which currently isn't possible.