Skip to content

Conversation

@Andrew882024
Copy link

@Andrew882024 Andrew882024 commented Dec 1, 2025

Info

(no issue for this pull request yet)

Description

What changes did you make? List all distinct problems that this PR addresses. Explain any relevant
motivation or context.

[description]

This PR updates the Application type/validator to match Hackathon Organizer Guide requirement, and adds basic tests + comments to make this behavior clearer.

Changes

1, Updated the type and validator for Application.
2, Checked the database structure (no update needed, since it stores all Application data as JSON rather than in separate columns)
3, Manually tested it and it passed.
4, Added two unit tests.
5, Updated the README.

Type of Change

  • Patch (non-breaking change/bugfix)
  • Minor (non-breaking change which adds functionality)
  • Major (fix or feature that would cause existing functionality to not work as
    expected)
  • Documentation (A change to a README/description)
  • Continuous Integration/DevOps Change (Related to deployment steps, continuous integration
    workflows, linting, etc.)
  • Other: (Fill In)

If you've selected Patch, Minor, or Major as your change type, make sure to bump the version before merging in package.json!

Testing

I have tested that my changes fully resolve the linked issue ...

  • locally.
  • on the testing API/testing database.
  • with appropriate Postman routes. Screenshots are included below.

Checklist

  • I have performed a self-review of my own code.
  • I have followed the style guidelines of this project.
  • I have appropriately edited the API version in the package.json file.
  • My changes produce no new warnings.

Screenshots

Please include a screenshot of your Postman testing passing successfully.

@vercel
Copy link

vercel bot commented Dec 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
hackathon-portal Ready Ready Preview Comment Dec 1, 2025 8:23pm

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

Thanks for contributing!
If you've made changes to the API's functionality, please make sure to bump the package
version—see this guide to semantic versioning for details—and
document those changes as appropriate.

@Allow() // optional
additionalComments: string;

// ### Optional Demographic Fields ###
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't these be @Allow() if they aren't required?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants