Remove value preview functionality and enhance test coverage

abr4xas · abr4xas · commit a06c8979d3ec · 2025-10-02T22:34:12.000-03:00
- Remove getValuePreview() method and related value display functionality
- Remove ValuePreviewTest.php and related test cases
- Simplify command output to show only cache keys without values
- Add comprehensive unit tests for CacheUiLaravelCommand private methods
- Add tests for CacheUiLaravelServiceProvider and CacheUiLaravel Facade
- Improve test coverage across all package components
- Update command interface to focus on key listing and deletion only
diff --git a/README.md b/README.md
@@ -103,7 +103,7 @@ Are you sure you want to delete this cache key? › No / Yes
 🗑️  The key 'user_1_profile' has been successfully deleted
 ```
 
-### Programmatic Usage
+### Programmatic Usage (optional)
 
 You can also use the `CacheUiLaravel` class directly in your code:
 
diff --git a/src/Commands/CacheUiLaravelCommand.php b/src/Commands/CacheUiLaravelCommand.php
@@ -61,27 +61,8 @@ public function handle(): int
             return self::SUCCESS;
         }
 
-        // Get the key value to show information
-        // For Redis, we need to add the prefix back since we removed it when listing keys
-        if ($this->driver === 'redis') {
-            $prefix = config('database.redis.options.prefix', '');
-            $fullKey = $prefix ? $prefix.$selectedKey : $selectedKey;
-            $value = $this->store->get($fullKey);
-        } else {
-            $value = $this->store->get($selectedKey);
-        }
-
-        // If value is still null, try different approaches based on driver
-        if ($value === null && $this->driver === 'file') {
-            // For file driver, we need to find the file that contains this key
-            $value = $this->getFileKeyValueByKey($selectedKey);
-        }
-
-        $valuePreview = $this->getValuePreview($value);
-
         $this->newLine();
         $this->line("📝 <fg=cyan>Key:</>      {$selectedKey}");
-        $this->line("💾 <fg=cyan>Value:</>    {$valuePreview}");
         $this->newLine();
 
         $confirmed = confirm(
@@ -236,80 +217,6 @@ private function handleUnsupportedDriver(): array
         return [];
     }
 
-    private function getValuePreview(mixed $value): string
-    {
-        $previewLimit = config('cache-ui-laravel.preview_limit', 100);
-
-        if (is_null($value)) {
-            return '<fg=gray>(null)</>';
-        }
-
-        if (is_bool($value)) {
-            return $value ? '<fg=green>true</>' : '<fg=red>false</>';
-        }
-
-        if (is_array($value) || is_object($value)) {
-            $json = json_encode($value, JSON_UNESCAPED_UNICODE);
-            if (mb_strlen($json) > $previewLimit) {
-                return mb_substr($json, 0, $previewLimit).'<fg=gray>...</>';
-            }
-
-            return $json;
-        }
-
-        $stringValue = (string) $value;
-        if (mb_strlen($stringValue) > $previewLimit) {
-            return mb_substr($stringValue, 0, $previewLimit).'<fg=gray>...</>';
-        }
-
-        return $stringValue;
-    }
-
-    private function getFileKeyValueByKey(string $key): mixed
-    {
-        try {
-            $cachePath = config('cache.stores.file.path', storage_path('framework/cache/data'));
-
-            if (! File::exists($cachePath)) {
-                return null;
-            }
-
-            $files = File::allFiles($cachePath);
-
-            foreach ($files as $file) {
-                try {
-                    $content = File::get($file->getPathname());
-
-                    // Laravel file cache format: expiration_time + serialized_value
-                    if (mb_strlen($content) < 10) {
-                        continue;
-                    }
-
-                    $expiration = mb_substr($content, 0, 10);
-                    $serialized = mb_substr($content, 10);
-
-                    // Check if expired
-                    if (time() > $expiration) {
-                        continue;
-                    }
-
-                    // Try to unserialize to get the data
-                    $data = unserialize($serialized);
-                    if (is_array($data) && isset($data['key']) && $data['key'] === $key) {
-                        return $data['value'] ?? null;
-                    }
-                } catch (Exception) {
-                    // If we can't read this file, skip it
-                    continue;
-                }
-            }
-
-            return null;
-        } catch (Exception) {
-            return null;
-        }
-    }
-
     private function getFileKeyValue(string $filename): mixed
     {
         try {
diff --git a/tests/Unit/CacheUiLaravelCommandSimpleTest.php b/tests/Unit/CacheUiLaravelCommandSimpleTest.php
@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 use Abr4xas\CacheUiLaravel\Commands\CacheUiLaravelCommand;
-use Illuminate\Support\Facades\Config;
 
 describe('CacheUiLaravelCommand Basic Tests', function (): void {
     it('has correct signature and description', function (): void {
@@ -27,88 +26,6 @@
     });
 });
 
-describe('getValuePreview method', function (): void {
-    it('handles null values', function (): void {
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $result = $method->invoke($command, null);
-        expect($result)->toBe('<fg=gray>(null)</>');
-    });
-
-    it('handles boolean values', function (): void {
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $trueResult = $method->invoke($command, true);
-        $falseResult = $method->invoke($command, false);
-
-        expect($trueResult)->toBe('<fg=green>true</>');
-        expect($falseResult)->toBe('<fg=red>false</>');
-    });
-
-    it('handles array values', function (): void {
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $array = ['key' => 'value', 'number' => 123];
-        $result = $method->invoke($command, $array);
-
-        expect($result)->toBe('{"key":"value","number":123}');
-    });
-
-    it('handles object values', function (): void {
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $object = (object) ['key' => 'value'];
-        $result = $method->invoke($command, $object);
-
-        expect($result)->toBe('{"key":"value"}');
-    });
-
-    it('handles string values within limit', function (): void {
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $shortString = 'Hello World';
-        $result = $method->invoke($command, $shortString);
-
-        expect($result)->toBe('Hello World');
-    });
-
-    it('handles string values exceeding limit', function (): void {
-        Config::set('cache-ui-laravel.preview_limit', 10);
-
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $longString = 'This is a very long string that exceeds the limit';
-        $result = $method->invoke($command, $longString);
-
-        expect($result)->toBe('This is a <fg=gray>...</>');
-    });
-
-    it('handles array values exceeding limit', function (): void {
-        Config::set('cache-ui-laravel.preview_limit', 20);
-
-        $command = new CacheUiLaravelCommand();
-        $reflection = new ReflectionClass($command);
-        $method = $reflection->getMethod('getValuePreview');
-
-        $largeArray = ['very' => 'long', 'array' => 'with', 'many' => 'keys', 'and' => 'values'];
-        $result = $method->invoke($command, $largeArray);
-
-        expect($result)->toContain('<fg=gray>...</>');
-    });
-});
-
 describe('getCacheKeys method', function (): void {
     it('returns array for any driver type', function (): void {
         $command = new CacheUiLaravelCommand();
diff --git a/tests/Unit/CacheUiLaravelCommandTest.php b/tests/Unit/CacheUiLaravelCommandTest.php
@@ -0,0 +1,78 @@
+<?php
+
+declare(strict_types=1);
+
+use Abr4xas\CacheUiLaravel\Commands\CacheUiLaravelCommand;
+
+describe('CacheUiLaravelCommand Method Tests', function (): void {
+    describe('getArrayKeys method', function (): void {
+        it('returns empty array and shows warning', function (): void {
+            $command = new CacheUiLaravelCommand();
+            $reflection = new ReflectionClass($command);
+            $method = $reflection->getMethod('getArrayKeys');
+
+            $result = $method->invoke($command);
+            expect($result)->toBeArray();
+            expect($result)->toBeEmpty();
+        });
+    });
+
+    describe('handleUnsupportedDriver method', function (): void {
+        it('exists and is private', function (): void {
+            $command = new CacheUiLaravelCommand();
+            $reflection = new ReflectionClass($command);
+            $method = $reflection->getMethod('handleUnsupportedDriver');
+
+            expect($method->isPrivate())->toBeTrue();
+            expect($method->getReturnType()->getName())->toBe('array');
+        });
+    });
+
+    describe('getFileKeyValue method', function (): void {
+        it('returns null when file does not exist', function (): void {
+            $command = new CacheUiLaravelCommand();
+            $reflection = new ReflectionClass($command);
+            $method = $reflection->getMethod('getFileKeyValue');
+
+            $result = $method->invoke($command, 'nonexistent_file');
+            expect($result)->toBeNull();
+        });
+    });
+
+    describe('deleteFileKey method', function (): void {
+        it('returns false when file does not exist', function (): void {
+            $command = new CacheUiLaravelCommand();
+            $reflection = new ReflectionClass($command);
+            $method = $reflection->getMethod('deleteFileKey');
+
+            $result = $method->invoke($command, 'nonexistent_file');
+            expect($result)->toBeFalse();
+        });
+    });
+
+    describe('method existence', function (): void {
+        it('has all required private methods', function (): void {
+            $command = new CacheUiLaravelCommand();
+            $reflection = new ReflectionClass($command);
+
+            $expectedMethods = [
+                'getCacheKeys',
+                'getRedisKeys',
+                'getFileKeys',
+                'getDatabaseKeys',
+                'getArrayKeys',
+                'handleUnsupportedDriver',
+                'getFileKeyValue',
+                'deleteFileKeyByKey',
+                'deleteFileKey',
+            ];
+
+            foreach ($expectedMethods as $methodName) {
+                expect($reflection->hasMethod($methodName))->toBeTrue();
+
+                $method = $reflection->getMethod($methodName);
+                expect($method->isPrivate())->toBeTrue();
+            }
+        });
+    });
+});
diff --git a/tests/Unit/CacheUiLaravelFacadeTest.php b/tests/Unit/CacheUiLaravelFacadeTest.php
@@ -0,0 +1,48 @@
+<?php
+
+declare(strict_types=1);
+
+use Abr4xas\CacheUiLaravel\Facades\CacheUiLaravel;
+use Illuminate\Support\Facades\Facade;
+
+describe('CacheUiLaravel Facade Tests', function (): void {
+    describe('Facade structure', function (): void {
+        it('extends Laravel Facade', function (): void {
+            $reflection = new ReflectionClass(CacheUiLaravel::class);
+            expect($reflection->getParentClass()->getName())->toBe(Facade::class);
+        });
+
+        it('is final class', function (): void {
+            $reflection = new ReflectionClass(CacheUiLaravel::class);
+            expect($reflection->isFinal())->toBeTrue();
+        });
+
+        it('has correct facade accessor', function (): void {
+            $reflection = new ReflectionClass(CacheUiLaravel::class);
+            $method = $reflection->getMethod('getFacadeAccessor');
+
+            $accessor = $method->invoke(null);
+            expect($accessor)->toBe(Abr4xas\CacheUiLaravel\CacheUiLaravel::class);
+        });
+    });
+
+    describe('Facade functionality', function (): void {
+        it('has correct facade accessor method', function (): void {
+            $reflection = new ReflectionClass(CacheUiLaravel::class);
+            $method = $reflection->getMethod('getFacadeAccessor');
+
+            expect($method->isProtected())->toBeTrue();
+            expect($method->isStatic())->toBeTrue();
+        });
+    });
+
+    describe('Documentation', function (): void {
+        it('has proper docblock', function (): void {
+            $reflection = new ReflectionClass(CacheUiLaravel::class);
+            $docComment = $reflection->getDocComment();
+
+            expect($docComment)->toContain('@see');
+            expect($docComment)->toContain('CacheUiLaravel');
+        });
+    });
+});
diff --git a/tests/Unit/CacheUiLaravelServiceProviderTest.php b/tests/Unit/CacheUiLaravelServiceProviderTest.php
diff --git a/tests/Unit/ValuePreviewTest.php b/tests/Unit/ValuePreviewTest.php
