-
-
Notifications
You must be signed in to change notification settings - Fork 722
possible wrong rules triggering #4879
Copy link
Copy link
Open
Labels
Description
Description
In the BusyBox project I can see the phrase
and put under GPLv2 license.
which can be found at https://github.com/mirror/busybox/blob/master/networking/tls_aes.c#L39
This triggers https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_818.RULE
but it doesn't report https://github.com/aboutcode-org/scancode-toolkit/blob/develop/src/licensedcode/data/rules/gpl-2.0_493.RULE which would also be valid. This rule catches a little bit less, but also a little bit more. My question to @pombredanne and @AyanSinhaMahapatra is what the best course of action would be:
- ignore and just go with the 818 rule
- ignore and go with the 493 rule
- create a new rule that combines the two rules
How To Reproduce
Tell us how to reproduce the issue.
System configuration
For bug reports, it really helps us to know:
- What OS are you running on? (Windows/MacOS/Linux)
- What version of scancode-toolkit was used to generate the scan file?
- What installation method was used to install/run scancode? (pip/source download/other)
Reactions are currently unavailable