update atc check (#507)

Author: oblomov-dev

src/z2ui5_cl_demo_app_058.clas.abap

@@ -212,7 +212,7 @@ CLASS z2ui5_cl_demo_app_058 IMPLEMENTATION.
       lo_columns->column(
             minscreenwidth = shift_right( CONV string( lv_width ) ) && `px`
             demandpopin    = abap_true
-            width          = lr_field->length )->text( text = CONV char10( lr_field->title ) ).
+            width          = lr_field->length )->text( text = CONV string( lr_field->title ) ).
       lv_width = lv_width + 10.
     ENDLOOP.
 

src/z2ui5_cl_demo_app_116.clas.abap

@@ -37,7 +37,7 @@ CLASS z2ui5_cl_demo_app_116 DEFINITION
 
     DATA prodh_nodes TYPE ty_prodh_nodes .
     DATA is_initialized TYPE abap_bool .
-    DATA gv_user TYPE uname.
+    DATA gv_user TYPE c length 12.
     DATA gv_date TYPE d.
 
     DATA mv_run_js TYPE abap_bool VALUE abap_false.
@@ -145,8 +145,8 @@ CLASS Z2UI5_CL_DEMO_APP_116 IMPLEMENTATION.
                     text   = 'Date:'
         )->get_parent(
       )->vertical_layout( class = 'sapUiSmallMarginBeginEnd'
-        )->text( text = client->_bind( gv_user )
-        )->text( text = client->_bind( gv_date ) ).
+        )->text( client->_bind( gv_user )
+        )->text( client->_bind( gv_date ) ).
 
 
     DATA(sections) = page->sections( ).

src/z2ui5_cl_demo_app_126.clas.abap

@@ -107,7 +107,6 @@ CLASS Z2UI5_CL_DEMO_APP_126 IMPLEMENTATION.
           UP TO 100 ROWS.
 
       CATCH cx_root.
-
     ENDTRY.
 
     ASSIGN mt_table_tmp->* TO <table_tmp>.

src/z2ui5_cl_demo_app_130.clas.abap

@@ -32,9 +32,9 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION
       ty_t_filter_pop TYPE STANDARD TABLE OF ty_s_filter_pop WITH EMPTY KEY .
     TYPES:
       BEGIN OF ty_s_fieldsdb,
-        screen_name TYPE char10,
-        field       TYPE char10,
-        field_doma  TYPE char10,
+        screen_name TYPE string,
+        field       TYPE string,
+        field_doma  TYPE string,
       END OF ty_s_fieldsdb .
     TYPES
       ty_t_fieldsdb TYPE STANDARD TABLE OF ty_s_fieldsdb WITH DEFAULT KEY .
@@ -46,33 +46,33 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION
           END OF ty_s_fields .
     TYPES:
       BEGIN OF ty_s_var_val,
-        screen_name TYPE char10,
-        var         TYPE     char10,
-        field       TYPE     char10,
-        guid        TYPE     string,
-        sign        TYPE char1,
-        opt         TYPE char2,
-        low         TYPE char255,
-        high        TYPE char255,
+        screen_name TYPE string,
+        var         TYPE string,
+        field       TYPE string,
+        guid        TYPE string,
+        sign        TYPE string,
+        opt         TYPE string,
+        low         TYPE string,
+        high        TYPE string,
       END OF ty_s_var_val .
     TYPES
       ty_t_var_val TYPE STANDARD TABLE OF ty_s_var_val WITH DEFAULT KEY .
     TYPES:
       BEGIN OF ty_s_variants,
-        screen_name TYPE char10,
-        var         TYPE char10,
+        screen_name TYPE string,
+        var         TYPE string,
         descr       TYPE string,
       END OF ty_s_variants .
     TYPES
       ty_t_variants TYPE STANDARD TABLE OF ty_s_variants WITH DEFAULT KEY .
     TYPES
       BEGIN OF ty_s_var_pop.
         INCLUDE TYPE ty_s_variants.
-    TYPES: selkz TYPE xfeld,
+    TYPES: selkz TYPE abap_bool,
           END OF ty_s_var_pop .
     TYPES:
       BEGIN OF ty_s_screens,
-        screen_name TYPE char10,
+        screen_name TYPE string,
         descr       TYPE string,
       END OF ty_s_screens .
 
@@ -127,7 +127,7 @@ CLASS z2ui5_cl_demo_app_130 DEFINITION
     METHODS get_txt
       IMPORTING
                 roll          TYPE string
-                type          TYPE char1 OPTIONAL
+                type          TYPE string OPTIONAL
       RETURNING VALUE(result) TYPE string.
 
     METHODS get_txt_l

src/z2ui5_cl_demo_app_153.clas.abap

@@ -8,13 +8,11 @@ CLASS z2ui5_cl_demo_app_153 DEFINITION PUBLIC.
     TYPES:
       BEGIN OF ty_dataset2,
         label                TYPE string,
-*        type               TYPE string,
         data                 TYPE string_table,
         border_width         TYPE i,
-*        border_color       TYPE string,
         border_radius        TYPE i,
         border_skipped       TYPE abap_bool,
-        border_skipped_xfeld TYPE xfeld,
+        border_skipped_xfeld TYPE abap_bool,
       END OF ty_dataset2.
 
     TYPES:
@@ -29,7 +27,6 @@ CLASS z2ui5_cl_demo_app_153 DEFINITION PUBLIC.
         show_line      TYPE abap_bool,
         lvl2           TYPE ty_dataset2,
       END OF ty_dataset.
-
     TYPES ty_datasets TYPE STANDARD TABLE OF ty_dataset WITH DEFAULT KEY.
 
     TYPES:
@@ -43,11 +40,9 @@ CLASS z2ui5_cl_demo_app_153 DEFINITION PUBLIC.
         data TYPE ty_data,
       END OF ty_chart .
 
-
     DATA ms_struc TYPE ty_chart.
     DATA ms_struc2 TYPE ty_chart.
 
-
     METHODS ui5_display.
     METHODS ui5_event.
 
@@ -76,8 +71,6 @@ CLASS z2ui5_cl_demo_app_153 IMPLEMENTATION.
            )->button(
             text  = 'Rountrip...'
             press = client->_event( 'POPUP' )
-*           )->input( value = client->_bind_edit( mv_long_long_long_long_value ) width = `10%`
-*           )->input( value = client->_bind_edit( mv_long_long_long_long_value ) width = `10%`
              ).
 
     client->view_display( view->stringify( ) ).
@@ -95,9 +88,6 @@ CLASS z2ui5_cl_demo_app_153 IMPLEMENTATION.
           client->message_box_display( `structure changed error` ).
           RETURN.
         ENDIF.
-
-
-
         client->message_toast_display( `everything works as expected` ).
 
       WHEN 'BACK'.
@@ -110,36 +100,29 @@ CLASS z2ui5_cl_demo_app_153 IMPLEMENTATION.
 
   METHOD z2ui5_if_app~main.
 
-    DATA ls_dataset TYPE ty_dataset.
-
     me->client = client.
 
-    IF client->get( )-check_on_navigated = abap_true.
+    IF client->check_on_navigated( ).
 
       ms_struc-data-labels = VALUE #( ( `Jan` ) ( `Feb` ) ( `Mar` ) ( `Apr` ) ( `May` ) ( `Jun` ) ).
 
+      DATA ls_dataset TYPE ty_dataset.
       CLEAR ls_dataset.
       ls_dataset-label = 'Fully Rounded'.
       ls_dataset-border_width = 2.
       ls_dataset-border_radius = 200.
 
       ls_dataset-data = VALUE #( ( `1` ) ( `-12` ) ( `19` ) ( `3` ) ( `5` ) ( `-2` ) ( `3` ) ).
 
-
-
       APPEND ls_dataset TO ms_struc-data-datasets.
-
-
-
       ms_struc2 = ms_struc.
 
-
-
       ui5_display( ).
       RETURN.
     ENDIF.
 
     ui5_event( ).
 
   ENDMETHOD.
+
 ENDCLASS.

src/z2ui5_cl_demo_app_187.clas.abap

@@ -3,6 +3,8 @@ CLASS z2ui5_cl_demo_app_187 DEFINITION PUBLIC.
   PUBLIC SECTION.
     INTERFACES z2ui5_if_app.
 
+  PROTECTED SECTION.
+  PRIVATE SECTION.
 ENDCLASS.
 
 CLASS z2ui5_cl_demo_app_187 IMPLEMENTATION.
@@ -35,8 +37,10 @@ CLASS z2ui5_cl_demo_app_187 IMPLEMENTATION.
     CASE client->get( )-event.
 
       WHEN 'SY'.
-        MESSAGE ID 'NET' TYPE 'E' NUMBER '001' INTO DATA(lv_dummy).
-        client->message_box_display( sy ).
+        DATA(ls_msg2) = z2ui5_cl_util=>msg_get_by_msg(
+                  id     = 'NET'
+                  no     = `001` ).
+        client->message_box_display( ls_msg2 ).
 
       WHEN 'BAPIRET'.
 

src/z2ui5_cl_demo_app_192.clas.abap

@@ -6,9 +6,9 @@ CLASS z2ui5_cl_demo_app_192 DEFINITION PUBLIC.
     DATA client TYPE REF TO z2ui5_if_client.
 
     TYPES: BEGIN OF ty_s_key_value,
-             fname   TYPE char30,
+             fname   TYPE string,
              value   TYPE string,
-             tabname TYPE char30,
+             tabname TYPE string,
              comp    TYPE abap_componentdescr,
            END OF ty_s_key_value,
            ty_t_key_values TYPE STANDARD TABLE OF ty_s_key_value WITH EMPTY KEY.
@@ -20,8 +20,6 @@ CLASS z2ui5_cl_demo_app_192 DEFINITION PUBLIC.
            END OF ty_s_merged_data,
            ty_t_merged_data TYPE STANDARD TABLE OF ty_s_merged_data WITH EMPTY KEY.
 
-
-
     DATA mt_new_data2 TYPE STANDARD TABLE OF REF TO z2ui5_cl_demo_app_193 WITH EMPTY KEY.
 
     TYPES:
@@ -66,19 +64,18 @@ CLASS z2ui5_cl_demo_app_192 IMPLEMENTATION.
                  navbuttonpress = client->_event( val = 'BACK' )
                  shownavbutton  = abap_true
             )->header_content( ).
-
     client->view_display( view->stringify( ) ).
 
   ENDMETHOD.
 
   METHOD z2ui5_if_app~main.
-    xml_parse( ).
 
+    xml_parse( ).
     me->client = client.
     get_data( ).
     ui5_display( ).
-
     xml_stringify( ).
+
   ENDMETHOD.
 
   METHOD get_data.
@@ -94,7 +91,6 @@ CLASS z2ui5_cl_demo_app_192 IMPLEMENTATION.
     DATA(kopf) = REF #( mt_out ).
 
 
-
     LOOP AT kopf->* ASSIGNING <fs_s_head>.
 
       DATA(lo_new_data) = NEW z2ui5_cl_demo_app_193( ).

src/z2ui5_cl_demo_app_192.clas.locals_imp.abap

@@ -6,9 +6,9 @@ CLASS lcl_merged_data DEFINITION.
   PUBLIC SECTION.
 
     TYPES: BEGIN OF ty_s_key_value,
-             fname   TYPE char30,
+             fname   TYPE string,
              value   TYPE string,
-             tabname TYPE char30,
+             tabname TYPE string,
              comp    TYPE abap_componentdescr,
            END OF ty_s_key_value,
            ty_t_key_values TYPE STANDARD TABLE OF ty_s_key_value WITH EMPTY KEY.

src/z2ui5_cl_demo_app_319.clas.abap

@@ -11,7 +11,7 @@ CLASS z2ui5_cl_demo_app_319 DEFINITION PUBLIC.
       t_tokens TYPE STANDARD TABLE OF t_token WITH EMPTY KEY.
     TYPES:
       BEGIN OF t_range,
-        exclude      TYPE boole_d,
+        exclude      TYPE abap_bool,
         operation    TYPE string,
         value1       TYPE string,
         value2       TYPE string,

src/z2ui5_cl_demo_app_320.clas.abap

@@ -9,7 +9,7 @@ CLASS z2ui5_cl_demo_app_320 DEFINITION
 
     TYPES: BEGIN OF ty_item,
              id           TYPE string,
-             initials     TYPE char2,
+             initials     TYPE string,
              fallbackicon TYPE string,
              src          TYPE string,
              name         TYPE string,