From ee22d9cfb7198974e1368b9599ba797a26bc23e3 Mon Sep 17 00:00:00 2001 From: Stefano Guerrini Date: Wed, 14 Oct 2026 12:28:35 +0200 Subject: [PATCH] docs(release): merging the release PR releases The release environment no longer has required reviewers, so the docs and the workflow comments drop the approval step. --- .github/workflows/release.yml | 6 +++--- DEVELOPMENT.md | 6 ++---- 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 08b561b..508bb1c 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -108,8 +108,8 @@ jobs: echo "sha=$GITHUB_SHA" } >>"$GITHUB_OUTPUT" - # Checks and build run with read-only rights, before anyone approves. The - # job that can mint a PyPI token runs no project code. + # Checks and build run with read-only rights. The job that can mint a PyPI + # token runs no project code. build: name: Check and build needs: detect @@ -157,7 +157,7 @@ jobs: name: Tag, release and publish needs: [detect, build] runs-on: ubuntu-latest - # A person approves the release here. + # The release environment deploys only from main. environment: release concurrency: group: ${{ github.workflow }}-release diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 1ff05df..f9b269d 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -143,8 +143,7 @@ After each merge to `main`, release-please opens or updates the PR `chore: release X.Y.Z`. It sets the version in `pyproject.toml`, `src/zenrows/__version__.py` and `uv.lock`. Do not change these by hand. -To release, merge that PR. Then approve the run in the `release` -environment. The workflow runs the checks, creates the tag `vX.Y.Z` and the +To release, merge that PR. The workflow runs the checks, creates the tag `vX.Y.Z` and the GitHub release, and publishes to PyPI. To publish an existing tag again, run the Release workflow by hand from @@ -163,5 +162,4 @@ next release PR. To recover: `gh release create vX.Y.Z --target --title vX.Y.Z --generate-notes --notes-start-tag ` 3. On the merged release PR, replace the label `autorelease: pending` with `autorelease: tagged`. -4. Run the Release workflow by hand from `main` with the tag `vX.Y.Z`, and - approve it. +4. Run the Release workflow by hand from `main` with the tag `vX.Y.Z`.