switchto*: fix shellcheck

Author: Salamandar

switchtoTesting

@@ -1,19 +1,27 @@
-echo "----"
-echo "Patching sources.list to enable testing repository..."
-echo "----"
-for FILE in `ls /etc/apt/sources.list /etc/apt/sources.list.d/*`
-do
+#!/usr/bin/env bash
+
+cat << EOF
+----
+Patching sources.list to enable testing repository...
+----
+EOF
+
+readarray -d '' apt_files < <(find /etc/apt/sources.list /etc/apt/sources.list.d -type f -print0)
+for FILE in "${apt_files[@]}"; do
     # (Append 'testing' at the end of lines starting with the yunohost repo..)
-    sed -i 's@^deb.* http://forge.yunohost.org.*@& testing@' $FILE
+    sed -i 's@^deb.* http://forge.yunohost.org.*@& testing@' "$FILE"
 done
 
-echo "----"
-echo "Running 'apt-get update'"
-echo "----"
+cat << EOF
+----
+Running 'apt-get update'
+----
+EOF
 apt-get update
 
-echo "----"
-echo "Running 'apt-get dist-upgrade'"
-echo "----"
+cat << EOF
+----
+Running 'apt-get dist-upgrade'
+----
+EOF
 apt-get dist-upgrade -y
-

switchtoUnstable

@@ -1,19 +1,27 @@
-echo "----"
-echo "Patching sources.list to enable testing repository..."
-echo "----"
-for FILE in `ls /etc/apt/sources.list /etc/apt/sources.list.d/*`
-do
+#!/usr/bin/env bash
+
+cat << EOF
+----
+Patching sources.list to enable unstable repository...
+----
+EOF
+
+readarray -d '' apt_files < <(find /etc/apt/sources.list /etc/apt/sources.list.d -type f -print0)
+for FILE in "${apt_files[@]}"; do
     # (Append 'testing' at the end of lines starting with the yunohost repo..)
-    sed -i 's@^deb http://forge.yunohost.org.*@& testing unstable@' $FILE
+    sed -i 's@^deb http://forge.yunohost.org.*@& testing unstable@' "$FILE"
 done
 
-echo "----"
-echo "Running 'apt-get update'"
-echo "----"
+cat << EOF
+----
+Running 'apt-get update'
+----
+EOF
 apt-get update
 
-echo "----"
-echo "Running 'apt-get dist-upgrade'"
-echo "----"
+cat << EOF
+----
+Running 'apt-get dist-upgrade'
+----
+EOF
 apt-get dist-upgrade -y
-