From 821a65fb3f6f206a0a86b3f27122ecbc02704c69 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Thu, 23 Jul 2026 19:14:01 +0530 Subject: [PATCH 01/11] Add description to be added to admin notice if js not enabled --- src/wp-admin/font-library.php | 3 ++- src/wp-admin/options-connectors.php | 4 +++- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index abc2ea4f4da70..06af1e3db6dc8 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -28,7 +28,8 @@ } // Set the page title -$title = _x( 'Fonts', 'Font Library admin page title' ); +$title = _x( 'Fonts', 'Font Library admin page title' ); +$description = __( 'The Fonts screen requires JavaScript. Please enable JavaScript in your browser to install and manage fonts.' ); require_once ABSPATH . 'wp-admin/admin-header.php'; diff --git a/src/wp-admin/options-connectors.php b/src/wp-admin/options-connectors.php index c67d857b2b60d..286c8313ddab2 100644 --- a/src/wp-admin/options-connectors.php +++ b/src/wp-admin/options-connectors.php @@ -27,7 +27,9 @@ } // Set the page title. -$title = __( 'Connectors' ); +$title = __( 'Connectors' ); +$description = __( 'The Connectors screen requires JavaScript. Please enable JavaScript in your browser to manage your service integrations.' ); + // Set parent file for menu highlighting. $parent_file = 'options-general.php'; From a77da2f0376c1b317ca1cb77039dc21756c8bca5 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Fri, 24 Jul 2026 11:24:43 +0530 Subject: [PATCH 02/11] Update font-library and connectors admin page to show no-js notice --- src/wp-admin/css/common.css | 8 ++++++++ src/wp-admin/font-library.php | 18 ++++++++++++++++-- src/wp-admin/options-connectors.php | 19 ++++++++++++++++--- 3 files changed, 40 insertions(+), 5 deletions(-) diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css index c2ab1c31b5c34..301a7a2be4695 100644 --- a/src/wp-admin/css/common.css +++ b/src/wp-admin/css/common.css @@ -12,6 +12,10 @@ padding-left: 20px; } +#wpcontent section.wrap.hide-if-js { + padding-inline-start: 20px; +} + #wpcontent, #wpfooter { margin-left: 160px; @@ -4023,6 +4027,10 @@ img { padding-left: 10px; } + #wpcontent section.wrap.hide-if-js { + padding-inline-start: 10px; + } + #wpbody-content { padding-bottom: 100px; } diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index 06af1e3db6dc8..b6412497e88f3 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -28,11 +28,25 @@ } // Set the page title -$title = _x( 'Fonts', 'Font Library admin page title' ); -$description = __( 'The Fonts screen requires JavaScript. Please enable JavaScript in your browser to install and manage fonts.' ); +$title = _x( 'Fonts', 'Font Library admin page title' ); +$js_required_message = __( 'The Fonts screen requires JavaScript. Please enable JavaScript in your browser to install and manage fonts.' ); require_once ABSPATH . 'wp-admin/admin-header.php'; +?> +
+

+ array( 'error', 'hide-if-js' ), + ) + ); + ?> +
+ +
+

+ array( 'error', 'hide-if-js' ), + ) + ); + ?> +
+ Date: Fri, 24 Jul 2026 11:32:49 +0530 Subject: [PATCH 03/11] Fix phpcs feedbacks --- src/wp-admin/font-library.php | 2 +- src/wp-admin/options-connectors.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index b6412497e88f3..3d0367505e269 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -35,7 +35,7 @@ ?>
-

+

-

+

Date: Fri, 24 Jul 2026 11:37:39 +0530 Subject: [PATCH 04/11] Fix phpcs feedbacks --- src/wp-admin/font-library.php | 2 +- src/wp-admin/options-connectors.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index 3d0367505e269..31f1a8248aa04 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -43,7 +43,7 @@ 'additional_classes' => array( 'error', 'hide-if-js' ), ) ); - ?> + ?>
array( 'error', 'hide-if-js' ), ) ); - ?> + ?>
Date: Fri, 24 Jul 2026 11:44:41 +0530 Subject: [PATCH 05/11] Fix code quality to use `type` instead of adding `erorr` class --- src/wp-admin/font-library.php | 3 ++- src/wp-admin/options-connectors.php | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index 31f1a8248aa04..921051c68d969 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -40,7 +40,8 @@ wp_admin_notice( $js_required_message, array( - 'additional_classes' => array( 'error', 'hide-if-js' ), + 'type' => 'error', + 'additional_classes' => array( 'hide-if-js' ), ) ); ?> diff --git a/src/wp-admin/options-connectors.php b/src/wp-admin/options-connectors.php index 267d6fa81a867..61cd228c2acb7 100644 --- a/src/wp-admin/options-connectors.php +++ b/src/wp-admin/options-connectors.php @@ -42,7 +42,8 @@ wp_admin_notice( $js_required_message, array( - 'additional_classes' => array( 'error', 'hide-if-js' ), + 'type' => 'error', + 'additional_classes' => array( 'hide-if-js' ), ) ); ?> From 6e87d50db5f3a96bc1a455e6c84fd4304982920c Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Mon, 27 Jul 2026 11:19:14 +0530 Subject: [PATCH 06/11] Update section to div and use .hide-if-js class for notice --- src/wp-admin/css/common.css | 4 ++-- src/wp-admin/font-library.php | 4 ++-- src/wp-admin/options-connectors.php | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css index 948d257249569..3e9bf8aa92476 100644 --- a/src/wp-admin/css/common.css +++ b/src/wp-admin/css/common.css @@ -12,7 +12,7 @@ padding-left: 20px; } -#wpcontent section.wrap.hide-if-js { +#wpcontent div.wrap.hide-if-js { padding-inline-start: 20px; } @@ -4032,7 +4032,7 @@ img { padding-left: 10px; } - #wpcontent section.wrap.hide-if-js { + #wpcontent div.wrap.hide-if-js { padding-inline-start: 10px; } diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index 921051c68d969..94f1cc72eeba0 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -34,7 +34,7 @@ require_once ABSPATH . 'wp-admin/admin-header.php'; ?> -
+

-
+ -
+

-
+ Date: Mon, 27 Jul 2026 11:35:45 +0530 Subject: [PATCH 07/11] Improve the text for no-js text --- src/wp-admin/font-library.php | 2 +- src/wp-admin/options-connectors.php | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index 94f1cc72eeba0..eb1c1d810cf83 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -29,7 +29,7 @@ // Set the page title $title = _x( 'Fonts', 'Font Library admin page title' ); -$js_required_message = __( 'The Fonts screen requires JavaScript. Please enable JavaScript in your browser to install and manage fonts.' ); +$js_required_message = __( 'The Fonts screen requires JavaScript. Please enable JavaScript in your browser settings to install and manage fonts.' ); require_once ABSPATH . 'wp-admin/admin-header.php'; diff --git a/src/wp-admin/options-connectors.php b/src/wp-admin/options-connectors.php index 07072be8993c2..3932974f3b05a 100644 --- a/src/wp-admin/options-connectors.php +++ b/src/wp-admin/options-connectors.php @@ -28,7 +28,7 @@ // Set the page title. $title = __( 'Connectors' ); -$js_required_message = __( 'The Connectors screen requires JavaScript. Please enable JavaScript in your browser to manage your AI connectors.' ); +$js_required_message = __( 'The Connectors screen requires JavaScript. Please enable JavaScript in your browser settings to manage your AI connectors.' ); // Set parent file for menu highlighting. $parent_file = 'options-general.php'; From 8f4cd87d6cd24d3a6bb8545850fd6e68e32a9414 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Mon, 27 Jul 2026 11:43:02 +0530 Subject: [PATCH 08/11] Update text for non js notice --- src/wp-admin/options-connectors.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/wp-admin/options-connectors.php b/src/wp-admin/options-connectors.php index 3932974f3b05a..5719f96858182 100644 --- a/src/wp-admin/options-connectors.php +++ b/src/wp-admin/options-connectors.php @@ -28,7 +28,7 @@ // Set the page title. $title = __( 'Connectors' ); -$js_required_message = __( 'The Connectors screen requires JavaScript. Please enable JavaScript in your browser settings to manage your AI connectors.' ); +$js_required_message = __( 'The Connectors screen requires JavaScript. Please enable JavaScript in your browser settings to manage your connectors.' ); // Set parent file for menu highlighting. $parent_file = 'options-general.php'; From 8376b3362a91ee0facbc98544a2363ac1e5b6855 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Tue, 28 Jul 2026 16:59:52 +0530 Subject: [PATCH 09/11] Remove additional class from admin notice --- src/wp-admin/font-library.php | 3 +-- src/wp-admin/options-connectors.php | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index eb1c1d810cf83..a94b30237d321 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -40,8 +40,7 @@ wp_admin_notice( $js_required_message, array( - 'type' => 'error', - 'additional_classes' => array( 'hide-if-js' ), + 'type' => 'error', ) ); ?> diff --git a/src/wp-admin/options-connectors.php b/src/wp-admin/options-connectors.php index 5719f96858182..a8c0b6c5fc3cf 100644 --- a/src/wp-admin/options-connectors.php +++ b/src/wp-admin/options-connectors.php @@ -42,8 +42,7 @@ wp_admin_notice( $js_required_message, array( - 'type' => 'error', - 'additional_classes' => array( 'hide-if-js' ), + 'type' => 'error', ) ); ?> From 6bface7945a7df33d572a83e30a7e2559d7831ef Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Wed, 29 Jul 2026 10:49:01 +0530 Subject: [PATCH 10/11] Remove override styles --- src/wp-admin/css/common.css | 8 -------- 1 file changed, 8 deletions(-) diff --git a/src/wp-admin/css/common.css b/src/wp-admin/css/common.css index 3e9bf8aa92476..c286b8fa9ae0c 100644 --- a/src/wp-admin/css/common.css +++ b/src/wp-admin/css/common.css @@ -12,10 +12,6 @@ padding-left: 20px; } -#wpcontent div.wrap.hide-if-js { - padding-inline-start: 20px; -} - #wpcontent, #wpfooter { margin-left: 160px; @@ -4032,10 +4028,6 @@ img { padding-left: 10px; } - #wpcontent div.wrap.hide-if-js { - padding-inline-start: 10px; - } - #wpbody-content { padding-bottom: 100px; } From fa4398ec0b5b5ee5146d1a57786cf99ccc8255a2 Mon Sep 17 00:00:00 2001 From: hbhalodia Date: Thu, 30 Jul 2026 11:16:58 +0530 Subject: [PATCH 11/11] Address feedbacks --- src/wp-admin/font-library.php | 5 +++-- src/wp-admin/options-connectors.php | 5 +++-- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/wp-admin/font-library.php b/src/wp-admin/font-library.php index a94b30237d321..6129211f45545 100644 --- a/src/wp-admin/font-library.php +++ b/src/wp-admin/font-library.php @@ -35,12 +35,13 @@ ?>
-

+

'error', + 'type' => 'error', + 'additional_classes' => array( 'hide-if-js' ), ) ); ?> diff --git a/src/wp-admin/options-connectors.php b/src/wp-admin/options-connectors.php index a8c0b6c5fc3cf..7dc3b13508abe 100644 --- a/src/wp-admin/options-connectors.php +++ b/src/wp-admin/options-connectors.php @@ -37,12 +37,13 @@ ?>
-

+

'error', + 'type' => 'error', + 'additional_classes' => array( 'hide-if-js' ), ) ); ?>