Commit c760d16
Perf-Dashboard.Render sync phase sets location.hash, but the actual DOM (#488)
modifications happen asynchronously in the onhashchange() callback.
This results in nothing interesting being measured during the sync phase, and
the resulting rendering update (during the async phase) not including the
change.
Change the test to manually and synchronously trigger the onhashchange()
callback, and change the page content to detect and omit duplicate events.
Co-authored-by: Matt Woodrow <m_woodrow@apple.com>1 parent f4763c3 commit c760d16
File tree
3 files changed
+6
-4
lines changed- resources/perf.webkit.org/public/v3
- pages
3 files changed
+6
-4
lines changedSome generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
80 | 80 | | |
81 | 81 | | |
82 | 82 | | |
| 83 | + | |
83 | 84 | | |
84 | 85 | | |
85 | 86 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
97 | 97 | | |
98 | 98 | | |
99 | 99 | | |
100 | | - | |
| 100 | + | |
| 101 | + | |
101 | 102 | | |
102 | 103 | | |
103 | | - | |
| 104 | + | |
104 | 105 | | |
105 | 106 | | |
106 | 107 | | |
| |||
0 commit comments