Remove Orphaned Code (#480)

* Big cleanup of unused internals

* clean some unused imports

* Fix baseline, mark some deprecations coming

Author: SecondeJK

phpstan-baseline.neon

@@ -5,11 +5,6 @@ parameters:
 			count: 1
 			path: src/Account/Price.php
 
-		-
-			message: "#^Result of method Vonage\\\\Account\\\\Price\\:\\:getResponse\\(\\) \\(void\\) is used\\.$#"
-			count: 1
-			path: src/Account/Price.php
-
 		-
 			message: "#^Access to an undefined property Vonage\\\\Application\\\\Application\\:\\:\\$data\\.$#"
 			count: 1
@@ -55,21 +50,11 @@ parameters:
 			count: 1
 			path: src/Client/Exception/Server.php
 
-		-
-			message: "#^Result of method Vonage\\\\Network\\:\\:getResponse\\(\\) \\(void\\) is used\\.$#"
-			count: 1
-			path: src/Network.php
-
 		-
 			message: "#^Unsafe usage of new static\\(\\)\\.$#"
 			count: 1
 			path: src/Network/Number/Response.php
 
-		-
-			message: "#^Result of method Vonage\\\\Numbers\\\\Number\\:\\:getResponse\\(\\) \\(void\\) is used\\.$#"
-			count: 1
-			path: src/Numbers/Number.php
-
 		-
 			message: "#^Access to an undefined property Vonage\\\\Verify\\\\Verification\\:\\:\\$data\\.$#"
 			count: 1

src/Account/ClientFactory.php

@@ -6,9 +6,7 @@
 
 use Psr\Container\ContainerInterface;
 use Vonage\Client\APIResource;
-use Vonage\Client\Credentials\Handler\BasicHandler;
 use Vonage\Client\Credentials\Handler\BasicQueryHandler;
-
 class ClientFactory
 {
     public function __invoke(ContainerInterface $container): Client

src/Network.php src/Account/Network.phpsrc/Network.php renamed to src/Account/Network.php

@@ -1,19 +1,18 @@
 <?php
+
 declare(strict_types=1);
 
-namespace Vonage;
+namespace Vonage\Account;
 
 use Vonage\Entity\EntityInterface;
 use Vonage\Entity\Hydrator\ArrayHydrateInterface;
 use Vonage\Entity\JsonResponseTrait;
 use Vonage\Entity\JsonSerializableTrait;
 use Vonage\Entity\NoRequestResponseTrait;
 
-use function get_class;
 use function ltrim;
 use function preg_replace;
 use function strtolower;
-use function trigger_error;
 
 class Network implements
     EntityInterface,

src/Account/Price.php

@@ -4,17 +4,12 @@
 
 namespace Vonage\Account;
 
-use JsonSerializable;
 use RuntimeException;
 use Vonage\Entity\EntityInterface;
 use Vonage\Entity\Hydrator\ArrayHydrateInterface;
 use Vonage\Entity\JsonResponseTrait;
-use Vonage\Entity\JsonSerializableInterface;
 use Vonage\Entity\JsonSerializableTrait;
-use Vonage\Entity\JsonUnserializableInterface;
 use Vonage\Entity\NoRequestResponseTrait;
-use Vonage\Network;
-
 use function array_key_exists;
 use function ltrim;
 use function preg_replace;

src/Account/SmsPrice.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 namespace Vonage\Account;
-
 class SmsPrice extends Price
 {
     /**

src/Account/VoicePrice.php

@@ -3,7 +3,6 @@
 declare(strict_types=1);
 
 namespace Vonage\Account;
-
 class VoicePrice extends Price
 {
     /**

src/ApiErrorHandler.php

@@ -11,7 +11,6 @@
 use Vonage\Entity\Hydrator\ArrayHydrateInterface;
 use Vonage\Entity\JsonResponseTrait;
 use Vonage\Entity\JsonSerializableTrait;
-use Vonage\Entity\JsonUnserializableInterface;
 use Vonage\Entity\Psr7Trait;
 
 use function count;

src/Application/Application.php

@@ -356,6 +356,7 @@ public static function authRequest(RequestInterface $request, Basic $credentials
 
     /**
      * @throws ClientException
+     * @deprecated Use the Vonage/JWT library if you need to generate a token
      */
     public function generateJwt($claims = []): Token
     {

src/Client.php

@@ -4,20 +4,13 @@
 
 namespace Vonage\Client\Credentials;
 
-use Lcobucci\JWT\Configuration;
 use Lcobucci\JWT\Encoding\JoseEncoder;
 use Lcobucci\JWT\Signer\Key;
 use Lcobucci\JWT\Signer\Key\InMemory;
-use Lcobucci\JWT\Signer\Rsa\Sha256;
 use Lcobucci\JWT\Token;
 use Vonage\Application\Application;
-use Vonage\Client\Exception\Validation;
 use Vonage\JWT\TokenGenerator;
 
-use function base64_encode;
-use function mt_rand;
-use function time;
-
 /**
  * @property mixed application
  */