Merge pull request #236 from Nexmo/bug/235-calls-collection-invoke

dragonmantank · web-flow · commit 1a8ccfbde765 · 2020-08-13T15:48:21.000-04:00
Calls Collection/Client now handles being called by MapFactory
diff --git a/src/Call/Collection.php b/src/Call/Collection.php
@@ -59,9 +59,10 @@ public function hydrateEntity($data, $idOrCall)
      * @param null $callOrFilter
      * @return $this|Call
      */
-    public function __invoke(Filter $filter = null)
+    public function __invoke($filter = null)
     {
-        if (!is_null($filter)) {
+        /** Fix for the smarter MapFactory in v2.2.0 and the uniqueness of this class interface */
+        if (!is_null($filter) && $filter instanceof Filter) {
             $this->setFilter($filter);
         }
 

Original file line number	Diff line number	Diff line change
`@@ -59,9 +59,10 @@ public function hydrateEntity($data, $idOrCall)`
`59`	`59`	`* @param null $callOrFilter`
`60`	`60`	`* @return $this\|Call`
`61`	`61`	`*/`
`62`		`- public function __invoke(Filter $filter = null)`
	`62`	`+ public function __invoke($filter = null)`
`63`	`63`	`{`
`64`		`- if (!is_null($filter)) {`
	`64`	`+ /** Fix for the smarter MapFactory in v2.2.0 and the uniqueness of this class interface */`
	`65`	`+ if (!is_null($filter) && $filter instanceof Filter) {`
`65`	`66`	`$this->setFilter($filter);`
`66`	`67`	`}`
`67`	`68`