Merge pull request #87 from VincentLanglet/error

✨ Throw error instead of warning

Author: VincentLanglet

SymfonyCustom/Sniffs/Formatting/StrictComparisonSniff.php

@@ -6,7 +6,7 @@
 use PHP_CodeSniffer\Sniffs\Sniff;
 
 /**
- * Throws warning if == or != are use
+ * Throws error if == or != are use
  */
 class StrictComparisonSniff implements Sniff
 {
@@ -36,9 +36,9 @@ public function process(File $phpcsFile, $stackPtr): void
     {
         $tokens = $phpcsFile->getTokens();
 
-        // This warning is fixable, but it's too dangerous to add automatically fixer
-        $phpcsFile->addWarning(
-            'The %s comparator is not recommended, use %s instead',
+        // This error is fixable, but it's too dangerous to add automatically fixer
+        $phpcsFile->addError(
+            'The %s comparator is forbidden, use %s instead',
             $stackPtr,
             'NotStrict',
             [

SymfonyCustom/Tests/Formatting/StrictComparisonUnitTest.php

@@ -16,17 +16,17 @@ class StrictComparisonUnitTest extends AbstractSniffUnitTest
      */
     protected function getErrorList(): array
     {
-        return [];
+        return [
+            3 => 1,
+            5 => 1,
+        ];
     }
 
     /**
      * @return array
      */
     protected function getWarningList(): array
     {
-        return [
-            3 => 1,
-            5 => 1,
-        ];
+        return [];
     }
 }

SymfonyCustom/ruleset.xml

@@ -69,19 +69,23 @@
 
     <!-- Disallow -->
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
-    <rule ref="Generic.CodeAnalysis.AssignmentInCondition"/>
-    <rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>
+    <rule ref="Generic.CodeAnalysis.AssignmentInCondition">
+        <type>error</type>
+    </rule>
+    <rule ref="Generic.CodeAnalysis.EmptyPHPStatement">
+        <type>error</type>
+    </rule>
     <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
-    <rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
     <rule ref="Generic.PHP.BacktickOperator"/>
     <rule ref="Generic.PHP.DisallowShortOpenTag"/>
     <rule ref="Generic.PHP.ForbiddenFunctions"/>
     <rule ref="PEAR.Commenting.InlineComment"/>
-    <rule ref="Squiz.PHP.CommentedOutCode"/>
     <rule ref="Squiz.PHP.DisallowMultipleAssignments"/>
     <rule ref="Squiz.PHP.DiscouragedFunctions"/>
     <rule ref="Squiz.PHP.Eval"/>
-    <rule ref="Squiz.PHP.NonExecutableCode"/>
+    <rule ref="Squiz.PHP.NonExecutableCode">
+        <type>error</type>
+    </rule>
     <rule ref="Squiz.Operators.ValidLogicalOperators"/>
 
     <!-- Others -->