Merge pull request #85 from VincentLanglet/sniff

✨ Update sniff used

Author: VincentLanglet

SymfonyCustom/Sniffs/Namespaces/UnusedUseSniff.php

@@ -88,7 +88,8 @@ public function process(File $phpcsFile, $stackPtr): void
 
             $skip = Tokens::$emptyTokens + [T_COMMA => T_COMMA];
 
-            while ($classPtr = $phpcsFile->findPrevious($skip, $to - 1, $from + 1, true)) {
+            $classPtr = $phpcsFile->findPrevious($skip, $to - 1, $from + 1, true);
+            while ($classPtr) {
                 $to = $phpcsFile->findPrevious(T_COMMA, $classPtr - 1, $from + 1);
 
                 if (!$this->isClassUsed($phpcsFile, $stackPtr, $classPtr)) {
@@ -120,6 +121,8 @@ public function process(File $phpcsFile, $stackPtr): void
                 if (false === $to) {
                     break;
                 }
+
+                $classPtr = $phpcsFile->findPrevious($skip, $to - 1, $from + 1, true);
             }
 
             return;
@@ -166,7 +169,9 @@ public function process(File $phpcsFile, $stackPtr): void
             if (T_SEMICOLON === $tokens[$semiColon]['code']) {
                 break;
             }
-        } while ($semiColon = $phpcsFile->findEndOfStatement($semiColon + 1));
+
+            $semiColon = $phpcsFile->findEndOfStatement($semiColon + 1);
+        } while ($semiColon);
     }
 
     /**

SymfonyCustom/ruleset.xml

@@ -69,6 +69,7 @@
 
     <!-- Disallow -->
     <rule ref="Generic.Arrays.DisallowLongArraySyntax"/>
+    <rule ref="Generic.CodeAnalysis.AssignmentInCondition"/>
     <rule ref="Generic.CodeAnalysis.EmptyPHPStatement"/>
     <rule ref="Generic.CodeAnalysis.EmptyStatement"/>
     <rule ref="Generic.CodeAnalysis.UselessOverridingMethod"/>
@@ -78,7 +79,6 @@
     <rule ref="PEAR.Commenting.InlineComment"/>
     <rule ref="Squiz.PHP.CommentedOutCode"/>
     <rule ref="Squiz.PHP.DisallowMultipleAssignments"/>
-    <rule ref="Squiz.PHP.DisallowSizeFunctionsInLoops"/>
     <rule ref="Squiz.PHP.DiscouragedFunctions"/>
     <rule ref="Squiz.PHP.Eval"/>
     <rule ref="Squiz.PHP.NonExecutableCode"/>

TwigCS/Token/TokenParser.php

@@ -84,7 +84,8 @@ public function getTag(): string
     private function hasBody(TokenStream $stream): bool
     {
         $look = 0;
-        while ($token = $stream->look($look)) {
+        $token = $stream->look($look);
+        while ($token) {
             if ($token->getType() === Token::EOF_TYPE) {
                 return false;
             }
@@ -96,6 +97,7 @@ private function hasBody(TokenStream $stream): bool
             }
 
             $look++;
+            $token = $stream->look($look);
         }
 
         return false;