Allow all games to use detail prop shapes & update detail prop cvar defaults #1679
+4
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SirYodaJedi
reviewed
Nov 28, 2025
| #include "tier0/valve_minmax_on.h" | ||
|
|
||
| #if defined(DOD_DLL) || defined(CSTRIKE_DLL) | ||
| #if defined(DOD_DLL) || defined(CSTRIKE_DLL) || defined(TF_CLIENT_DLL) |
There was a problem hiding this comment.
Why not just remove the #ifdef, and have it enabled for all games? I don't see any reason to not have it in HL2DM (and I doubt it'll break HLDMS any further).
Contributor
Author
There was a problem hiding this comment.
Updated the PR to do this instead
horiuchii
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR simply enables detail shapes for all games, which also includes detail prop swaying and avoidance.
I'm unsure why this was never enabled for all games, nothing seems to be noticeably incorrect or bad after some basic testing in TF2.
I also updated the defaults for the CVars added to match the ones found in Day of Defeat: Source so that the new features can take effect.