test: show ShaderCompileTest in TestRunner (#589)

* give error message when a shader fails to compile
* change indent
* declare variable internally
* delete duplicate CompileTests
* add ToonConstants
* add shaders path constant
* open runtime assembly to tests
* add references to the runtime inside the EditorTests assembly

Author: sindharta

com.unity.toonshader/Editor/CompileTest.cs

@@ -1,5 +1,8 @@
 using System.Runtime.CompilerServices;
 [assembly: InternalsVisibleTo("Unity.ToonShader.Editor")]
+[assembly: InternalsVisibleTo("Unity.ToonShader.EditorTests")]
+
+
 [assembly: InternalsVisibleTo("Unity.VisualCompositor")]
 [assembly: InternalsVisibleTo("Unity.VisualCompositor.Tests")]
 [assembly: InternalsVisibleTo("Unity.VisualCompositor.Editor")]

com.unity.toonshader/Editor/CompileTest.cs.meta

@@ -5,6 +5,8 @@ namespace Unity.Rendering.Toon {
 
 internal static class ToonConstants {
 
+    internal const string PACKAGE_NAME = "com.unity.toonshader";
+    
     internal const string SHADER_KEYWORD_IS_CLIPPING_MATTE = "_IS_CLIPPING_MATTE";
 
     internal static readonly int SHADER_PROPERTY_CLIPPING_MATTE_MODE = Shader.PropertyToID("_ClippingMatteMode");

com.unity.toonshader/Runtime/AssemblyInfo.cs

@@ -1,35 +1,33 @@
+using System.IO;
 using NUnit.Framework;
 using UnityEditor;
 using UnityEngine;
-using System.Collections.Generic;
-using System.Reflection;
-using UnityEngine.TestTools;
+using Unity.Rendering.Toon;
+
+namespace Unity.ToonShader.EditorTests {
+internal class ShaderCompileTest
+{
+    [Test]
+    public void CompileToonShaders() {
+        string[] guids      = AssetDatabase.FindAssets("t:Shader", new[] { SHADERS_PATH});
+        int      numShaders = guids.Length;
+        Assert.Greater(numShaders,0);
+        for (int i=0;i<numShaders;++i) {
+            string curAssetPath = AssetDatabase.GUIDToAssetPath(guids[i]);
+            Shader shader = AssetDatabase.LoadAssetAtPath<Shader>(curAssetPath);
+            AssetDatabase.ImportAsset(curAssetPath); //Recompile the shader to make sure there are no compile errors
+
+            Assert.True(shader.isSupported);
+            bool shaderHasError = ShaderUtil.ShaderHasError(shader);
+            Assert.False(shaderHasError, "[UTS] Shader Compile Error: " + shader.name);
 
-namespace Unity.Rendering.ToonShader.Tests {
-    internal class ShaderCompileTest
-    {
-
-        [Test]
-        public void CompileLegacyToonShadersDefault() {
-            string[] guids      = AssetDatabase.FindAssets("t:Shader", new[] { LEGACY_SHADERS_PATH});
-            int      numShaders = guids.Length;
-            Assert.Greater(numShaders,0);
-            bool shaderHasError = false;
-            for (int i=0;i<numShaders && !shaderHasError;++i) {
-                string curAssetPath = AssetDatabase.GUIDToAssetPath(guids[i]);
-                Shader shader = AssetDatabase.LoadAssetAtPath<Shader>(curAssetPath);
-                AssetDatabase.ImportAsset(curAssetPath); //Recompile the shader to make sure there are no compile errors
-
-//                Assert.True(shader.isSupported);
-                shaderHasError = ShaderUtil.ShaderHasError(shader);
-                Assert.False(shaderHasError);
-
-            }
         }
+    }
 
+//----------------------------------------------------------------------------------------------------------------------
 
+    private static readonly string SHADERS_PATH = Path.Combine("Packages", ToonConstants.PACKAGE_NAME,"Runtime/Integrated/Shaders");
 
-        private const string LEGACY_SHADERS_PATH = "Packages/com.unity.toonshader/Runtime/Integrated/Shaders";
+}
 
-    }
 } //end namespace

com.unity.toonshader/Runtime/ToonConstants.cs

@@ -1,8 +1,10 @@
 {
     "name": "Unity.Toonshader.EditorTests",
+    "rootNamespace": "",
     "references": [
         "UnityEngine.TestRunner",
-        "UnityEditor.TestRunner"
+        "UnityEditor.TestRunner",
+        "Unity.Toonshader"
     ],
     "includePlatforms": [
         "Editor"
@@ -17,5 +19,6 @@
     "defineConstraints": [
         "UNITY_INCLUDE_TESTS"
     ],
-    "versionDefines": []
+    "versionDefines": [],
+    "noEngineReferences": false
 }