fix: network list contains backport 1.0.0 (#1622)

* changelog

(cherry picked from commit 2b16478)

* changelog

* Update CHANGELOG.md

(cherry picked from commit db8126d)

* fix: NetworkList.Contains inverted (#1363)

(cherry picked from commit cf0c9b4)

Co-authored-by: Matt Walsh <69258106+mattwalsh-unity@users.noreply.github.com>

Author: LukeStampfli

com.unity.netcode.adapter.utp/CHANGELOG.md

@@ -18,6 +18,7 @@ All notable changes to this package will be documented in this file. The format
 ### Fixed
 
 - Lifted the limit of ~44KB for reliable payloads. Before the fix, attempting to send a payload larger than that with reliable delivery would silently fail. Note that it is still not recommended to send such large reliable payloads, since their delivery could take a few network round-trips. (#1596)
+- Fixed a bug where NetworkList.contains value was inverted (#1363)
 
 ## [1.0.0-pre.4] - 2022-01-04
 

com.unity.netcode.gameobjects/Runtime/NetworkVariable/Collections/NetworkList.cs

@@ -373,7 +373,7 @@ public void Clear()
         public bool Contains(T item)
         {
             int index = NativeArrayExtensions.IndexOf(m_List, item);
-            return index == -1;
+            return index != -1;
         }
 
         /// <inheritdoc />

com.unity.netcode.gameobjects/Tests/Runtime/NetworkVariableTests.cs

@@ -224,8 +224,8 @@ public IEnumerator NetworkListContains([Values(true, false)] bool useHost)
                 {
                     return m_Player1OnServer.TheList.Count == 1 &&
                            m_Player1OnClient1.TheList.Count == 1 &&
-                           m_Player1OnServer.TheList.Contains(k_TestKey1) &&
-                           m_Player1OnClient1.TheList.Contains(k_TestKey1);
+                           m_Player1OnServer.TheList.Contains(k_TestVal1) &&
+                           m_Player1OnClient1.TheList.Contains(k_TestVal1);
                 }
             );
         }