fix(scene): Fixed not being able to switch scene to currently loaded scene (#229)

Author: jaglitegrann

MLAPI/SceneManagement/NetworkSceneManager.cs

@@ -33,7 +33,7 @@ public static class NetworkSceneManager
         internal static readonly Dictionary<uint, string> sceneIndexToString = new Dictionary<uint, string>();
         internal static readonly Dictionary<Guid, SceneSwitchProgress> sceneSwitchProgresses = new Dictionary<Guid, SceneSwitchProgress>();
         private static Scene lastScene;
-        private static Scene nextScene;
+        private static string nextSceneName;
         private static bool isSwitching = false;
         internal static uint currentSceneIndex = 0;
         internal static Guid currentSceneSwitchProgressGuid = new Guid();
@@ -88,9 +88,8 @@ public static SceneSwitchProgress SwitchScene(string sceneName)
 
             // Switch scene
             AsyncOperation sceneLoad = SceneManager.LoadSceneAsync(sceneName, LoadSceneMode.Single);
-            
-            nextScene = SceneManager.GetSceneByName(sceneName);
-            
+            nextSceneName = sceneName;
+
             sceneLoad.completed += (AsyncOperation asyncOp2) => { OnSceneLoaded(switchSceneProgress.guid, null); };
 
             switchSceneProgress.SetSceneLoadOperation(sceneLoad);  
@@ -121,9 +120,8 @@ internal static void OnSceneSwitch(uint sceneIndex, Guid switchSceneGuid, Stream
             string sceneName = sceneIndexToString[sceneIndex];
 
             AsyncOperation sceneLoad = SceneManager.LoadSceneAsync(sceneName, LoadSceneMode.Single);
-            
-            nextScene = SceneManager.GetSceneByName(sceneName);
-            
+            nextSceneName = sceneName;
+
             sceneLoad.completed += (AsyncOperation asyncOp2) =>
             {
                 OnSceneLoaded(switchSceneGuid, objectStream);
@@ -144,7 +142,7 @@ internal static void OnFirstSceneSwitchSync(uint sceneIndex, Guid switchSceneGui
 
             lastScene = SceneManager.GetActiveScene();
             string sceneName = sceneIndexToString[sceneIndex];
-            nextScene = SceneManager.GetSceneByName(sceneName);
+            nextSceneName = sceneName;
             CurrentActiveSceneIndex = sceneNameToIndex[sceneName];
 
             isSpawnedObjectsPendingInDontDestroyOnLoad = true;
@@ -164,7 +162,8 @@ internal static void OnFirstSceneSwitchSync(uint sceneIndex, Guid switchSceneGui
 
         private static void OnSceneLoaded(Guid switchSceneGuid, Stream objectStream)
         {
-            CurrentActiveSceneIndex = sceneNameToIndex[nextScene.name];
+            CurrentActiveSceneIndex = sceneNameToIndex[nextSceneName];
+            Scene nextScene = SceneManager.GetSceneByName(nextSceneName);
             SceneManager.SetActiveScene(nextScene);
 
             // Move all objects to the new scene