fix: fixed network activity occurring outside the core update getting missed in the profiler (#641)

becksebenius-unity · mattwalsh-unity · web-flow · commit 0786f7bdc5b7 · 2021-03-18T13:03:11.000-07:00
Co-authored-by: Matt Walsh &lt;69258106+mattwalsh-unity@users.noreply.github.com&gt;
diff --git a/com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs b/com.unity.multiplayer.mlapi/Runtime/Core/NetworkManager.cs
@@ -652,6 +652,7 @@ public void NetworkUpdate(NetworkUpdateStage updateStage)
 
         private void OnNetworkEarlyUpdate()
         {
+            NotifyProfilerListeners();
             ProfilerBeginTick();
 
             if (IsListening)
@@ -755,8 +756,6 @@ private void OnNetworkPreUpdate()
                     m_CurrentNetworkTimeOffset += Mathf.Clamp(m_NetworkTimeOffset - m_CurrentNetworkTimeOffset, -maxDelta, maxDelta);
                 }
             }
-
-            NotifyProfilerListeners();
         }
 
         internal void UpdateNetworkTime(ulong clientId, float netTime, float receiveTime, bool warp = false)

Original file line number	Diff line number	Diff line change
`@@ -652,6 +652,7 @@ public void NetworkUpdate(NetworkUpdateStage updateStage)`
`652`	`652`
`653`	`653`	`private void OnNetworkEarlyUpdate()`
`654`	`654`	`{`
	`655`	`+ NotifyProfilerListeners();`
`655`	`656`	`ProfilerBeginTick();`
`656`	`657`
`657`	`658`	`if (IsListening)`
`@@ -755,8 +756,6 @@ private void OnNetworkPreUpdate()`
`755`	`756`	`m_CurrentNetworkTimeOffset += Mathf.Clamp(m_NetworkTimeOffset - m_CurrentNetworkTimeOffset, -maxDelta, maxDelta);`
`756`	`757`	`}`
`757`	`758`	`}`
`758`		`-`
`759`		`- NotifyProfilerListeners();`
`760`	`759`	`}`
`761`	`760`
`762`	`761`	`internal void UpdateNetworkTime(ulong clientId, float netTime, float receiveTime, bool warp = false)`