Fixed dropdowns not opening with the screen reader

Author: Bianca Marina Stana

Assets/Resources/UITk/MainView.uxml

@@ -151,7 +151,7 @@
                                 <UnityEngine.Localization.LocalizedString property="text" table="GUID:cc1d194facb1d9d4380a9ea2032c10ca" entry="Id(17616599150592)"/>
                             </Bindings>
                         </ui:Label>
-                        <ui:Slider high-value="1" name="settingsSoundEffectVolumne">
+                        <ui:Slider high-value="1" name="settingsSoundEffectVolume">
                             <Bindings>
                                 <ui:DataBinding property="value" data-source-path="soundEffectVolume" binding-mode="TwoWay"/>
                                 <UnityEngine.Localization.LocalizedString property="label" table="GUID:cc1d194facb1d9d4380a9ea2032c10ca" entry="Id(17717329555456)"/>

Assets/Scripts/Localization/LocalizedStringList.cs

@@ -32,11 +32,11 @@ protected override BindingResult Update(in BindingContext context)
             var element = context.targetElement;
             var result = GetLocalizedString();
             var resultArray = result.Split(separator, System.StringSplitOptions.RemoveEmptyEntries).ToList();
+            var index = -1;
 
-            int index = -1;
-            if (element is DropdownField)
+            if (element is DropdownField dropdownField)
             {
-                index = ((DropdownField)element).index;
+                index = dropdownField.index;
             }
 
             if (ConverterGroups.TrySetValueGlobal(ref element, context.bindingId, resultArray, out var errorCode))

Assets/Scripts/Screen Reader/UITk/Handlers/BasePopupFieldHandler.cs

@@ -1,4 +1,3 @@
-using Unity.Samples.LetterSpell;
 using UnityEngine.Accessibility;
 using UnityEngine.Scripting;
 using UnityEngine.UIElements;
@@ -14,8 +13,6 @@ public BasePopupFieldHandler()
         {
             selected += () =>
             {
-                ownerElement.schedule.Execute(CheckForOpenedPopupMenu).ExecuteLater(300);
-
                 using var evt = NavigationSubmitEvent.GetPooled();
                 evt.target = ownerElement;
                 ownerElement.SendEvent(evt);
@@ -98,9 +95,10 @@ void CheckForOpenedPopupMenu()
                    // if (item.GetAccessibleProperties() != null)
                    //     continue;
 
-                    var itemAcc = item.GetOrCreateAccessibleProperties();
                     var itemLabel = item.Q<Label>();
+                    itemLabel.GetOrCreateAccessibleProperties().ignored = true;
 
+                    var itemAcc = item.GetOrCreateAccessibleProperties();
                     itemAcc.label = itemLabel != null ? itemLabel.text : $"Item {i}";
                     itemAcc.role = AccessibilityRole.Button;
                     itemAcc.state = item.hasCheckedPseudoState ? AccessibilityState.Selected : AccessibilityState.None;
@@ -113,8 +111,6 @@ void CheckForOpenedPopupMenu()
                         return true;
                     };
 
-                    itemLabel.GetOrCreateAccessibleProperties().ignored = true;
-
                     i++;
                 }
 

Assets/Scripts/Screen Reader/UITk/Handlers/DropdownFieldHandler.cs

@@ -1,4 +1,3 @@
-using Unity.Samples.LetterSpell;
 using UnityEngine.Accessibility;
 using UnityEngine.Scripting;
 using UnityEngine.UIElements;
@@ -14,8 +13,6 @@ public DropdownFieldHandler()
         {
             selected += () =>
             {
-                ownerElement.schedule.Execute(CheckForOpenedPopupMenu).ExecuteLater(300);
-
                 using var evt = NavigationSubmitEvent.GetPooled();
                 evt.target = ownerElement;
                 ownerElement.SendEvent(evt);
@@ -98,9 +95,10 @@ void CheckForOpenedPopupMenu()
                    // if (item.GetAccessibleProperties() != null)
                    //     continue;
 
-                    var itemAcc = item.GetOrCreateAccessibleProperties();
                     var itemLabel = item.Q<Label>();
+                    itemLabel.GetOrCreateAccessibleProperties().ignored = true;
 
+                    var itemAcc = item.GetOrCreateAccessibleProperties();
                     itemAcc.label = itemLabel != null ? itemLabel.text : $"Item {i}";
                     itemAcc.role = AccessibilityRole.Button;
                     itemAcc.state = item.hasCheckedPseudoState ? AccessibilityState.Selected : AccessibilityState.None;
@@ -113,8 +111,6 @@ void CheckForOpenedPopupMenu()
                         return true;
                     };
 
-                    itemLabel.GetOrCreateAccessibleProperties().ignored = true;
-
                     i++;
                 }
 

Assets/Scripts/Screen Reader/UITk/Handlers/VisualElementAccessibilityHandler.cs

@@ -126,10 +126,8 @@ public bool isModal
             }
         }
 
-        public virtual bool IsModal()
-        {
-            return ownerElement != null && ownerElement.ClassListContains(GenericDropdownMenu.ussClassName);
-        }
+        public virtual bool IsModal() => ownerElement != null &&
+            ownerElement.ClassListContains(GenericDropdownMenu.ussClassName);
 
         public string label
         {