Stepanov/multi dim array fix (#202)

* Creation of multidimensional arrays fixed
* minor
* Rewrite toString() method for JcNewArray and JcRawNewArray

Author: DaniilStepanov

jacodb-api/src/main/kotlin/org/jacodb/api/cfg/JcInst.kt

@@ -606,11 +606,22 @@ data class JcNewArrayExpr(
     override val operands: List<JcValue>
         get() = dimensions
 
-    override fun toString(): String = "new ${type.typeName}${dimensions.joinToString("") { "[$it]" }}"
+    override fun toString(): String = "new ${arrayTypeToStringWithDimensions(type.typeName, dimensions)}"
 
     override fun <T> accept(visitor: JcExprVisitor<T>): T {
         return visitor.visitJcNewArrayExpr(this)
     }
+
+    companion object {
+        private val regexToProcessDimensions = Regex("\\[(.*?)]")
+
+        private fun arrayTypeToStringWithDimensions(typeName: String, dimensions: List<JcValue>) {
+            var curDim = 0
+            regexToProcessDimensions.replace(typeName) {
+                "[${dimensions.getOrNull(curDim++) ?: ""}]"
+            }
+        }
+    }
 }
 
 data class JcInstanceOfExpr(

jacodb-api/src/main/kotlin/org/jacodb/api/cfg/JcRawInst.kt

@@ -609,11 +609,22 @@ data class JcRawNewArrayExpr(
     override val operands: List<JcRawValue>
         get() = dimensions
 
-    override fun toString(): String = "new $typeName${dimensions.joinToString("") { "[$it]" }}"
+    override fun toString(): String = "new ${arrayTypeToStringWithDimensions(typeName, dimensions)}"
 
     override fun <T> accept(visitor: JcRawExprVisitor<T>): T {
         return visitor.visitJcRawNewArrayExpr(this)
     }
+    
+    companion object {
+        private val regexToProcessDimensions = Regex("\\[(.*?)]")
+
+        private fun arrayTypeToStringWithDimensions(typeName: TypeName, dimensions: List<JcRawValue>) {
+            var curDim = 0
+            regexToProcessDimensions.replace("$typeName") {
+                "[${dimensions.getOrNull(curDim++) ?: ""}]"
+            }
+        }
+    }
 }
 
 data class JcRawInstanceOfExpr(

jacodb-core/src/main/kotlin/org/jacodb/impl/cfg/RawInstListBuilder.kt

@@ -1489,7 +1489,7 @@ class RawInstListBuilder(
         repeat(insnNode.dims) {
             dimensions += pop()
         }
-        val expr = JcRawNewArrayExpr(insnNode.desc.typeName(), dimensions)
+        val expr = JcRawNewArrayExpr(insnNode.desc.typeName(), dimensions.reversed())
         val assignment = nextRegister(expr.typeName)
         addInstruction(insnNode, JcRawAssignInst(method, assignment, expr))
         push(assignment)