Skip to content

KAN-10: Fix Silent Failures in Student Scheduling #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
danieloo0 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

KAN-10: Fix Silent Failures in Student Scheduling #232

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions JavaSource/org/unitime/timetable/action/StudentSchedulingAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,9 @@ public String execute() throws Exception {
}
}
}
} catch (SectioningException e) {}
} catch (SectioningException e) {
log.warn("SectioningException while listing academic sessions", e);
}
if (preferredAuthority == null && sessionContext.getUser().getCurrentAuthority() != null) {
for (UserAuthority auth: sessionContext.getUser().getAuthorities(null, sessionContext.getUser().getCurrentAuthority().getAcademicSession())) {
if (preferredAuthority == null && Roles.ROLE_STUDENT.equals(auth.getRole())) {
Expand Down Expand Up @@ -222,7 +224,9 @@ public String execute() throws Exception {
return null;
}
}
} catch (SectioningException e) {}
} catch (SectioningException e) {
log.warn("SectioningException while listing academic sessions", e);
}
// 2. Scheduling Assistant with the enrollment enabled
try {
for (AcademicSessionInfo session: service.listAcademicSessions(true)) {
Expand All @@ -239,7 +243,9 @@ public String execute() throws Exception {
return null;
}
}
} catch (SectioningException e) {}
} catch (SectioningException e) {
log.warn("SectioningException while listing academic sessions", e);
}
} else {
// 1. Scheduling Assistant with the enrollment enabled
try {
Expand All @@ -257,7 +263,9 @@ public String execute() throws Exception {
return null;
}
}
} catch (SectioningException e) {}
} catch (SectioningException e) {
log.warn("SectioningException while listing academic sessions", e);
}
// 2. Course Requests with the registration enabled
try {
for (AcademicSessionInfo session: service.listAcademicSessions(false)) {
Expand Down Expand Up @@ -285,7 +293,9 @@ public String execute() throws Exception {
return null;
}
}
} catch (SectioningException e) {}
} catch (SectioningException e) {
log.warn("SectioningException while listing academic sessions", e);
}

// 4. Course Requests
try {
Expand All @@ -295,7 +305,9 @@ public String execute() throws Exception {
return null;
}
}
} catch (SectioningException e) {}
} catch (SectioningException e) {
log.warn("SectioningException while listing academic sessions", e);
}

// 5. Main page fallback
return "main";
Expand Down