Support project references by forcing target dependency to ensure it is updated/set BEFORE the target to retrieve it is run. (#81)

This Fixes #79

Though a new test bug should be filed to account for the shortcomings of the tests (See #80)

Author: smaillet

src/Ubiquity.NET.Versioning.Build.Tasks.UT/BuildTaskTests.cs

@@ -544,6 +544,36 @@ static FileVersionQuad ExpectedFileVersion( bool isPreRelease, bool isCiBuild )
             }
         }
 
+        [TestMethod]
+        [DataRow("netstandard2.0")]
+        [DataRow("net48")]
+        [DataRow("net8.0")]
+        public void Projects_with_project_references_create_proper_dependencies_in_nuspec( string targetFramework )
+        {
+            // This tests for a fix to https://github.com/UbiquityDotNET/CSemVer.GitBuild/issues/79
+            // Currently this is a bit of a hack to move things along elsewhere.
+            // for now, hack this and specifically look for the solution that is at least known to work at this point.
+            var globalProperties = new Dictionary<string, string>
+            {
+                [PropertyNames.BuildMajor] = "1",
+                [PropertyNames.BuildMinor] = "2",
+                [PropertyNames.BuildPatch] = "3",
+                [PropertyNames.PreReleaseName] = "delta",
+            };
+
+            using var collection = new ProjectCollection(globalProperties);
+            using var fullResults = Context.CreateTestProjectAndInvokeTestedPackage(targetFramework, collection);
+            var prop = fullResults.BuildResults.Creator.Project.GetProperty("GetPackageVersionDependsOn");
+            Assert.IsTrue(prop.EvaluatedValue.Contains("PrepareVersioningForBuild", StringComparison.Ordinal));
+
+            // A full solution would:
+            // Create a project (dependentProj)
+            //     - Should generate a NuGetPackage
+            // Create a project (testProj) that has a project reference for 'dependentProj'
+            // pack testProj
+            // look into generated nupkg to ensure dependency for dependentProj has correct version (and NOT the default 1.0.0)
+        }
+
         private static IEnumerable<PrereleaseTestData> GetPrereleaseTestData()
         {
             return from tfm in TargetFrameworks

src/Ubiquity.NET.Versioning.Build.Tasks/build/Ubiquity.NET.Versioning.Build.Tasks.targets

@@ -3,6 +3,14 @@
         <_TaskFolder Condition=" '$(MSBuildRuntimeType)' == 'Core' ">tasks\netstandard2.0\</_TaskFolder>
         <_TaskFolder Condition=" '$(MSBuildRuntimeType)' != 'Core' ">tasks\net48\</_TaskFolder>
         <_Ubiquity_NET_Versioning_Build_Tasks>$([MSBuild]::NormalizePath($(MSBuildThisFileDirectory)..\$(_TaskFolder)Ubiquity.NET.Versioning.Build.Tasks.dll))</_Ubiquity_NET_Versioning_Build_Tasks>
+        <!--
+        Force target dependency for tasks that use this package. If a project contains references to another project then
+        the NuGet tasks will call a task that uses this in the referenced project. The actual task is currently
+        `_GetProjectVersion` but that is not formally documented and subject to change. (This property isn't formally
+        documented either but at least it doesn't have the leading underscore to indicate it is intended as private/internal
+        and does have some hits on a search) see: https://github.com/UbiquityDotNET/CSemVer.GitBuild/issues/79
+        -->
+        <GetPackageVersionDependsOn>$(GetPackageVersionDependsOn);PrepareVersioningForBuild</GetPackageVersionDependsOn>
     </PropertyGroup>
 
     <!--
@@ -21,7 +29,7 @@
     <UsingTask TaskName="ParseBuildVersionXml" AssemblyFile="$(_Ubiquity_NET_Versioning_Build_Tasks)"/>
 
     <Target Name="PrepareVersioningForBuild"
-            BeforeTargets="PrepareForBuild;_IntermediatePack"
+            BeforeTargets="PrepareForBuild"
             DependsOnTargets="GetRepositoryInfo;VerifyProvidedBuildVersion;SetVersionDependentProperties;"
             />