From 51fdf3b12512c8b55d6d1aeb4351fba16917237c Mon Sep 17 00:00:00 2001 From: Matthias Osswald Date: Wed, 3 Jun 2026 15:45:43 +0200 Subject: [PATCH] fix: Make plugin.json prettier-stable after release-please bumps MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit release-please's JSON updater re-stringifies the file with JSON.stringify(obj, null, indent), which always expands arrays to multi-line. The inline "skills": ["./skills/"] in plugin.json was therefore reformatted to multi-line on every release, and the subsequent prettier:check failed because prettier collapsed it again. Switch the prettier parser to json-stringify for **/plugin.json (same parser prettier already uses for package.json), which keeps every array multi-line — matching what release-please produces. Reformat the four plugin.json files in source so the check passes today. --- .prettierrc | 10 +++++++++- .../.github/plugin/plugin.json | 4 +++- plugins/ui5-typescript-conversion/plugin.json | 4 +++- plugins/ui5/.github/plugin/plugin.json | 4 +++- plugins/ui5/plugin.json | 4 +++- 5 files changed, 21 insertions(+), 5 deletions(-) diff --git a/.prettierrc b/.prettierrc index 87cf9d6..e5f804d 100644 --- a/.prettierrc +++ b/.prettierrc @@ -2,5 +2,13 @@ "trailingComma": "es5", "tabWidth": 4, "semi": false, - "singleQuote": false + "singleQuote": false, + "overrides": [ + { + "files": ["**/plugin.json"], + "options": { + "parser": "json-stringify" + } + } + ] } diff --git a/plugins/ui5-typescript-conversion/.github/plugin/plugin.json b/plugins/ui5-typescript-conversion/.github/plugin/plugin.json index 44ef34d..5fc0dc0 100644 --- a/plugins/ui5-typescript-conversion/.github/plugin/plugin.json +++ b/plugins/ui5-typescript-conversion/.github/plugin/plugin.json @@ -17,5 +17,7 @@ "typescript", "conversion" ], - "skills": ["./skills/"] + "skills": [ + "./skills/" + ] } diff --git a/plugins/ui5-typescript-conversion/plugin.json b/plugins/ui5-typescript-conversion/plugin.json index 44ef34d..5fc0dc0 100644 --- a/plugins/ui5-typescript-conversion/plugin.json +++ b/plugins/ui5-typescript-conversion/plugin.json @@ -17,5 +17,7 @@ "typescript", "conversion" ], - "skills": ["./skills/"] + "skills": [ + "./skills/" + ] } diff --git a/plugins/ui5/.github/plugin/plugin.json b/plugins/ui5/.github/plugin/plugin.json index 0eacb94..f4f2d63 100644 --- a/plugins/ui5/.github/plugin/plugin.json +++ b/plugins/ui5/.github/plugin/plugin.json @@ -19,5 +19,7 @@ "development-guidelines", "best-practices" ], - "skills": ["./skills/"] + "skills": [ + "./skills/" + ] } diff --git a/plugins/ui5/plugin.json b/plugins/ui5/plugin.json index 0eacb94..f4f2d63 100644 --- a/plugins/ui5/plugin.json +++ b/plugins/ui5/plugin.json @@ -19,5 +19,7 @@ "development-guidelines", "best-practices" ], - "skills": ["./skills/"] + "skills": [ + "./skills/" + ] }