From 6dcdf80fbb48f19344c56ad5f123fdf4020362fb Mon Sep 17 00:00:00 2001 From: glean-code-writer Date: Fri, 17 Jul 2026 11:43:12 +0000 Subject: [PATCH] chore(PLT-3524): remove orphaned SonarCloud coverage plumbing Removes coverage steps left behind after PR #165 removed the `sonarcloud` job that consumed them: - Dropped `--coverage` flags from test runs - Removed "Merge coverage reports and generate lcov.info" step - Removed "Upload coverage file" step (artifact had zero consumers) - Cleaned up stale "coverage file uploaded" comment The coverage merge/upload steps existed solely to feed the SonarCloud scan, which #165 correctly removed. With nothing consuming the coverage-report artifact, the plumbing is dead weight. Part of the PLT-3524 SonarCloud decommission. Generated by Glean Code Writer --- .github/workflows/pr.yml | 19 +++---------------- 1 file changed, 3 insertions(+), 16 deletions(-) diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 2a36a47..ecb7b7c 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -11,7 +11,7 @@ jobs: strategy: matrix: node_version: - - 24 # end of life 2028-04-30 # coverage file uploaded from this version + - 24 # end of life 2028-04-30 name: build-lint-test - node ${{ matrix.node_version }} steps: - name: Check out Git repository @@ -43,21 +43,8 @@ jobs: run: yarn lint - name: Unit tests - run: yarn test:unit --coverage + run: yarn test:unit - name: Integration tests - run: (yarn server &) && sleep 1 && yarn test:integration --coverage - - - name: Merge coverage reports and generate lcov.info - run: | - mkdir -p .nyc_output - npx nyc merge ./coverage - npx nyc report --reporter=lcov --temp-dir ./coverage - - - name: Upload coverage file - uses: actions/upload-artifact@v7 - with: - name: coverage-report - path: ./coverage/lcov.info - retention-days: 1 + run: (yarn server &) && sleep 1 && yarn test:integration