From 2a5bf5c82b5ed5205a97e92965ac2fda9f056a1c Mon Sep 17 00:00:00 2001 From: Sourcegraph Date: Wed, 15 Jul 2026 13:06:01 +0000 Subject: [PATCH 1/3] chore(PLT-3524): remove SonarCloud setup --- .github/workflows/pull-request.yml | 9 --------- sonar-project.properties | 12 ------------ 2 files changed, 21 deletions(-) delete mode 100644 sonar-project.properties diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 9c254fbb..4d0aff3c 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -42,15 +42,6 @@ jobs: - name: Verify coverage file ready run: find . | grep coverage - - name: SonarCloud Scan - uses: SonarSource/sonarqube-scan-action@v7 - with: - args: > - "-Dsonar.projectVersion=${{ github.run_id }}" - env: - GITHUB_TOKEN: ${{ secrets.GH_TOKEN }} - SONAR_TOKEN: ${{ secrets.SONAR_CLOUD_TOKEN }} - LC_ALL: 'C.UTF-8' functional: runs-on: ubuntu-latest diff --git a/sonar-project.properties b/sonar-project.properties deleted file mode 100644 index 69c84aae..00000000 --- a/sonar-project.properties +++ /dev/null @@ -1,12 +0,0 @@ -sonar.projectKey=Typeform_embed -sonar.organization=typeform -sonar.projectVersion=dev - -sonar.sources=packages - -sonar.inclusions=packages/*/src/**/*.ts,src/**/*.js -sonar.exclusions=node_modules/**,dist/**,**/*.spec.ts,**/*.test.ts - -sonar.test.exclusions=node_modules/**,dist/** - -sonar.javascript.lcov.reportPaths=packages/**/coverage/lcov.info From c2c938d62167c554a1b90232e4b572ba97e4b4a9 Mon Sep 17 00:00:00 2001 From: glean-code-writer Date: Thu, 16 Jul 2026 09:37:20 +0000 Subject: [PATCH 2/3] Remove remaining SonarCloud reference from workflow comment Generated by Glean Code Writer --- .github/workflows/pull-request.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/pull-request.yml b/.github/workflows/pull-request.yml index 4d0aff3c..910c9121 100644 --- a/.github/workflows/pull-request.yml +++ b/.github/workflows/pull-request.yml @@ -10,7 +10,7 @@ jobs: strategy: matrix: node_version: - - 24 # end of life 2028-04-30 # used in SonarCloud scan + - 24 # end of life 2028-04-30 name: build-lint-test - node ${{ matrix.node_version }} steps: - name: Check out Git repository From c7452b08185d2083226294f88647a649be3447e6 Mon Sep 17 00:00:00 2001 From: promiseNwafor Date: Fri, 17 Jul 2026 12:20:41 +0100 Subject: [PATCH 3/3] fix: update test --- packages/embed/e2e/spec/functional/widget-newui.cy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/embed/e2e/spec/functional/widget-newui.cy.ts b/packages/embed/e2e/spec/functional/widget-newui.cy.ts index 2800c3fd..9b6e25ed 100644 --- a/packages/embed/e2e/spec/functional/widget-newui.cy.ts +++ b/packages/embed/e2e/spec/functional/widget-newui.cy.ts @@ -55,7 +55,7 @@ function testMobile(path: string, title: string) { it('should reset the form when closing it', () => { cy.get('iframe').then(($iframe) => { const $body = $iframe.contents().find('body') - cy.wrap($body).find('[data-qa="ok-button"]').click() + cy.wrap($body).find('[data-qa="ok-button"]').click({ force: true }) cy.get('.tf-v1-widget-close').click() }) cy.wait(1000)