diff --git a/apps/desktop/e2e/code-review-regressions.spec.ts b/apps/desktop/e2e/code-review-regressions.spec.ts index 2c121627..d5eb5591 100644 --- a/apps/desktop/e2e/code-review-regressions.spec.ts +++ b/apps/desktop/e2e/code-review-regressions.spec.ts @@ -283,3 +283,32 @@ test("local Changes stay local: a remote PR touching the same path never reaches file: fs.readFileSync(path.join(repo, "src", "holds", "move.ts"), "utf8") }).toEqual(before); expect(h.calls().filter((c) => !READ_ENDPOINT.test(c))).toEqual([]); }); + +test("real use (F3): comments on lines of the diff are shown in Activity with their file and line, under the Comments filter, as inert text", async () => { + const world = baseWorld(); + const who = { id: 3003, login: "bea-fixture", type: "User" }; + // The base world lists no timeline: an empty one lets the activity read finish. + world.routes["repos/example-org/lending/issues/73/timeline"] = []; + world.routes["repos/example-org/lending/deployments"] = []; + world.routes["repos/example-org/lending/pulls/73/comments"] = [ + { id: 801, user: who, created_at: "2026-10-18T20:31:00Z", body: "Should this keep the position when the branch is closed?\n\n", path: "src/holds/move.ts", line: 41, side: "RIGHT" }, + { id: 802, user: who, created_at: "2026-10-18T20:32:00Z", body: "It does; see the closure test.", path: "src/holds/move.ts", line: 41, side: "RIGHT", in_reply_to_id: 801 }, + { id: 803, user: who, created_at: "2026-10-18T20:33:00Z", body: "This helper is gone now.", path: "src/holds/queue.ts", line: null, side: "LEFT" }, + ]; + h = await launchWithGh(world); + const { page } = h; + await tid(page, "rail-code-review").click(); + await prRow(page, "example-org/lending#73").click(); + const activity = tid(page, "cr-activity"); + const item = (id: number) => activity.locator(`[data-activity-id="line-comment:${id}"]`); + await expect(item(801)).toContainText("commented on src/holds/move.ts · line 41"); + await expect(item(801)).toContainText("Should this keep the position when the branch is closed?"); + await expect(item(802)).toContainText("replied on src/holds/move.ts · line 41"); + await expect(item(803)).toContainText("commented on src/holds/queue.ts · line no longer in the diff"); + await page.getByLabel("Activity filter").selectOption("comment"); + await expect(activity.locator('[data-activity-id^="line-comment:"]')).toHaveCount(3); + await expect(activity.locator('[data-activity-id^="commit:"]')).toHaveCount(0); + expect(await page.evaluate(() => (window as unknown as { __pwned?: boolean }).__pwned)).toBeUndefined(); + expect(h.calls().filter((c) => c.startsWith("repos/example-org/lending/pulls/73/comments"))).toEqual(["repos/example-org/lending/pulls/73/comments?per_page=100&page=1"]); + expect(h.calls().filter((c) => !READ_ENDPOINT.test(c) && !c.startsWith("repos/example-org/lending/deployments?"))).toEqual([]); +}); diff --git a/apps/desktop/e2e/code-review-support.ts b/apps/desktop/e2e/code-review-support.ts index 03ae5039..3d9bb5cd 100644 --- a/apps/desktop/e2e/code-review-support.ts +++ b/apps/desktop/e2e/code-review-support.ts @@ -120,7 +120,7 @@ export const prRow = (p: Page, slug: string) => p.locator(`[data-testid="code-re export const settle = (p: Page) => p.evaluate(() => window.modex!.invoke("code-review:read", { op: "connection", requestId: `settle-${Date.now()}` })); /** Every endpoint the read service may ask for (docs/design/code-review.md, Read operations). */ -export const READ_ENDPOINT = /^(user|search\/issues\?[^/]+|repos\/[A-Za-z0-9._-]+\/[A-Za-z0-9._-]+(\/(pulls(\/\d+(\/files)?)?|compare\/[0-9a-f]{40}\.\.\.[0-9a-f]{40}|issues\/\d+\/timeline|commits\/[0-9a-f]{40}\/(check-runs|status)|contents\/[^?]+))?(\?[^/]*)?)$/; +export const READ_ENDPOINT = /^(user|search\/issues\?[^/]+|repos\/[A-Za-z0-9._-]+\/[A-Za-z0-9._-]+(\/(pulls(\/\d+(\/(files|comments))?)?|compare\/[0-9a-f]{40}\.\.\.[0-9a-f]{40}|issues\/\d+\/timeline|commits\/[0-9a-f]{40}\/(check-runs|status)|contents\/[^?]+))?(\?[^/]*)?)$/; /** * resizeWindow, but within the display. These launches can't set MODEX_E2E (it disables the read service), so diff --git a/apps/desktop/src/main/engine/code-review/github.ts b/apps/desktop/src/main/engine/code-review/github.ts index 4cb420f5..5bc46855 100644 --- a/apps/desktop/src/main/engine/code-review/github.ts +++ b/apps/desktop/src/main/engine/code-review/github.ts @@ -191,6 +191,16 @@ export function hasNext(header: string | undefined): boolean { return typeof header === "string" && /<[^>]+>;\s*rel="next"/.test(header); } +/** One comment on a line of the diff, from `pulls/{n}/comments`. Null when malformed. */ +export function lineComment(value: unknown): Extract | null { + const item = object(value); + const commentId = id(item?.id), at = time(item?.created_at), who = actor(item?.user); + if (!item || !commentId || !at || !who || typeof item.path !== "string" || !item.path || item.path.length > 4096) return null; + const line = count(item.line) || null; + return { kind: "line-comment", id: commentId, at, actor: who, body: text(item.body, 262_144), path: item.path, line, + side: item.side === "LEFT" ? "LEFT" : "RIGHT", replyTo: id(item.in_reply_to_id) }; +} + /** Provider deployment + its latest status; a comment URL never enters this mapping. */ export function deployment(value: unknown, latest: unknown): Extract | null { const record = object(value), status = object(latest); diff --git a/apps/desktop/src/main/engine/code-review/read-service.ts b/apps/desktop/src/main/engine/code-review/read-service.ts index 55c379e0..804e13d7 100644 --- a/apps/desktop/src/main/engine/code-review/read-service.ts +++ b/apps/desktop/src/main/engine/code-review/read-service.ts @@ -4,7 +4,7 @@ import { type PrStack, type PrActivity, type PrCheck, type PrContext, type PrFiles, type PrKey, type PrOverview, type PrRevision, type PrSummary, type ReadResult, type ResolvedPr, type Unavailable, } from "../../../shared/code-review.js"; import { ghHostsStamp, ghTransport, type GhAnswer, type GhCall, type GhTransport } from "./gh.js"; -import { deployment, changedFile, checkRun, commitStatus, hasNext, json, pull, repository, searchRow, timeline, type Pull, type Repository } from "./github.js"; +import { deployment, lineComment, changedFile, checkRun, commitStatus, hasNext, json, pull, repository, searchRow, timeline, type Pull, type Repository } from "./github.js"; /** * Main's Code Review reads (#321): narrow GETs through the person's `gh` login, each bound to the @@ -794,9 +794,10 @@ export class CodeReviewService { if (pr) { activity.unshift({ kind: "opened", id: `pr-${pr.id}`, at: pr.createdAt, actor: pr.author }); // Asked only once the timeline has arrived: a failed timeline costs GitHub no further request. - const read = await this.deployments(context, key, pr); - activity.push(...read.records); - deploymentFailure = read.failure; + // Line comments are not in the timeline; they are their own list. Both reads run together. + const [read, comments] = await Promise.all([this.deployments(context, key, pr), this.lineComments(context, key)]); + activity.push(...read.records, ...comments.records); + deploymentFailure = read.failure ?? comments.failure; } const more = hasNext(fetched.headers.link); const next = more && number < TIMELINE_PAGES ? `p${number + 1}` : null; @@ -809,6 +810,30 @@ export class CodeReviewService { return { state: "ready", value: activity, fetchedAt, coverage }; } + /** + * The first page of comments on lines of the diff (100, oldest first). A failure is reported, not thrown, + * unless the read was cancelled or the account is gone; more than one page is reported as capped. + */ + private async lineComments(context: Context, key: PrKey): Promise<{ records: PrActivity[]; failure: Unavailable | "capped" | null }> { + const records: PrActivity[] = []; + let failure: Unavailable | "capped" | null = null; + try { + const fetched = await this.get(context, `${repoPath(this.repoFor(key))}/pulls/${key.number}/comments?per_page=${PAGE}&page=1`, { maxBytes: 8 * MB }); + const listed: unknown = json(fetched.body); + if (!Array.isArray(listed)) throw new ReadFailure("failed", DETAIL.failed); + if (hasNext(fetched.headers.link)) failure = "capped"; + for (const item of listed.slice(0, PAGE)) { + const mapped = lineComment(item); + if (mapped) records.push(mapped); else failure = "failed"; + } + } catch (error) { + const caught = this.failure(error); + if (caught.cancelled || caught.reason === "signed-out") throw error; + failure = caught.reason; + } + return { records, failure }; + } + /** * A bounded current-head preview read, independent of arbitrary links in bot comments. Endpoint strings are * built from main's repository and numeric provider IDs only. A failure is reported, not thrown, unless the diff --git a/apps/desktop/src/renderer/code-review/PrOverview.tsx b/apps/desktop/src/renderer/code-review/PrOverview.tsx index e05c1b87..d8334daa 100644 --- a/apps/desktop/src/renderer/code-review/PrOverview.tsx +++ b/apps/desktop/src/renderer/code-review/PrOverview.tsx @@ -1,5 +1,5 @@ import { useState, useRef, useLayoutEffect, type ReactNode } from "react"; -import { prKeyId, summarizeChecks, type Capabilities, type Capability, type PrActivity, type PrLocator, type ReadResult } from "../../shared/code-review.js"; +import { prKeyId, summarizeChecks, type Capabilities, type PrActivity, type PrLocator, type ReadResult } from "../../shared/code-review.js"; import { activityPages, externalDestination, stackOrder } from "../../shared/code-review-overview.js"; import { bridge } from "../bridge"; import { Menu, MenuItem } from "../components/ui/Menu"; @@ -15,12 +15,6 @@ import { EditPullRequest, RequestReviewers } from "./PrActions"; import type { Agent } from "./agent.js"; import { AgentReview } from "./AgentReview"; -/** Explicit action boundary for CR-7. No draft or successful submission is invented here. */ -export interface OverviewActions { edit?: () => void; requestReviewers?: () => void; comment?: () => void } -function Action({ label, capability, action }: { label: string; capability: Capability; action?: () => void }) { - const available = capability.available && !!action; - return ; -} function Evidence({ result, label, retry }: { result: ReadResult | undefined; label: string; retry: () => void }) { if (!result) return

Loading {label}…

; if (result.state === "unavailable") return ; @@ -44,7 +38,7 @@ function usePosition(id: string) { }, [id]); return ref; } -export function PrOverview({ pr, caps, retry, onChanges, onPage, busy, actions = {}, writes, agent }: { pr: OpenPr; caps: Capabilities; retry: () => void; onChanges: () => void; onPage: (cursor: string | null) => void; busy: ReadonlySet; actions?: OverviewActions; writes?: Writes; agent?: Agent }) { +export function PrOverview({ pr, caps, retry, onChanges, onPage, busy, writes, agent }: { pr: OpenPr; caps: Capabilities; retry: () => void; onChanges: () => void; onPage: (cursor: string | null) => void; busy: ReadonlySet; writes: Writes; agent?: Agent }) { const main = usePosition(`${prKeyId(pr.key)}:content`); const sidebar = usePosition(`${prKeyId(pr.key)}:details`); const read = pr.overview; @@ -67,7 +61,7 @@ export function PrOverview({ pr, caps, retry, onChanges, onPage, busy, actions = } const activity = activityPages(pages); const pageFailed = pages.at(-1)?.state === "unavailable"; - const rows = activity.rows.filter(row => filter === "all" || row.kind === filter); + const rows = activity.rows.filter(row => filter === "all" || row.kind === filter || (filter === "comment" && row.kind === "line-comment")); const grouped: PrActivity[][] = []; for (const row of rows) { const last = grouped.at(-1); @@ -83,7 +77,7 @@ export function PrOverview({ pr, caps, retry, onChanges, onPage, busy, actions =

{overview.title}

-
{overview.author.login} opened
{overview.headRepo ? `${overview.headRepo}:` : ""}{overview.headRef} → {overview.revision.baseRef}{writes ? : }
+
{overview.author.login} opened
{overview.headRepo ? `${overview.headRepo}:` : ""}{overview.headRef} → {overview.revision.baseRef}
{agent && writes && } @@ -95,14 +89,13 @@ export function PrOverview({ pr, caps, retry, onChanges, onPage, busy, actions = {pr.activityRefreshing &&

Refreshing activity · Earlier pages remain provisional.

} {activity.complete && !pr.activityRefreshing ?

{activity.rows.length ? "All activity loaded" : "No activity"}{filter !== "all" && rows.length === 0 ? " · No matching activity" : ""}

:

{activity.rows.length} activity items loaded · More activity may be missing.

} {activity.next && } - {writes ? - :

Comment on this pull request

{!caps.comment.available && caps.comment.reason}

} +
@@ -110,8 +103,9 @@ export function PrOverview({ pr, caps, retry, onChanges, onPage, busy, actions = } function Activity({ row, locator, currentHead, onAsk }: { row: PrActivity; locator?: PrLocator; currentHead?: string; onAsk?: (text: string) => void }) { return
-
{row.kind === "comment" && locator && }{row.kind === "deployment" ? row.environment : row.kind === "commit" ? row.author?.login ?? "Git author" : row.actor?.login ?? "GitHub"}{row.kind === "commit" ? "committed" : row.kind === "opened" ? "opened this pull request" : row.kind === "review" ? `reviewed · ${row.verdict}` : row.kind === "event" ? row.event : row.kind === "deployment" ? `provider deployment · ${row.status}` : "issue comment"}
+
{row.kind === "comment" && locator && }{row.kind === "deployment" ? row.environment : row.kind === "commit" ? row.author?.login ?? "Git author" : row.actor?.login ?? "GitHub"}{row.kind === "commit" ? "committed" : row.kind === "opened" ? "opened this pull request" : row.kind === "line-comment" ? `${row.replyTo ? "replied" : "commented"} on ${row.path}${row.line ? ` · line ${row.line}${row.side === "LEFT" ? " (before)" : ""}` : " · line no longer in the diff"}` : row.kind === "review" ? `reviewed · ${row.verdict}` : row.kind === "event" ? row.event : row.kind === "deployment" ? `provider deployment · ${row.status}` : "issue comment"}
{row.kind === "commit" &&

{row.sha.slice(0, 8)} {row.headline}

} + {row.kind === "line-comment" && <>

Comment on a line · Whether its thread is resolved is not shown.

} {(row.kind === "comment" || row.kind === "review") && <>

{row.kind === "comment" ? "Comment content · Links and status claims are supplied by the commenter, not verified deployment evidence." : `Submitted review · revision ${row.commit?.slice(0, 8) ?? "unknown"}`}

} {row.kind === "deployment" &&

Provider record · revision {row.commit.slice(0, 8)}{currentHead && row.commit !== currentHead ? " · Old revision" : ""} · Open deployment

}
; diff --git a/apps/desktop/src/renderer/code-review/PrPane.tsx b/apps/desktop/src/renderer/code-review/PrPane.tsx index 66ea0cb9..47a09a79 100644 --- a/apps/desktop/src/renderer/code-review/PrPane.tsx +++ b/apps/desktop/src/renderer/code-review/PrPane.tsx @@ -34,7 +34,7 @@ interface Props { contextBusy: ReadonlySet; onTreeResize: (width: number) => void; onTreeReset: () => void; - writes?: Writes; + writes: Writes; agent?: Agent; } diff --git a/apps/desktop/src/shared/code-review.ts b/apps/desktop/src/shared/code-review.ts index aa9631a2..7bcd4983 100644 --- a/apps/desktop/src/shared/code-review.ts +++ b/apps/desktop/src/shared/code-review.ts @@ -115,6 +115,8 @@ export type PrActivity = | { kind: "commit"; id: string; at: string; sha: string; headline: string; author: PrActor | null } | { kind: "opened"; id: string; at: string; actor: PrActor } | { kind: "comment"; id: string; at: string; actor: PrActor; /** Untrusted Markdown, like `PrOverview.body`. */ body: string } + /** A comment on a line of the diff (GitHub's review comment). `line` is null once the line is no longer in the diff. `replyTo` is the comment it answers. Whether its thread is resolved is not read. */ + | { kind: "line-comment"; id: string; at: string; actor: PrActor; body: string; path: string; line: number | null; side: "LEFT" | "RIGHT"; replyTo: string | null } | { kind: "review"; id: string; at: string; actor: PrActor; verdict: "approved" | "changes-requested" | "commented" | "dismissed"; body: string; commit: string | null } | { kind: "event"; id: string; at: string; actor: PrActor | null; event: string } | { kind: "deployment"; id: string; at: string; environment: string; status: "success" | "pending" | "failure" | "inactive" | "unknown"; url: string | null; commit: string }; diff --git a/apps/desktop/test/code-review-read-service.test.ts b/apps/desktop/test/code-review-read-service.test.ts index 4b33c842..02378fbc 100644 --- a/apps/desktop/test/code-review-read-service.test.ts +++ b/apps/desktop/test/code-review-read-service.test.ts @@ -53,6 +53,7 @@ class FakeGitHub { ["7301#74", pull(LENDING, 74, { base: "topic-73", baseSha: sha("c"), head: sha("e") })], ]); timeline = new Map(); + lineComments = new Map(); files = new Map(); checkRuns = new Map(); statuses = new Map(); @@ -146,6 +147,10 @@ class FakeGitHub { } const id = `${repo.id}#${parts[4]}`; if (parts[3] === "pulls" && parts.length === 5) return this.pulls.has(id) ? this.json(call, this.pulls.get(id)) : this.missing(); + if (parts[3] === "pulls" && parts[5] === "comments") { + const { slice, link } = this.page(this.lineComments.get(id) ?? [], query, path!); + return this.json(call, slice, link); + } if (parts[3] === "pulls" && parts[5] === "files") { const { slice, link } = this.page(this.files.get(id) ?? [], query, path!); return this.json(call, slice, link); @@ -1162,3 +1167,56 @@ test("real use: the merge base and the file page are read together between the t }; await together({ op: "files", key, revision, cursor: null }, /\/compare\//, /\/pulls\/73\/files\?/, "the file page is asked for while the merge base is still being read"); }); + +// --- Real-use benchmark, 2026-11-12: comments on lines of the diff were not shown (F3) ----------- + +const lineCommentRow = (id: number, extra: Record = {}) => ({ id, user: { id: 5, login: "bea-fixture", type: "User" }, created_at: "2026-10-19T09:00:00Z", + body: "Should this be `>=`?", path: "policy/schema.ts", line: 41, side: "RIGHT", ...extra }); + +test("real use: comments on lines of the diff arrive with the first activity page, with their file, line and reply", async () => { + const { github, read, prime } = setup(); + await prime(); + github.lineComments.set("7301#73", [lineCommentRow(801), lineCommentRow(802, { in_reply_to_id: 801, body: "Yes.", created_at: "2026-10-19T09:05:00Z" }), lineCommentRow(803, { line: null, side: "LEFT" })]); + const reply = await read({ op: "activity", key: keyOf(LENDING, 73), cursor: null }); + assert.equal(reply.result.state, "ready"); + const rows = value(reply).filter(r => r.kind === "line-comment"); + assert.deepEqual(rows.map(r => r.kind === "line-comment" && [r.id, r.path, r.line, r.side, r.replyTo, r.body, r.actor.login]), [ + ["801", "policy/schema.ts", 41, "RIGHT", null, "Should this be `>=`?", "bea-fixture"], + ["802", "policy/schema.ts", 41, "RIGHT", "801", "Yes.", "bea-fixture"], + ["803", "policy/schema.ts", null, "LEFT", null, "Should this be `>=`?", "bea-fixture"], + ]); + const asked = github.calls.filter(c => c.endpoint.includes("/pulls/73/comments")); + assert.deepEqual(asked.map(c => c.endpoint.split("/pulls/")[1]), ["73/comments?per_page=100&page=1"]); +}); + +test("real use: a refused or malformed line-comment read leaves the timeline usable and says the page is partial", async () => { + const { github, read, prime } = setup(); + await prime(); + github.overrides.push({ pattern: /\/pulls\/73\/comments\?/, answer: { kind: "http", status: 403, headers: {}, body: Buffer.from("{}") } }); + const refused = await read({ op: "activity", key: keyOf(LENDING, 73), cursor: null }); + assert(refused.result.state === "partial"); + assert.equal(refused.result.reason, "denied"); + assert.equal(refused.result.coverage.complete, false); + assert(value(refused).some(r => r.kind === "opened")); + + github.overrides.length = 0; + github.lineComments.set("7301#73", [lineCommentRow(801), { id: 802, body: "no author, file or date" }]); + const malformed = await read({ op: "activity", key: keyOf(LENDING, 73), cursor: null }); + assert(malformed.result.state === "partial"); + assert.equal(malformed.result.reason, "failed"); + assert.deepEqual(value(malformed).filter(r => r.kind === "line-comment").map(r => r.id), ["801"]); +}); + +test("real use: more than one page of line comments is reported as capped, and later activity pages do not ask again", async () => { + const { github, read, prime } = setup(); + await prime(); + github.lineComments.set("7301#73", Array.from({ length: 101 }, (_, i) => lineCommentRow(1000 + i))); + const first = await read({ op: "activity", key: keyOf(LENDING, 73), cursor: null }); + assert(first.result.state === "partial"); + assert.equal(first.result.reason, "capped"); + assert.equal(value(first).filter(r => r.kind === "line-comment").length, 100); + github.timeline.set("7301#73", Array.from({ length: 150 }, (_, i) => ({ event: "labeled", id: 5000 + i, created_at: "2026-10-19T10:00:00Z", actor: { id: 5, login: "bea-fixture", type: "User" } }))); + const before = github.calls.filter(c => c.endpoint.includes("/pulls/73/comments")).length; + await read({ op: "activity", key: keyOf(LENDING, 73), cursor: "p2" }); + assert.equal(github.calls.filter(c => c.endpoint.includes("/pulls/73/comments")).length, before); +}); diff --git a/apps/desktop/test/fixtures/code-review-gh-world.ts b/apps/desktop/test/fixtures/code-review-gh-world.ts index 3d9d8ab1..23cf60c8 100644 --- a/apps/desktop/test/fixtures/code-review-gh-world.ts +++ b/apps/desktop/test/fixtures/code-review-gh-world.ts @@ -138,6 +138,8 @@ if (method === "PATCH" || (method === "POST" && (route === "graphql" || /\/reque && value && value.base && value.head && value.base.sha === comparison[2] && value.head.sha === comparison[3]); if (declared) found = { base_commit: { sha: comparison[2] }, merge_base_commit: { sha: comparison[2] } }; } + // A declared pull request with no line comments listed has none. + if (found === undefined && /\/pulls\/\d+\/comments$/.test(route) && world.routes[route.replace(/\/comments$/, "")]) found = []; if (found && /\/pulls\/\d+$/.test(route)) found = changed(route, found); if (found && /\/pulls\/\d+$/.test(route) && mergedAs(route)) { found = { ...found, state: "closed", merged: true, merged_at: "2026-10-18T20:40:00Z", merged_by: { ...world.user, type: "User" }, diff --git a/docs/design/code-review.md b/docs/design/code-review.md index e1515479..3ff54981 100644 --- a/docs/design/code-review.md +++ b/docs/design/code-review.md @@ -171,7 +171,7 @@ Every call is `gh api --method GET` with validated, encoded segment | `inbox-page` | `group`, `query`, `cursor` | `PrSummary[]` | the same search, next page; GitHub serves 1,000 results, so `p34` is the last | | `resolve` | `input` (a pasted link) | `{ locator, key }` | `parsePrLocator`, then `repos/{owner}/{repo}` for the stable id and `pulls/{n}` to check the PR exists | | `overview` | `key` | `PrOverview` with its `revision` | `repos/{owner}/{repo}/pulls/{n}` | -| `activity` | `key`, `cursor` | `PrActivity[]` | `repos/{owner}/{repo}/issues/{n}/timeline`, 100 a page; the first page adds the opening from `pulls/{n}` and up to 20 current-head provider deployments from `deployments?sha={headSha}`, each with its latest status | +| `activity` | `key`, `cursor` | `PrActivity[]` | `repos/{owner}/{repo}/issues/{n}/timeline`, 100 a page; the first page adds the opening from `pulls/{n}` up to 20 current-head provider deployments from `deployments?sha={headSha}`, each with its latest status, and the first 100 comments on lines of the diff from `pulls/{n}/comments` (more is reported as capped). Whether a comment's thread is resolved is not read: GitHub gives that only over GraphQL | | `checks` | `key`, `revision` | `PrCheck[]` for that head | `commits/{headSha}/check-runs` and `commits/{headSha}/status`, 100 a page, up to 10 pages each; `reporter` is a run's `app.slug` or a status's `creator.login` | | `stack` | `key` | `PrStack`, labelled `inferred` | CR-4 reads up to 1,000 open PRs with `repos/{owner}/{repo}/pulls?state=open`; equal base/head branch refs within the same stable repository form the inferred relationship. Branching, cycles, a capped read, forks or an unresolved root yield unavailable ordering. | | `files` | `key`, `revision`, `cursor` | `PrFiles` | `repos/{owner}/{repo}/pulls/{n}/files`, 100 a page (GitHub stops at 3,000 files, so `p30` is the last) | diff --git a/docs/status.md b/docs/status.md index dc9562a6..e88fd433 100644 --- a/docs/status.md +++ b/docs/status.md @@ -39,10 +39,8 @@ the `Release` workflow, behind the `release-signing` reviewer → GitHub release ## Landing page -The download site lives in `apps/site`, deployed to Vercel project `modex`. Since -2026-11-12 it wears the desktop app's graphite appearance: the hero is the app's welcome -workspace (start card, four work modes, shortcuts), and the workflow captures were retaken from -the current interface. It follows a concrete task through +The download site lives in `apps/site`, deployed to Vercel project `modex`. The new +landing design keeps the near-black blue/pink identity and follows a concrete task through request, proposed patch and approved result with manually selected real app captures. The page scrolls through agent choice, parallel worktrees, Pages/Knowledge, setup, optional iPhone Companion and inline FAQ. Mobile retains the product explanation and platform @@ -63,29 +61,12 @@ homepage and generated brand artwork now use that address. The Vercel alias repository's site-only build and output configuration. See [site development and asset provenance](../apps/site/README.md) and [landing verification](reviews/2026-10-11-landing-clarity.md). -## Browser demo - -`apps/web` puts the desktop renderer in a browser on the Store edition's in-memory demo -workspace, for (Vercel project `modex-app`, root `apps/web`). Threads, -the approval, the sample change and replies are scripted in the tab; no model, CLI, file or -network request is involved after the page loads, and there is still no hosted or API mode. A -banner says so and links to the Mac download; phones get a short explanation and a link to the -site. The landing page's "Try the demo" opens it. See [apps/web](../apps/web/README.md). - ## On main, unreleased -- **LM-2 metadata and credential acceptance** (#378). The complete 13-clause audit and packaged macOS synthetic-key receipt support closure on signed main `5a580d4f`. The first Settings-click timeout remains unexplained and retained; the second canonical invocation passed the unchanged encryption, masking, retrieval and clearing assertions. No local inference admission, release or universal platform claim follows. [Acceptance and native limits](reviews/2026-11-12-lm2-secure-storage-acceptance.md). - -- **Model-picker search** (#381, #502). Protected main `bf497f7` has connection/model filtering with exact IDs, retained query/focus through metadata completion, and keyboard return to the filter. Its signed merge exactly matches the reviewed/tested tree; the protected queue passed 2,478 units with 36 skips, 520 desktop E2E cases with eight skips and seven site cases. The separate source iPhone suite passed 43 ordinary cases and one expected-failure selftest; installer/human/admission limits remain. The full #381 preservation and qualification matrix stays open. [Delivery and limits](reviews/2026-11-12-model-search.md). - -- **Reproducible CF-8 captures and performance** (#281). The opt-in [procedure](../apps/desktop/bench/README.md) verifies source/build/core/driver identity and retains inputs/first logs. [Unified candidate qualification](reviews/2026-11-12-cf8-reproduction-candidate.md) records twelve retention cases and two canonical performance cases at `8771c3c`, fourteen-case/33-image source-export controls for both historical reference and candidate, exact image hashes and listed visual differences. Source `8771c3c` also passed hosted units/macOS/iPhone/site/web checks with its actual preview tree verified. The combined criterion still needs protected delivery and a literal on-main audit; all other native/provider/device/human/child acceptance remains open, with no release or admission claim. - The published application source is `6a97d23aaea315b29008890f25dde2d7ea07f1d0` (v0.4.1). v0.4.2 is in preparation with Code Review hidden ([review](reviews/2026-11-03-v0.4.2-release-review.md)). Later source deliveries remain unreleased: #462 records local-model context provenance; #461 enforces local-only auxiliary dispatch; #465 refuses known cloud-routed and non-generative models; #463 (`32f1cb4`) defers Markdown far from the view so long threads open fast. Main still does not construct `LocalExecution`; native qualification and product admission remain separate gates. #459, #460 and #464 (`3d72c6e`, the CR-3 acceptance re-run) are evidence/documentation deliveries after the release source. Also unreleased, since that summary: #467 (`8a28df3`) adds the Claude account pool with OrcaRouter keys; #477 (`49aa449`) keeps Code Review links right after a repository rename; #487 (`b785054`) adds CF-3 draft and YOLO regressions; #488 (`68fe543`) adds owner-authorized worktree retirement; #490 (`a4f2f70`) adds the Code Review setting and its gates, and turned Code Review on by default. #492 (`4297235`) turned that default off, because Val chose v0.4.2 with Code Review hidden on 2026-11-03. #468, #470, #472, #473, #474, #476 and #483 are evidence or documentation only. -Automatic credit conservation adds account-bound CLI quota admission, configurable 20% allowance / 10 provider-credit-unit thresholds, economical suitable routes and explicit standard speed during conservation. Every automatic model/account replacement rechecks quota, supported effort and the task capability floor; enabled Claude rotation can skip exhausted fresh-thread accounts before coding. Conservation also avoids a separate paid title-generation turn. Local qualification passes build/typechecks, 216 focused cases, 2,530 full unit cases (36 explicit skips), 518 desktop UI cases (11 explicit skips) and seven site UI cases; protected hosted CI and merge-queue acceptance are separate delivery gates. Exact price savings, live coding/billing and installed-release acceptance remain unqualified. [Delivery audit](reviews/2026-11-12-credit-conservation-delivery.md), [behavior](auto-routing.md#automatic-credit-conservation). - ## v0.4.1 publication and remaining acceptance - **v0.4.1 published (2026-10-31).** Signed tag `v0.4.1` names protected merge `6a97d23`. Release run `41163487821` passed signed packaged E2E (479 desktop passed, 4 skipped; 7 site passed), three native updater scenarios, Windows/Linux checks and artifact attachment. All five downloaded installers match the release manifest; macOS signature, Gatekeeper and stapler checks passed. The initial download-failure job stopped before updater execution because its fixture manifest was missing; one retry passed on the unchanged candidate. Original failures and acceptance limits remain in the [publication review](reviews/2026-10-30-v0.4.1-release-review.md#published--2026-10-31-utc). @@ -127,7 +108,7 @@ before relying on a tick. | [#273](https://github.com/TypeSafeAI/modex/issues/273) CF tracker | 9/15 | CF-3, CF-7 and CF-8 are open; their code is on `main`. Fresh full checks name candidate `b643617`, which predates #450, #453 and #463 | Val decides whether to keep `b643617` or pin a new candidate | | [#276](https://github.com/TypeSafeAI/modex/issues/276) CF-3 | 11/13 | Draft, attachment, YOLO and question-focus regressions plus approval recovery coverage (#487, #490, #495). Human D/P rows live on #281 | Val runs D1–D5 | | [#280](https://github.com/TypeSafeAI/modex/issues/280) CF-7 | 11/14 | Steps 1, 2 and 4: model-proposed relations, file hashes and selection/notes context are not built; step-level linking was retired | Val reviews the two saved Notes and records steps 1, 2 and 4 as deferred or retired | -| [#281](https://github.com/TypeSafeAI/modex/issues/281) CF-8 | 9/27 | Keyboard A1–A8, VoiceOver B1–B7, CF-3 D1–D5, P1–P4 and P6; ChatGPT multi-agent restriction check; staged release recommendation; list of remaining visual differences. C1–C5, V1–V3 and P5 are deferred | Retain the [S5 clause receipt](reviews/2026-11-12-cf8-retention.md#literal-s5-reconciliation); complete separate reproducibility/visual gates and Val’s candidate-bound A1–A8 and D1–D5 checks | +| [#281](https://github.com/TypeSafeAI/modex/issues/281) CF-8 | 8/27 | Keyboard A1–A8, VoiceOver B1–B7, CF-3 D1–D5, P1–P4 and P6; memory measurement; ChatGPT multi-agent restriction check; staged release recommendation; list of remaining visual differences. C1–C5, V1–V3 and P5 are deferred | Val chooses the candidate, then runs A1–A8 and D1–D5 | | [#319](https://github.com/TypeSafeAI/modex/issues/319) CR tracker | 2/10 | CR-3 to CR-8 acceptance; the R1–R4 comparison is retired (2026-11-04) but its boxes still name it | Val's [one session](reviews/2026-11-02-v0.5.0-val-session.md) | | [#322](https://github.com/TypeSafeAI/modex/issues/322) CR-3 | 10/14 | Original-reference comparison (AC1; retired 2026-11-04, box still names it), keyboard/VoiceOver (AC4); clearance beside CR-6's inline section is measured on `main` (#491), but these boxes also need the person-run checks | Val runs the [CR-8 VoiceOver checklist](reviews/2026-10-22-cr8-voiceover/checklist.md) | | [#323](https://github.com/TypeSafeAI/modex/issues/323) CR-4 | 10/14 | Original R1/R2 comparison, VoiceOver; clearance beside CR-6's inline section is measured on `main` (#491), but these boxes also need the person-run checks. Avatars are settled as logins only (decision 1, 2026-11-04) | Benchmark on real pull requests replaces the retired comparison; the comparison boxes stay unticked | @@ -135,20 +116,19 @@ before relying on a tick. | [#325](https://github.com/TypeSafeAI/modex/issues/325) CR-6 | 13/14 | Authorized live native smoke (AC6) | Run the smoke once on a small open TypeSafeAI/modex PR (authorized 2026-11-04) | | [#326](https://github.com/TypeSafeAI/modex/issues/326) CR-7 | 13/14 | Live canary on a disposable repository (AC6) | Val names a disposable repository | | [#327](https://github.com/TypeSafeAI/modex/issues/327) CR-8 | 5/17 | Reference comparison (retired 2026-11-04, boxes still name it), VoiceOver and the live gates. Budgets and C76 landed in #490; re-check item 18 and AC5 once Val confirms the budget numbers | Val's [one session](reviews/2026-11-02-v0.5.0-val-session.md) | -| [#376](https://github.com/TypeSafeAI/modex/issues/376) LM tracker | 2/14 | LM-1/LM-2 accepted; LM-3 to LM-7 core acceptance; LM-8 is optional and does not block the core release; `LocalExecution` is not constructed, so the product refuses local turns | Val answers the five questions in `docs/reviews/2026-11-03-lm5-val-decision.md` on branch `lm-ready` | +| [#376](https://github.com/TypeSafeAI/modex/issues/376) LM tracker | 1/14 | LM-2 to LM-8 acceptance; `LocalExecution` is not constructed, so the product refuses local turns | Val answers the five questions in `docs/reviews/2026-11-03-lm5-val-decision.md` on branch `lm-ready` | +| [#378](https://github.com/TypeSafeAI/modex/issues/378) LM-2 | 12/13 | #498 delivered the cold-load explanation and token/export regressions; #499 delivered manual-ID visibility and the complete metadata IPC fixture matrix. Packaged secure-storage acceptance remains open | Complete secure-storage acceptance and re-audit every criterion; existing ticks do not replace current evidence. [Receipt](reviews/2026-11-12-lm2-manual-visibility.md) | | [#379](https://github.com/TypeSafeAI/modex/issues/379) LM-3 | 12/13 | AC1's real native read/edit/check and AC4's regression/configuration receipts now bind to actual main. AC6 still has native redirect and managed-policy gaps; simultaneous isolation claims retain their tested fixture scope | Resolve AC6 without weakening destination binding; product admission stays separate. [Receipt](https://github.com/TypeSafeAI/modex/issues/379#issuecomment-6811858808) | | [#380](https://github.com/TypeSafeAI/modex/issues/380) LM-5 | 6/13 | S5 shared capacity/cancellable waiting/explicit status and AC3/AC5 are reconciled on protected main. Redirect privacy, action-safe compaction, genuine OOM and older-client presentation remain open | Complete remaining engineering/native gates; preserve #475's owner disposition. [Delivered S5 evidence](https://github.com/TypeSafeAI/modex/issues/380#issuecomment-6815410455) | -| [#381](https://github.com/TypeSafeAI/modex/issues/381) LM-4 | 5/13 | S2/S4/S5/AC3/AC6 are supported on main. Native compatibility-test/qualification UI, full state/keyboard/minimum-window coverage and phone inference provenance remain incomplete | Complete the remaining implementation and producer/human/device gates; product admission stays separate. [UI/race and S5 safety receipts](reviews/2026-11-12-local-model-refresh-preservation.md#literal-s2-and-ac3-reconciliation) | +| [#381](https://github.com/TypeSafeAI/modex/issues/381) LM-4 | 2/13 | S4 separates inference/workspace/harness labels and AC6 preserves existing cloud/workspace behavior on main. Search, native compatibility-test/qualification UI and phone inference provenance are not implemented | Complete missing implementation, delayed-refresh/state/keyboard coverage and human/device gates; product admission remains separate. [Criterion evidence](https://github.com/TypeSafeAI/modex/issues/381#issuecomment-6813640283) | | [#382](https://github.com/TypeSafeAI/modex/issues/382) LM-6 | 0/11 | Bounded native bundled llama-server read/edit/check, Stop and two-worker restart receipts exist; the full runtime matrix is incomplete | Qualify remaining runtime/resource cases without generalizing one named combination | | [#383](https://github.com/TypeSafeAI/modex/issues/383) LM-7 | 0/15 | [Evidence map](reviews/2026-11-03-lm7-evidence-map.md) reconciles actual #498/#499 protected delivery and separates fixtures, native models, network-denied and human evidence; privacy/compaction/resource gaps remain | Complete producer criteria, integrated golden/adversarial workflow and runtime/human gates | | [#384](https://github.com/TypeSafeAI/modex/issues/384) LM-8 | 0/11 | Optional; an outside contributor's scope question is unanswered | A maintainer answers the [scope question](https://github.com/TypeSafeAI/modex/issues/384#issuecomment-6390714922) | ## In flight -- **Local-model refresh preservation** (#381). Protected #503 delivered signed `558b54f8`, exact reviewed tree `3ba66a4`. Its queue passed 2,478 units with 36 skips, 522 desktop E2E cases with eight skips and seven site cases. Canonical cases preserve two thread drafts, staged image bytes, search/edit focus and selected text through delayed metadata, and keep an old revision-bound target after endpoint replacement. The full S2/AC3 UI/race audit and conservative S5 option/pinning guards are reconciled at five of 13 boxes; qualification/provenance/admission/human requirements remain open. [Delivery and limits](reviews/2026-11-12-local-model-refresh-preservation.md#actual-protected-delivery). -- **CF-8 repeated source observations** (#281). Three fresh-app history and log replicates per source add 189 measured opens and 63 measured streams on each source. Public per-replicate numbers retain named host/runtime, timestamps and original receipt hashes. The comparison is descriptive, with shared current dependencies and sequential fixed-shape workloads; it does not qualify a historical shipped binary. The full S5 clause audit also checks delivered payload/log caps, cleanup and child regressions; only S5 is now supported, at nine of 27 issue boxes. Separate reproducibility, native and human acceptance remain open. [Measurements and limits](reviews/2026-11-12-cf8-retention.md). - **Local-service queue progress** (#380). A follow-up from merged #499 adds one waiting notice and a neutral continuation notice through the existing host-event path, plus an abort check at capacity handoff. Three canonical regressions failed before repair; 39 focused cases now pass, including actual runner/store persistence before dispatch and cancellation with no continuation or extra child. Full local build/typechecks, 2,478 units with 36 skips, 515 desktop E2E cases with 11 skips and seven site cases passed. Protected #500 delivered exact tree `b354cf7` at signed main `4f1d80c`; its queue passed 2,478 units with 36 skips, 518 desktop E2E cases with eight skips and seven site cases. S5 is reconciled at six of 13 issue boxes; product admission and remaining acceptance stay open. [Evidence and limits](reviews/2026-11-12-local-queue-status.md). -- **Manual local-model IDs after metadata failure** (#378, #381). Protected #499 merged at `0f43631dec22db5ca9390e35613a139ae61bff07`, tree `17dfbd74e186da1fb7ecb8759170595ffe4685d5`. Its queue passed 2,474 units with 36 skips, 518 desktop E2E cases with eight skips and seven site cases. The source-head iPhone suite separately passed 44 executions, including its intentional screenshot-failure selftest; the queue iPhone job skipped. Manual visibility and IPC regressions are delivered; #378’s metadata/credential scope is accepted, while full #381 and remaining native/human acceptance stay open. [Evidence and limits](reviews/2026-11-12-lm2-manual-visibility.md). +- **Manual local-model IDs after metadata failure** (#378, #381). Protected #499 merged at `0f43631dec22db5ca9390e35613a139ae61bff07`, tree `17dfbd74e186da1fb7ecb8759170595ffe4685d5`. Its queue passed 2,474 units with 36 skips, 518 desktop E2E cases with eight skips and seven site cases. The source-head iPhone suite separately passed 44 executions, including its intentional screenshot-failure selftest; the queue iPhone job skipped. Manual visibility and IPC regressions are delivered; full issue/native/human acceptance remains open. [Evidence and limits](reviews/2026-11-12-lm2-manual-visibility.md). - **Noble security pocket source** (#498). Published parent `fc593e0` fetched official archive indexes but failed `security.ubuntu.com` DNS before Linux package installation. The helper now retains all four pockets, including `noble-security`, on the official archive host with the same Ubuntu keyring, strict update failure, nine packages and acquisition/host limits. Official Release metadata confirms that security pocket's presence; it is not signature or runner-connectivity proof. Eight focused cases and frozen build/typecheck/full units passed (2,455 passes, 36 explicit skips, zero failures). Real signed acquisition and installed Linux acceptance remain for fresh exact-head hosted qualification. [Evidence and limits](reviews/2026-11-11-linux-security-pocket.md). @@ -165,7 +145,7 @@ before relying on a tick. - **Companion command recovery (COMP-CMD-2).** #497 is on main as `85143ee`; its tree exactly matches reviewed `d3d2eee`. It keeps timed-out command reads in the picker with explicit retry, retained search/drafts and keyboard Done actions. The required protected queue check passed 505 desktop cases (four skips) and seven site cases; iPhone was skipped for that merge-group event. The independent three-cycle context regression passes without #496's reset, so #496 is closed as superseded; its branch and checkout are preserved. Two fresh-install closeout integration suites each passed 44 executions (43 ordinary passes and one intentional expected failure, zero actual failures/skips), with source hashes unchanged. Human and physical-device acceptance on #276/#281 remains open. [Current integration qualification](reviews/2026-11-11-native-closeout-delivery.md); [historical producer review](reviews/2026-11-08-companion-recovery-pr.md). - **v0.4.2 release.** #492 (`4297235`) prepared it with Code Review hidden by default. Its tag exists, and the GitHub release remains a draft; it is not published. [Review](reviews/2026-11-03-v0.4.2-release-review.md). -- **Code Review acceptance** (#319). Every slice's code is on `main` (design and history: [design page](design/code-review.md), [CR-8 matrix](reviews/2026-11-01-cr8-acceptance-matrix.md)). Built apps hide it by default (#492); Settings → General can show it. #490 added that setting, C76 accessibility coverage, performance budgets as gates and the CR-7 sign-out and CF-3 question-card regressions; it also carries #481, #484, #485 and #491. No live provider run, live GitHub write, VoiceOver pass or reference comparison has happened. Those are listed in [Val's one session](reviews/2026-11-02-v0.5.0-val-session.md), which predates the 2026-11-04 answers and still asks for them. On 2026-11-04 Val answered decisions 1, 5, 6 and 7 ([record](design/code-review.md#open-decisions)): logins only, a local revision-bound Viewed toggle, the new-tab control removed, no access indicator; C58 and C59 effort are approved omissions; the reference comparison is retired for a benchmark on real pull requests; real reads and one CR-6 smoke may run on this repository. The Viewed toggle is built and C07 is removed. A benchmark on ten real pull requests of this repository ranked the friction; its first fixes are in: a pull request opens in about two seconds instead of four, comment HTML reads as text, inbox rows show the pull request number, and F6 and `[` / `]` move between areas and files. Review comments made on diff lines are still not shown. The benchmark has not been re-run on the fixed build. +- **Code Review acceptance** (#319). Every slice's code is on `main` (design and history: [design page](design/code-review.md), [CR-8 matrix](reviews/2026-11-01-cr8-acceptance-matrix.md)). Built apps hide it by default (#492); Settings → General can show it. #490 added that setting, C76 accessibility coverage, performance budgets as gates and the CR-7 sign-out and CF-3 question-card regressions; it also carries #481, #484, #485 and #491. No live provider run, live GitHub write, VoiceOver pass or reference comparison has happened. Those are listed in [Val's one session](reviews/2026-11-02-v0.5.0-val-session.md), which predates the 2026-11-04 answers and still asks for them. On 2026-11-04 Val answered decisions 1, 5, 6 and 7 ([record](design/code-review.md#open-decisions)): logins only, a local revision-bound Viewed toggle, the new-tab control removed, no access indicator; C58 and C59 effort are approved omissions; the reference comparison is retired for a benchmark on real pull requests; real reads and one CR-6 smoke may run on this repository. The Viewed toggle is built and C07 is removed. A benchmark on ten real pull requests of this repository ranked the friction; its first fixes are in: a pull request opens in about two seconds instead of four, comment HTML reads as text, inbox rows show the pull request number, and F6 and `[` / `]` move between areas and files. Comments made on diff lines are listed in Activity with their file and line (the first 100; whether a thread is resolved is not read, and they are not yet shown beside the line in Changes). The benchmark has not been re-run on the fixed build. - **Conversation fidelity** ([tracker #273](https://github.com/TypeSafeAI/modex/issues/273)). CF-3, CF-7 and CF-8 stay open; their code is on `main`. The #489 question-focus repair and Approve/Deny/Stop/withdrawal draft coverage are integrated by #495. The human gates are under [Open acceptance gates](#open-acceptance-gates). - **Protected delivery diagnostics** (#498). Earlier #497 queue shutdown failures and #498's hosted iOS 26.4.1 post-relaunch TLS stall remain unexplained. The closeout candidate adds bounded test-only native stack sampling and DEBUG-only opt-in TLS callback phases, preserving close outcomes, certificate APIs, exact pins, redirects and deadlines. Fresh build/typecheck, 2,412 units (35 skips), 508 desktop E2E cases (11 explicit skips), seven site cases, 65 native units and the fresh 44-execution traced paired suite passed. Actual iOS logs show five callbacks across two app processes; macOS security controls preserve matching/mismatched-pin and redirect behavior, with default/Release logging silent. The additional canonical export regression passed within eight token-record cases after compilation. The published `be5a4c8` head subsequently passed required macOS, iPhone and Linux/Windows checks; those checks do not validate the later private-workspace trust repair. These remain candidate results, not a TLS/shutdown repair or protected delivery. [Current evidence and limits](reviews/2026-11-11-native-closeout-delivery.md); [shutdown observer](reviews/2026-11-11-electron-shutdown-diagnostics.md). - **Private local workspace continuation** (#379/#380, #498). A network-denied real Codex 0.167.0/Ollama 0.40.16 read reproduced refusal on the next turn after the child persisted its own workspace trust mark. The strict repair admits only that one main-bound private workspace entry, keeps other settings and managed/project overrides refused, and checks captured realpaths before setup and after configuration reads. These spot checks do not establish race-free filesystem identity. All 45 focused tests, root build/typechecks and full units (2,420 passes, 35 skips) passed on the frozen candidate; full E2E passed with 508 desktop passes, 11 explicit skips and seven site passes, with no failures or observed retries. The unchanged 500 ms cold-open gate measured 73.2 ms; all four affected real-model Electron lifecycle cases separately passed with zero skips or retries. Native continuation and completed compaction were observed, but independent session audit found two repeated reads after compaction, so action-safe compaction and production admission remain unqualified. [New qualification and limits](reviews/2026-11-11-native-private-workspace-trust.md). @@ -185,7 +165,7 @@ before relying on a tick. - **Claude account pool live acceptance.** The pool landed in #467. No live OrcaRouter turn, second subscription or real usage-limit message has run. [Design and limits](claude-accounts.md), [repair evidence](reviews/2026-11-01-claude-pool-repair.md). - **Existing PR reconciliation.** #490 carries the content of #481, #484 and #485. #486 was closed on 2026-11-11 after verifying that protected merge #488 replaced it with the safer `retire`; its original worktree and branch were preserved. #475 still has its pre-rebase head; its fixtures are included in the integration below, pending current-source qualification and protected delivery. -- **Companion network acceptance (#109).** The [two-LAN evidence map](reviews/2026-10-28-companion-two-lan-acceptance.md) ties each of the four #109 requirements to the tests that prove it, adds the last race (the interface list changes while Forget paired phones or Turn off runs, and no listener survives with the old token; both shown red against a mutation, green on `main`), and holds the physical two-subnet procedure. Val confirmed on 2026-11-12 that the existing private-IPv4 policy stays, including VPN tunnels and virtual bridges; public, CGNAT, link-local, internal and IPv6 addresses remain excluded. Physical two-LAN acceptance is the remaining gate and stays open because Val cannot run it now. [Current checkpoint](reviews/2026-11-12-companion-network-policy.md). +- **Companion network acceptance (#109).** The [two-LAN evidence map](reviews/2026-10-28-companion-two-lan-acceptance.md) ties each of the four #109 requirements to the tests that prove it, adds the last race (the interface list changes while Forget paired phones or Turn off runs, and no listener survives with the old token; both shown red against a mutation, green on `main`), and holds the physical two-subnet procedure. Two gates remain with Val: running that procedure, and deciding whether VPN tunnels and virtual bridges with private addresses get a listener ([question](https://github.com/TypeSafeAI/modex/issues/109#issuecomment-6464762470)). The filter is unchanged until Val answers. - **v0.4.0 post-publication acceptance and Companion 0.4.0 (9).** Desktop publication is complete. v0.3.0's two post-publication gates (the banner upgrade of the release Mac and the Companion 0.3.0 (8) upload) are superseded: the installed Mac reports signed 0.4.0, and Companion build 9 replaces build 8. The v0.3.0-to-v0.4.0 background upgrade remains unverified: the installed Mac already reports signed 0.4.0 and was left unchanged. Companion build 9 has not been delivered by this release session; its TestFlight upload and physical-device checks remain separate. Human accessibility, real-provider and native-platform account/session checks retain their existing gates. [Publication evidence and limits](reviews/2026-10-24-v0.4.0-release-review.md#published--2026-10-30-utc). - **Mac App Store edition.** A sandboxed Store front end with a separately installed signed host, as Val chose. [Investigation and parity matrix](mac-app-store.md). @@ -272,8 +252,7 @@ that fixed each. ## Next -- **CF-8 reproducibility and visual acceptance** (#281): make the archived repeated-series reproduction portable within the canonical measurement path and reconcile reference/candidate captures and remaining visual differences. The [reviewed comparison and S5 clause audit](reviews/2026-11-12-cf8-retention.md) check named measurements, delivered retained-data caps and child regressions without claiming overall memory reduction, a universal heap ceiling or leak freedom. S5 is supported; separate reproducibility and human/native/device acceptance remain open. - +- **Model-picker search** (#381), owned `model-search` candidate: exact-ID/connection filtering, delayed-listing query/focus and draft preservation, plus keyboard return to the retained filter. Seven focused Electron cases pass; final build/typecheck, 2,478 units with 36 skips, 517 desktop E2E cases with 11 skips and seven site cases passed. Hosted checks and protected delivery remain pending. The full issue, attachment/thread/profile matrix, native qualification and paired-client provenance stay open. [Evidence](reviews/2026-11-12-model-search.md). Roughly in the order they earn their place; none is scheduled.