Skip to content

Commit 7d1288a

Browse files
committed
C++ comments and uri clean up in testing [ci skip]
1 parent 90c9734 commit 7d1288a

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

inst/tinytest/test_arrayschema.R

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,8 @@ trg <- c(col1 = FALSE, enum1 = TRUE, col2 = FALSE, enum2 = TRUE, enum3 = TRUE)
217217

218218
expect_equal(tiledb_array_has_enumeration(arr), trg)
219219

220+
unlink(uri)
221+
220222
# case 2 (unordered enums)
221223
uri <- tempfile()
222224

@@ -232,6 +234,8 @@ arr <- tiledb_array(uri)
232234

233235
expect_equal(tiledb_array_has_enumeration(arr), trg)
234236

237+
unlink(uri)
238+
235239
# case 3 (unordered map all attributes)
236240
uri <- tempfile()
237241

src/libtiledb.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1918,6 +1918,8 @@ XPtr<tiledb::ArraySchema> libtiledb_array_schema(
19181918
as<std::vector<std::string>>(enumerations[i]);
19191919
std::string enum_name = std::string(enumnames[i]);
19201920

1921+
// Get attribute by enum name ('attributes' list is named from R level)
1922+
// See https://github.com/TileDB-Inc/TileDB-R/issues/853
19211923
XPtr<tiledb::Attribute> attr =
19221924
as<XPtr<tiledb::Attribute>>(attributes[enum_name]);
19231925

0 commit comments

Comments
 (0)