Explicit type and NoneDropDownItem refactor

marc-antoine-girard · marc-antoine-girard · commit 1b5e0af196c7 · 2022-07-22T11:46:50.000-04:00
diff --git a/Editor/Items/NoneDropdownItem.cs b/Editor/Items/NoneDropdownItem.cs
@@ -4,10 +4,9 @@ namespace TNRD.Items
 {
     public class NoneDropdownItem  : AdvancedDropdownItem, IDropdownItem
     {
-        private ReferenceMode mode => ReferenceMode.Raw;
         public NoneDropdownItem() : base("None") { }
 
-        ReferenceMode IDropdownItem.Mode => mode;
+        ReferenceMode IDropdownItem.Mode => ReferenceMode.Raw;
 
         public object GetValue()
         {
diff --git a/Editor/Utilities/SerializableInterfaceAdvancedDropdown.cs b/Editor/Utilities/SerializableInterfaceAdvancedDropdown.cs
@@ -48,7 +48,7 @@ protected override AdvancedDropdownItem BuildRoot()
                 .AddChild(new ClassesItemBuilder(interfaceType).Build())
                 .AddChild(new SceneItemBuilder(interfaceType, relevantScene).Build());
 
-            foreach (var dropdownItem in item.children)
+            foreach (AdvancedDropdownItem dropdownItem in item.children)
             {
                 dropdownItem.AddChild(new NoneDropdownItem());
             }

Original file line number	Diff line number	Diff line change
`@@ -4,10 +4,9 @@ namespace TNRD.Items`
`4`	`4`	`{`
`5`	`5`	`public class NoneDropdownItem : AdvancedDropdownItem, IDropdownItem`
`6`	`6`	`{`
`7`		`- private ReferenceMode mode => ReferenceMode.Raw;`
`8`	`7`	`public NoneDropdownItem() : base("None") { }`
`9`	`8`
`10`		`- ReferenceMode IDropdownItem.Mode => mode;`
	`9`	`+ ReferenceMode IDropdownItem.Mode => ReferenceMode.Raw;`
`11`	`10`
`12`	`11`	`public object GetValue()`
`13`	`12`	`{`
Original file line number	Diff line number	Diff line change
`@@ -48,7 +48,7 @@ protected override AdvancedDropdownItem BuildRoot()`
`48`	`48`	`.AddChild(new ClassesItemBuilder(interfaceType).Build())`
`49`	`49`	`.AddChild(new SceneItemBuilder(interfaceType, relevantScene).Build());`
`50`	`50`
`51`		`- foreach (var dropdownItem in item.children)`
	`51`	`+ foreach (AdvancedDropdownItem dropdownItem in item.children)`
`52`	`52`	`{`
`53`	`53`	`dropdownItem.AddChild(new NoneDropdownItem());`
`54`	`54`	`}`