Reorganize memory pool size list

[Caball009]

GeneralsGameCode/Core/GameEngine/Source/Common/System/GameMemoryInitPools_GeneralsMD.inl

Lines 19 to 21 in afa8aa3

	// And please be careful of duplicates. They are not rejected.
	// not const -- we might override from INI
	static PoolSizeRec PoolSizes[] =

This list currently contains 2 duplicates names (with different values): BoxPrototypeClass and WeaponBonusUpgrade, which need to be removed.

Maybe we can also order everything alphabetically (while keeping the W3D pools separate). We should be able to run either a compile-time check or run-time check in debug mode to verify that there are no duplicates.

MEMORY_POOL_GLUE_WITH_USERLOOKUP_CREATE( WeaponBonusUpgrade, "WeaponBonusUpgrade" )
As an aside, maybe it'd be nice if macros like the the above also include a check to verify that a memory pool exists for a given name.

[xezon]

Adding checks to avoid errors would be nice yes.

[jurassicLizard]

I am exploring/studying this awesome project so excuse my input if it is lacking deep knowhow about the repo's intricaties just wanting to share an idea if it is useful :

unit tests could catch these things,example : load entries in a map or unordered set (we could even improvise a hash set if C++11 is not accepted even for testing due to vc6 compatibility)

using the name as key and then assert that number of entries in the array and the unordered sets / map is the same. I see a lot of potential regressions happening with all the work being done maybe setting up a unit testing framework would not be such a bad idea considering the potential for regressions and the fact that cmake is used so ctest is also there to help ?