Debug builds stall when entering the main menu due to excessive map cache logging

[Stubbjax]

Prerequisites

• I have searched for similar issues and confirmed this is not a duplicate

Game Version

• Command & Conquer Generals
• Command & Conquer Generals: Zero Hour
• Other (please specify below)

Bug Description

Debug builds stall when entering the main menu due to excessive map cache logging.

Observed difference in loading times before and after #1775: 00:01.167 vs 00:06.067

Output from the excessive logging is attached below.

Reproduction Steps

1. Run a debug build of the game
2. Observe a longer time than usual to enter the main menu

Additional Context

MapCache Logs.txt

[xezon]

If you have "Maps" folder in your game install and you run RTS_DEBUG build, then it will generate a new MapCache.ini in there, which can be costly.

This is intentional and what EA had intended, but perhaps was broken before. It now works correctly.

It happens in MapCache::updateCache and only triggers when Maps folder exists (which originally does not).

If you delete Maps folder, or run non RTS_DEBUG build, then this code will not execute.